)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"573d44ff3b47803df818361e557c5cb73f06ea27","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-12-03 16:34:19 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Make QEMU_IMG_LIMITS process limits configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10e53de27b063b1e514e04066d0eb56a86188e9a"},{"line_number":10,"context_line":"Signed-off-by: melanie witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a5a5a821_e4c495c4","line":7,"updated":"2025-12-04 00:53:26.000000000","message":"I thought of making this configurable and checked if any other project does that.\n\nI found that Cinder and Ironic use config options for their qemu-img process limits:\n\n* https://github.com/openstack/cinder/blob/f38c2950b13a2cde2ae9f146cf525a9d54c8b830/cinder/image/image_utils.py#L115-L117\n\n* https://github.com/openstack/ironic/blob/05b9dc22c7681cf8b9e30dd5eb0c0505a10ed7c5/ironic/common/qemu_img.py#L34-L36","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"573d44ff3b47803df818361e557c5cb73f06ea27","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-12-03 16:34:19 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Make QEMU_IMG_LIMITS process limits configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10e53de27b063b1e514e04066d0eb56a86188e9a"},{"line_number":10,"context_line":"Signed-off-by: melanie witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0946c68a_1cd545f2","line":8,"updated":"2025-12-04 00:53:26.000000000","message":"Related-Bug: #2116852","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"51c0caf47101818501fdd6b3840a41f720843a6b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-12-03 16:34:19 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Make QEMU_IMG_LIMITS process limits configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10e53de27b063b1e514e04066d0eb56a86188e9a"},{"line_number":10,"context_line":"Signed-off-by: melanie witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8a521b21_4cea69ea","line":8,"in_reply_to":"0946c68a_1cd545f2","updated":"2025-12-04 22:12:07.000000000","message":"Done","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8cc05e07e083e7b2cd487b43975f2633ce3c7a92","unresolved":true,"context_lines":[{"line_number":30,"context_line":"``images_address_space_limit`` to the ``[libvirt]`` section to allow"},{"line_number":31,"context_line":"for tuning of the qemu-img process limits."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Related-Bug: #2116852"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: I10e53de27b063b1e514e04066d0eb56a86188e9a"},{"line_number":36,"context_line":"Signed-off-by: melanie witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f95a7572_4f6dac78","line":33,"updated":"2025-12-05 08:37:56.000000000","message":"I would even go and make it Closes-Bug. I don\u0027t think we will dig deeper into that bug in the near future.","commit_id":"3ce826235ba7e69aed589ef791414bb72d9410ac"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"59d6787617cf33d9b72ced0d48c4bd3bbd183ca2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"``images_address_space_limit`` to the ``[libvirt]`` section to allow"},{"line_number":31,"context_line":"for tuning of the qemu-img process limits."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Related-Bug: #2116852"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: I10e53de27b063b1e514e04066d0eb56a86188e9a"},{"line_number":36,"context_line":"Signed-off-by: melanie witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"34e62cd1_d46919a2","line":33,"in_reply_to":"f95a7572_4f6dac78","updated":"2025-12-05 18:39:40.000000000","message":"Fair point. Done.","commit_id":"3ce826235ba7e69aed589ef791414bb72d9410ac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"509edc8abf98ae1f965ce72bdcd315516b86c84f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"924829e7_b9314a28","updated":"2025-12-04 12:53:51.000000000","message":"I\u0027m OK with the direction.","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8f5ea451bcadaa0b169bc3adad5e222ccb885963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d076dffe_9bb7221a","updated":"2025-12-06 16:34:51.000000000","message":"Thanks","commit_id":"7f4343198c2aec73b10ad7c01ba0df87fe41f579"}],"nova/conf/libvirt.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"509edc8abf98ae1f965ce72bdcd315516b86c84f","unresolved":true,"context_lines":[{"line_number":1082,"context_line":"               default\u003d30,"},{"line_number":1083,"context_line":"               help\u003d\u0027CPU time limit in seconds for qemu-img\u0027),"},{"line_number":1084,"context_line":"    cfg.IntOpt(\u0027images_address_space_limit\u0027,"},{"line_number":1085,"context_line":"               default\u003d1,"},{"line_number":1086,"context_line":"               help\u003d\u0027Address space limit in gigabytes for qemu-img\u0027),"},{"line_number":1087,"context_line":"]"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5274c86d_7f5991eb","line":1085,"updated":"2025-12-04 12:53:51.000000000","message":"bump it to 2G as 1G is not enough when we run with new enough CEPH. Our ceph jobs was moved to Debian when we hit this limit with Ubuntu, so currently we don\u0027t see the problem upstream.","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"51c0caf47101818501fdd6b3840a41f720843a6b","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"               default\u003d30,"},{"line_number":1083,"context_line":"               help\u003d\u0027CPU time limit in seconds for qemu-img\u0027),"},{"line_number":1084,"context_line":"    cfg.IntOpt(\u0027images_address_space_limit\u0027,"},{"line_number":1085,"context_line":"               default\u003d1,"},{"line_number":1086,"context_line":"               help\u003d\u0027Address space limit in gigabytes for qemu-img\u0027),"},{"line_number":1087,"context_line":"]"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"30d1e276_852d3d61","line":1085,"in_reply_to":"5274c86d_7f5991eb","updated":"2025-12-04 22:12:07.000000000","message":"Done","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3cfc2c97d4f025908fd41279e1b2d77ef55a381a","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"               help\u003d\u0027CPU time limit in seconds for qemu-img\u0027),"},{"line_number":1084,"context_line":"    cfg.IntOpt(\u0027images_address_space_limit\u0027,"},{"line_number":1085,"context_line":"               default\u003d1,"},{"line_number":1086,"context_line":"               help\u003d\u0027Address space limit in gigabytes for qemu-img\u0027),"},{"line_number":1087,"context_line":"]"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"libvirt_lvm_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"22af1636_659437e2","line":1086,"updated":"2025-12-04 00:43:02.000000000","message":"I just found gibi\u0027s test patches at https://review.opendev.org/q/topic:%22bug/2116852%22\n\nBased on the results there, should we maybe make these `FloatOpt` instead, to allow fractional GB?","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"59d6787617cf33d9b72ced0d48c4bd3bbd183ca2","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"               help\u003d\u0027CPU time limit in seconds for qemu-img\u0027),"},{"line_number":1084,"context_line":"    cfg.IntOpt(\u0027images_address_space_limit\u0027,"},{"line_number":1085,"context_line":"               default\u003d1,"},{"line_number":1086,"context_line":"               help\u003d\u0027Address space limit in gigabytes for qemu-img\u0027),"},{"line_number":1087,"context_line":"]"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"libvirt_lvm_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"bda1d6b2_23f758de","line":1086,"in_reply_to":"0bfbdd23_6c5a880d","updated":"2025-12-05 18:39:40.000000000","message":"Acknowledged","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8cc05e07e083e7b2cd487b43975f2633ce3c7a92","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"               help\u003d\u0027CPU time limit in seconds for qemu-img\u0027),"},{"line_number":1084,"context_line":"    cfg.IntOpt(\u0027images_address_space_limit\u0027,"},{"line_number":1085,"context_line":"               default\u003d1,"},{"line_number":1086,"context_line":"               help\u003d\u0027Address space limit in gigabytes for qemu-img\u0027),"},{"line_number":1087,"context_line":"]"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"libvirt_lvm_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"0bfbdd23_6c5a880d","line":1086,"in_reply_to":"22af1636_659437e2","updated":"2025-12-05 08:37:56.000000000","message":"Just go with the IntOpt for simplicity","commit_id":"ff382524b6ccd4adbc03ff03003913f86e91bf2e"}]}
