)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"6c7d61b6e3f92cfa9417f9e847f3b3b2ee265321","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"            token \u003d vm_util._get_token(dcs)"},{"line_number":1705,"context_line":"            for dco in dcs.objects:"},{"line_number":1706,"context_line":"                dc_ref \u003d dco.obj"},{"line_number":1707,"context_line":"                ds_refs \u003d []"},{"line_number":1708,"context_line":"                prop_dict \u003d vm_util.propset_dict(dco.propSet)"},{"line_number":1709,"context_line":"                name \u003d prop_dict.get(\u0027name\u0027)"},{"line_number":1710,"context_line":"                vmFolder \u003d prop_dict.get(\u0027vmFolder\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7eb81b11","line":1707,"updated":"2014-06-05 11:44:19.000000000","message":"The list \u0027ds_refs\u0027 is allocated each time the code enters the loop.\nI think it should be allocated ONLY when \u0027datastore_refs\u0027 is not None.","commit_id":"63160f76a6eb871e259cc13588a337c5316f50b6"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"6c7d61b6e3f92cfa9417f9e847f3b3b2ee265321","unresolved":false,"context_lines":[{"line_number":1711,"context_line":"                datastore_refs \u003d prop_dict.get(\u0027datastore\u0027)"},{"line_number":1712,"context_line":"                if datastore_refs:"},{"line_number":1713,"context_line":"                    datastore_refs \u003d datastore_refs.ManagedObjectReference"},{"line_number":1714,"context_line":"                    for ds in datastore_refs:"},{"line_number":1715,"context_line":"                        ds_refs.append(ds.value)"},{"line_number":1716,"context_line":"                else:"},{"line_number":1717,"context_line":"                    LOG.debug(\"Datacenter %s doesn\u0027t have any datastore \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7efd7bb0","line":1714,"updated":"2014-06-05 11:44:19.000000000","message":"ds_refs \u003d [ds.value for ds in datastore_refs]","commit_id":"63160f76a6eb871e259cc13588a337c5316f50b6"}]}