)]}'
{"id":"openstack%2Fnova~971448","triplet_id":"openstack%2Fnova~master~I3f40d9dad6ef87e6fa4db0ea4065a77421e8c271","project":"openstack/nova","branch":"master","topic":"bug/2136815","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-12-18 17:23:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3f40d9dad6ef87e6fa4db0ea4065a77421e8c271","subject":"Do not mock threading.Event.wait","status":"MERGED","created":"2025-12-18 15:51:27.000000000","updated":"2025-12-18 17:26:18.000000000","submitted":"2025-12-18 17:23:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"971448-bug/2136815","meta_rev_id":"3402362b4f6aadf90fdb3717f6d7537a3dbf4b77","_number":971448,"virtual_id_number":971448,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-12-18 17:23:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2025-12-18 16:45:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-12-18 17:26:18.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2025-12-18 16:23:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2025-12-18 16:45:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}],"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-18 16:22:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-12-18 16:23:04.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2025-12-18 16:29:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-12-18 16:36:35.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2025-12-18 16:45:45.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2025-12-18 16:50:57.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-12-18 17:26:18.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"}],"messages":[{"id":"6d9d2467dab7d24929fb7fae3489721698944fa1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-12-18 15:51:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ca2bdb2e504bba754853b973958415472a6cfec","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 16:22:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/262cd888064341ae98e276a0295aa157\n\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/6ea8e8f3057b44e3a2d6d68314641035 : SUCCESS in 18m 17s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/3ae6c64fe7274aba936436683536eef3 : SUCCESS in 24m 34s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/dfee0eda1ea34ff692541b96ce88b8c2 : SUCCESS in 21m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"208011fac8f3d61f8a8766d445631bc0b46b25a8","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2025-12-18 16:23:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"049796fc3ec896454021286d5d6a3fe9013cbd1a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 16:29:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/780563a551aa4dba8c6ab67b06066c1d\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/79ce97813a0e47978ef3f6846a442687 : SUCCESS in 27m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/45438ff5fae945858d55b21ea83c66b7 : SUCCESS in 8m 49s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b029ca111ce74344a035c95c89fba8bc : SUCCESS in 15m 13s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/6ab2a99750974212bdc8ec98efa309fd : SUCCESS in 11m 40s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3d01d711a60e4bd1945354104ff46a98 : SUCCESS in 13m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a698f6e2598402db5257ecc6e733c48 : SUCCESS in 10m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/2520b1dc2ef347cc837df65ca31596b9 : SUCCESS in 5m 06s (non-voting)\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/10b423ade4764a31865fef9ac21fe664 : SUCCESS in 20m 16s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/f9055b1935234aff96a5ee9f7f71c2f8 : SUCCESS in 33m 45s\n- nova-tox-py312-threading https://zuul.opendev.org/t/openstack/build/a011e339347243e99a075ea666033e46 : SUCCESS in 13m 04s","accounts_in_message":[],"_revision_number":1},{"id":"43e35bcf7bed329fa8953946685649882d2b3e19","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-12-18 16:36:35.000000000","message":"Patch Set 1:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1},{"id":"0e2b8af312e1f6607ca8a1b023f171203a8ba4aa","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-18 16:45:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7649045adf8648678655ac5dc1fa01ec12ef83fa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 16:46:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0633c04c8bc9ed86a41aa65f98a17666f32a73d3","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2025-12-18 16:50:57.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* quobyteci:  nova_quobyteci : FAILURE, logs at: https://oscilogs.quobyte.com/logs/I3f40d9dad6ef87e6fa4db0ea4065a77421e8c271 .","accounts_in_message":[],"_revision_number":1},{"id":"74f79714d3b87ba2e3e8748f0c4bb79de530eebc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 17:23:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/51278fb89042414c8d83fabc5e51d5f6\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/811a89e8efa843fd9e22ec88dcc24d62 : SUCCESS in 7m 21s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/7559bbdf52444e98a8434a42ad2dfa14 : SUCCESS in 14m 52s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/438d0a6b66994c36a228b6f9b143f4d9 : SUCCESS in 17m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7924a73c58154e37bb249cb1d0e17782 : SUCCESS in 12m 19s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/065a6e83e095476eb5a265a528eca863 : SUCCESS in 28m 24s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/95106601eae9425daab591b6d6f5c8a9 : SUCCESS in 32m 52s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/5b5185d833fa417c92f962fb4e0e5820 : SUCCESS in 4m 56s\n- nova-tox-py312-threading https://zuul.opendev.org/t/openstack/build/03ebef1e73c24091a1ea05663ca33f39 : SUCCESS in 14m 53s","accounts_in_message":[],"_revision_number":1},{"id":"0021d31a9961694cd40b871a63dc3e7f82dfbdec","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 17:23:52.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"196b29334b875c07244ed05e71434c36b134b5fc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 17:24:46.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b3c04ec46b9446e9b3bd9614a43529f4\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2e5b9628c8ad4fc0ab223262d647f682 : SUCCESS in 41s","accounts_in_message":[],"_revision_number":1},{"id":"3402362b4f6aadf90fdb3717f6d7537a3dbf4b77","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2025-12-18 17:26:18.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"081130d329f2c7386ddbada8c0e5ac47188f5c12","revisions":{"081130d329f2c7386ddbada8c0e5ac47188f5c12":{"kind":"REWORK","_number":1,"created":"2025-12-18 15:51:27.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/48/971448/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/48/971448/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/48/971448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/48/971448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/48/971448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/48/971448/1"}}},"commit":{"parents":[{"commit":"3e5a2dbad73ff61d27db8750480e2c0b52133676","subject":"Merge \"Follow up test change for 8c8047ce2afae\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e5a2dbad73ff61d27db8750480e2c0b52133676"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-12-18 15:33:09.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-12-18 15:33:09.000000000","tz":60},"subject":"Do not mock threading.Event.wait","message":"Do not mock threading.Event.wait\n\nThere were libvirt disk attach / detach unit test cases that mocked\nthreading.Event.wait to speed up the test execution as the libvirt event\nbased device detach has a 20 seconds timeout.\n\nHowever this mock is very wide. It effects all the threading.Event usage\nduring the test case. As we are switched to the native threaded backed\nof oslo.service we got an LoopingCall implementation that relies on\nthreading.Event to signal when the call is finished. In these test cases\nthe wide mock broke this logic and the LoopingCall signalled \"done\" while\nthe actual call in the background was still running making that call\nleaking out from the test case and therefore under the fixtures the test\ncase tore down after the test case finished. This caused that later the\ncall hit non mocked code paths like importing the real libvirt lib\ninstead of using our libvirt fixture causing late failures.\n\nThe fix is to remove the wide mock and instead change the detach timeout\nin these test cases.\n\nLater follow ups will check put protection in place to avoid\nre-introducing this wide mock.\n\nCloses-Bug: #2136815\nChange-Id: I3f40d9dad6ef87e6fa4db0ea4065a77421e8c271\nSigned-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/081130d329f2c7386ddbada8c0e5ac47188f5c12"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/081130d329f2c7386ddbada8c0e5ac47188f5c12"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}