)]}'
{"id":"openstack%2Fnova~971452","triplet_id":"openstack%2Fnova~master~Id98d8029af673ffa89d6472be98f90a6f0975511","project":"openstack/nova","branch":"master","topic":"typing","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2026-01-09 16:38:31.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id98d8029af673ffa89d6472be98f90a6f0975511","subject":"libvirt: Ensure device alias is present","status":"MERGED","created":"2025-12-18 16:42:51.000000000","updated":"2026-01-09 16:40:46.000000000","submitted":"2026-01-09 16:38:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"971452-typing","meta_rev_id":"b15dad8d4625b3080e4084ff120e6d6e24f88e7a","_number":971452,"virtual_id_number":971452,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-01-09 16:38:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2026-01-09 14:04:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2025-12-19 08:56:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2026-01-09 14:04:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-18 17:45:34.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-12-18 17:45:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-12-18 20:08:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-12-18 20:15:14.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2025-12-19 08:56:48.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2026-01-02 20:00:47.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-01-09 14:04:23.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"38f09b488540f5f66d09e4f74142f4c48d92540d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-18 16:42:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"01ef26918a2aaeb3831804be7bc30d8229eb0cfd","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-18 16:54:20.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"04c71c009aebf8a003cccd83b06d0d769098bcce","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2025-12-18 17:45:34.000000000","message":"Patch Set 1:\n\nBuild Successful \n\n* quobyteci:  nova_quobyteci : SUCCESS, logs at: https://oscilogs.quobyte.com/logs/Id98d8029af673ffa89d6472be98f90a6f0975511 .","accounts_in_message":[],"_revision_number":1},{"id":"733c826391c1f43ba0f5bbe18f697c8ba24b4da8","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 17:45:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/081262dc970848b885c6b82e160146fc\n\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/61319fa2d03442d4aaf66d084374f86e : SUCCESS in 25m 57s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/adbf1f24f44f4836a766194ae2371296 : SUCCESS in 15m 03s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/5711cc9f9f3d462a9c82055c456adb2a : SUCCESS in 33m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4765e0240b999ecc25a611d3bd3d62ed0ed3c324","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-18 17:52:48.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Workflow-1\n","accounts_in_message":[],"_revision_number":2},{"id":"76369445a3f77585f31468fc14faa4c96b600ebc","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 18:30:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8b15c43a911e499692dd465da6c3aa65\n\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/9d3c85d3af844173a77263ca570d8f68 : SUCCESS in 19m 32s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/015cf77af7f0491d9a925af91a688738 : SUCCESS in 24m 23s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/b155e472994541e1aa77d61e0583aa0c : SUCCESS in 17m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1463ed7841bd9f9bc830614fa3572ce21bec0558","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2025-12-18 18:46:17.000000000","message":"Patch Set 2:\n\nBuild Successful \n\n* quobyteci:  nova_quobyteci : SUCCESS, logs at: https://oscilogs.quobyte.com/logs/Id98d8029af673ffa89d6472be98f90a6f0975511 .","accounts_in_message":[],"_revision_number":2},{"id":"ab63e57fe23bd8538d5a63aa1d85fef1673cdd22","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-18 20:08:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/541e432846144653b531df25d2ed0b82\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/33b7f0dbe47a4e2b8166bd59962aff78 : SUCCESS in 1h 02m 52s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/833b211004be4b3caff2f002c006979d : SUCCESS in 2h 10m 10s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c2317c74b2d0441289060d345e78e3c9 : SUCCESS in 1h 04m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2d2539c63d074057800417b8e933dc3f : SUCCESS in 19m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/704d35c77fcc461cba9a77ff44858eaf : SUCCESS in 6m 59s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/06bc369f4df8458a8662b76fd97904a6 : SUCCESS in 10m 08s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4dd8d569b4c248b28bd6f778e7c66868 : SUCCESS in 10m 10s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/cbb4aa225b2e469ab2f6d1bd56430bce : SUCCESS in 10m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/53909a0f480d450385b87d690ecf975d : SUCCESS in 12m 02s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/5dbfadf9ed71453683d26fa1039a59ea : SUCCESS in 39m 11s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/b8de280d39774859913b371d8b446dca : SUCCESS in 1h 33m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3392952996ee4cdbba9fcc3482be15f4 : SUCCESS in 43m 21s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/2f52b0a434f14517815a95838b37a844 : SUCCESS in 51m 28s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/345073a9f7854e8498f8bacffe38f715 : SUCCESS in 52m 17s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/cb8c292affd7482291c2c84d3efd301b : SUCCESS in 2h 03m 24s\n- nova-next https://zuul.opendev.org/t/openstack/build/4f761cb0272544069675b52bbf1c7056 : SUCCESS in 1h 25m 40s\n- nova-alt-configurations https://zuul.opendev.org/t/openstack/build/6f9dbd20e17541c49f624f07105383f5 : SUCCESS in 50m 50s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/7a59ae655bfb4d2c9372b4fdbf6fa6d5 : SUCCESS in 5m 25s (non-voting)\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/0e5061f090794c75b066fdfbbd96e7ae : SUCCESS in 27m 37s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/bdce5b22f3d145bab7fc7662af8882b9 : SUCCESS in 32m 44s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/24d5729a81d34ce29e0a848916ada73c : SUCCESS in 1h 14m 37s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/eec5ae42b09d4c00a378b3fe3d529814 : SUCCESS in 1h 00m 58s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5c8b2afb975e4cbd9ab661df189f10e4 : SUCCESS in 27m 33s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/b93600c8d61741a98ce5345661d3fdad : SUCCESS in 34m 38s (non-voting)\n- nova-tox-py312-threading https://zuul.opendev.org/t/openstack/build/8617cd4510454b22bd1fd26e1022a682 : SUCCESS in 13m 54s","accounts_in_message":[],"_revision_number":2},{"id":"705efad0b7075580669dbce3618afa245501d0d5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-12-18 20:15:14.000000000","message":"Patch Set 2:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":2},{"id":"69b3b40963c9c8c09d852cef91f89dec94fcea18","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-12-19 08:56:48.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"8626edd1aa4cec13cfb6b583c56cfdb77604592b","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2026-01-02 20:00:47.000000000","message":"Patch Set 2:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-971452-rdkbg/index.html\u003e","accounts_in_message":[],"_revision_number":2},{"id":"1e1b63c42a2e0d079f93c4c12013eefb44c5923b","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2026-01-09 14:04:23.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"50e555d720febe8782fef0bfc3e8d1273e69fdb0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-09 14:05:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"164e193d60be37a22a3c28e20b4b8fc19d20a73c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-09 16:38:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/13e40677f6b44a789e1fc01242f19ae0\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/0694d02491d34514a26aca5685293a9a : SUCCESS in 1h 00m 23s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c6961cf942c348c99e20bb970fea8d9d : SUCCESS in 1h 51m 13s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ba3f941691f14b73b05f120d3fca11b7 : SUCCESS in 1h 03m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/64d4c077a50b40cdb663beb5c18c8b0f : SUCCESS in 7m 55s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/91bb4df9ed8a43a786e4c5ab189dc9e3 : SUCCESS in 9m 48s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/5d64f6c34ed641ddbad85f42d5c66777 : SUCCESS in 11m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/12a46a1049cf43ab85c6e553dc4594ca : SUCCESS in 14m 28s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/b56408facfc548d992115b09c171cd3f : SUCCESS in 33m 26s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/82c9f9ad123e4f1692fc6501cd11cc6e : SUCCESS in 24m 23s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/283392ed2fcb44bbb0f00339236fe83c : SUCCESS in 30m 04s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/d1c53704e2ba4ec2a798ec418f49ddca : SUCCESS in 2h 03m 30s\n- nova-next https://zuul.opendev.org/t/openstack/build/fc0f150369544795bfaedd78034199c6 : SUCCESS in 2h 21m 09s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/3acae4a6ec5748c7a45bfb3249b2fb09 : SUCCESS in 5m 33s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/cdf7e17415ef45f382dfc236552f9ef4 : SUCCESS in 2h 03m 01s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ed9a61f3b0894463b8c94c7ad6a02b40 : SUCCESS in 1h 36m 09s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0d5ea16b0e704d11af90d69305d31fc1 : SUCCESS in 54m 21s\n- nova-tox-py312-threading https://zuul.opendev.org/t/openstack/build/a88ee91553ce428b9dafddba3e0e265b : SUCCESS in 15m 48s\n- nova-alt-configurations https://zuul.opendev.org/t/openstack/build/f6734b22d0f646c7a2887dc6c4f97a14 : SUCCESS in 31m 27s","accounts_in_message":[],"_revision_number":2},{"id":"4b0adaf37b0ec2de8ff3da2f2ff65c313068fb7e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-09 16:38:31.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"b15dad8d4625b3080e4084ff120e6d6e24f88e7a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-09 16:40:46.000000000","message":"Patch Set 2:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/9885c7b7601d490d817a08586c7cde91\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a6ba35c4b7f54e7b89a903ce335c2cb2 : FAILURE in 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aec74c1f23c1ca00ec72ffddb716932dbb0ac839","revisions":{"298f2b78f98ae87a9288172477eb4a2203af6354":{"kind":"REWORK","_number":1,"created":"2025-12-18 16:42:51.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/52/971452/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/52/971452/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/971452/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/971452/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/971452/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/52/971452/1"}}},"commit":{"parents":[{"commit":"d832edda90b86e3cf62c38f5804f3caad4b20233","subject":"tests: Set disk alias in libvirt fixture","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d832edda90b86e3cf62c38f5804f3caad4b20233"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-18 15:57:03.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-18 16:36:48.000000000","tz":0},"subject":"tests: Always set device aliases","message":"tests: Always set device aliases\n\nWe have a number of tests that check behavior of attach/detach of\ndevices with libvirt with and without an alias. However, libvirt will\nalways set an alias on pretty much all devices [1]. All that changes is\nwhether the alias is a *user-defined* alias and an auto-generated one.\n\nRework some tests to reflect this, allowing us to place a runtime check\nfor this property before our event listener (which depends on this\nattribute being set).\n\n[1] https://github.com/libvirt/libvirt/blob/v11.10.0/src/qemu/qemu_alias.c#L692-L786\n\nChange-Id: Id98d8029af673ffa89d6472be98f90a6f0975511\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/298f2b78f98ae87a9288172477eb4a2203af6354"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/298f2b78f98ae87a9288172477eb4a2203af6354"}]},"branch":"refs/heads/master"},"aec74c1f23c1ca00ec72ffddb716932dbb0ac839":{"kind":"REWORK","_number":2,"created":"2025-12-18 17:52:48.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/52/971452/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/52/971452/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/971452/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/971452/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/971452/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/52/971452/2"}}},"commit":{"parents":[{"commit":"c7d37ee3ce27b00085dceaba04e561ad59b89a3c","subject":"trivial: Use functools.wraps","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c7d37ee3ce27b00085dceaba04e561ad59b89a3c"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-18 14:56:01.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-18 17:49:45.000000000","tz":0},"subject":"libvirt: Ensure device alias is present","message":"libvirt: Ensure device alias is present\n\nOur event listener depends on devices having an alias set. We add an\nearly assertion to prove this is the case. In real-life, this will\nalways be the case since the devices we can detach - like interfaces and\ndisks - are among the lists of devices that libvirt will automatically\ngenerate an alias for if the user (nova-compute, in this case) doesn\u0027t\nprovide their own [1]. However, many of our tests were not doing this so\nwe must update our LibvirtFixture in particular to start doing so.\n\n[1] https://github.com/libvirt/libvirt/blob/v11.10.0/src/qemu/qemu_alias.c#L692-L786\n\nChange-Id: Id98d8029af673ffa89d6472be98f90a6f0975511\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aec74c1f23c1ca00ec72ffddb716932dbb0ac839"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aec74c1f23c1ca00ec72ffddb716932dbb0ac839"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}