)]}'
{"nova/tests/api/ec2/test_cloud.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b20f5279837d83935b1ecb5c468e31200a8f639e","unresolved":false,"context_lines":[{"line_number":2218,"context_line":"        self.assertTrue(\u0027blockDeviceMapping\u0027 in created_image)"},{"line_number":2219,"context_line":"        bdm \u003d created_image[\u0027blockDeviceMapping\u0027][0]"},{"line_number":2220,"context_line":"        self.assertEquals(bdm.get(\u0027deviceName\u0027), \u0027vda\u0027)"},{"line_number":2221,"context_line":"        self.assertTrue(\u0027ebs\u0027 in bdm)"},{"line_number":2222,"context_line":"        self.assertEquals(bdm[\u0027ebs\u0027].get(\u0027snapshotId\u0027),"},{"line_number":2223,"context_line":"                          \u0027snap-%08x\u0027 % snapshots[0])"},{"line_number":2224,"context_line":"        self.assertEquals(created_image.get(\u0027kernelId\u0027), \u0027aki-00000001\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F8d0%3D","line":2221,"updated":"2012-07-12 21:27:44.000000000","message":"Maybe I\u0027m just thick, but I can\u0027t see how this patch makes the above assert possible?","commit_id":"429903d5c788277f0bceaf24c0e263ea9d56cbef"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"05d9ea6f13bc694b40532ec198c6c4ad5044c722","unresolved":false,"context_lines":[{"line_number":2218,"context_line":"        self.assertTrue(\u0027blockDeviceMapping\u0027 in created_image)"},{"line_number":2219,"context_line":"        bdm \u003d created_image[\u0027blockDeviceMapping\u0027][0]"},{"line_number":2220,"context_line":"        self.assertEquals(bdm.get(\u0027deviceName\u0027), \u0027vda\u0027)"},{"line_number":2221,"context_line":"        self.assertTrue(\u0027ebs\u0027 in bdm)"},{"line_number":2222,"context_line":"        self.assertEquals(bdm[\u0027ebs\u0027].get(\u0027snapshotId\u0027),"},{"line_number":2223,"context_line":"                          \u0027snap-%08x\u0027 % snapshots[0])"},{"line_number":2224,"context_line":"        self.assertEquals(created_image.get(\u0027kernelId\u0027), \u0027aki-00000001\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F8GY%3D","line":2221,"in_reply_to":"AAAAKX%2F%2F8NY%3D","updated":"2012-07-13 15:27:36.000000000","message":"Got it. thanks!","commit_id":"429903d5c788277f0bceaf24c0e263ea9d56cbef"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"829484bd1ddf7917439c0c7ca379f2d4abfe6edf","unresolved":false,"context_lines":[{"line_number":2218,"context_line":"        self.assertTrue(\u0027blockDeviceMapping\u0027 in created_image)"},{"line_number":2219,"context_line":"        bdm \u003d created_image[\u0027blockDeviceMapping\u0027][0]"},{"line_number":2220,"context_line":"        self.assertEquals(bdm.get(\u0027deviceName\u0027), \u0027vda\u0027)"},{"line_number":2221,"context_line":"        self.assertTrue(\u0027ebs\u0027 in bdm)"},{"line_number":2222,"context_line":"        self.assertEquals(bdm[\u0027ebs\u0027].get(\u0027snapshotId\u0027),"},{"line_number":2223,"context_line":"                          \u0027snap-%08x\u0027 % snapshots[0])"},{"line_number":2224,"context_line":"        self.assertEquals(created_image.get(\u0027kernelId\u0027), \u0027aki-00000001\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F8NY%3D","line":2221,"in_reply_to":"AAAAKX%2F%2F8d0%3D","updated":"2012-07-13 10:35:13.000000000","message":"Well that would be pre-existing code that sets \u0027ebs\u0027 in the block device mapping, specifically:\n\n  https://github.com/openstack/nova/blob/master/nova/api/ec2/cloud.py#L151\n\nSo not every assertion that I added to this testcase would previously have been false - the reason being that the test was very incomplete, in fact the call to the CreateImage API was commented out.\n\nSo really the test was previously doing almost nothing, with the result that it couldn\u0027t assert very much at all.","commit_id":"429903d5c788277f0bceaf24c0e263ea9d56cbef"}]}