)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5c97090e5fd7323e089350826801f4f3620f8268","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix Concurrent VM Live Migrate - Volume Backup Error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If vm live migration is initiated while an attached volume is in the backup state, the migration fails and a rollback is triggered. Rollback attempts to detach the volume using an incorrect Multipath ID. With this patch, live migration is not started if the states of the volumes attached to the vm are not in-use."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: #2133501"},{"line_number":12,"context_line":"Change-Id: I280e7eb8c1da6eeaf50e96e8b19e296961f2651a"},{"line_number":13,"context_line":"Signed-off-by: Esra Ozkan \u003cozkan.esra@tubitak.gov.tr\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"cd9fcb44_ff3ebc21","line":10,"updated":"2026-04-15 22:25:03.000000000","message":"I think this commit message title is overstating things a bit, since this patch doesn\u0027t actually \"fix\" the volume disconnection problem. It eliminates a large window of bug opportunity though.\n\nSo I would say something more like, \"Check volume status before live migration\" for the title line. The rest looks OK.\n\nAlso, please wrap the commit message lines at 71 chars 🙏","commit_id":"ccd4d6131efe432374f3ad246ddb679b75e7f7c4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6ec1049eb5779676e1dc1f611113403dd21c7db7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Concurrent VM Live Migrate - Volume Backup Error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If vm live migration is initiated while an attached volume is in the backup state, the migration fails and a rollback is triggered. Rollback attempts to detach the volume using an incorrect Multipath ID. With this patch, live migration is not started if the states of the volumes attached to the vm are not in-use."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-Bug: #2133501"},{"line_number":12,"context_line":"Change-Id: I280e7eb8c1da6eeaf50e96e8b19e296961f2651a"},{"line_number":13,"context_line":"Signed-off-by: Esra Ozkan \u003cozkan.esra@tubitak.gov.tr\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"88e7ce7c_0c3a1b02","line":10,"in_reply_to":"cd9fcb44_ff3ebc21","updated":"2026-04-28 22:24:12.000000000","message":"Done","commit_id":"ccd4d6131efe432374f3ad246ddb679b75e7f7c4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a08c104ce40ce79f3432b30a62322ce8303b0b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8845ecd7_4a60af40","updated":"2026-01-27 08:10:33.000000000","message":"I think this is a valid direction to cheaply de-risk live migration. \n@melwittt@gmail.com You worked on similar issues in the past so you are probably interested about this approach.","commit_id":"1e9f07c941bf1f185454045909a87f0d49f9edea"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5c97090e5fd7323e089350826801f4f3620f8268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7fef7dd1_b60992b0","in_reply_to":"8845ecd7_4a60af40","updated":"2026-04-15 22:25:03.000000000","message":"Sorry, I had completely missed this tag from a long time ago 🙁\n\nI agree that this is an inexpensive sanity check we could do to avoid most problems. It is obviously susceptible to races but is something reasonable to do regardless.","commit_id":"1e9f07c941bf1f185454045909a87f0d49f9edea"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5c97090e5fd7323e089350826801f4f3620f8268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a1128c2c_96d4c36f","updated":"2026-04-15 22:25:03.000000000","message":"Soft -1 due to the commit message.","commit_id":"ccd4d6131efe432374f3ad246ddb679b75e7f7c4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6ec1049eb5779676e1dc1f611113403dd21c7db7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba12d4f1_8012be3f","updated":"2026-04-28 22:24:12.000000000","message":"My comment was addressed and AFAICT gibi\u0027s comments were addressed. This LGTM and I let gibi ack it when he gets a chance.","commit_id":"e88c83bd895624e54b904fa3c50bfda4f6cf18c2"},{"author":{"_account_id":20865,"name":"Gökhan","email":"gokhan.isik@tubitak.gov.tr","username":"gokhan.isik"},"change_message_id":"6681bd16821587785d388fa90e097187da490b92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b18babcf_e8838a4d","updated":"2026-04-22 14:41:16.000000000","message":"recheck intermittent failure","commit_id":"e88c83bd895624e54b904fa3c50bfda4f6cf18c2"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a08c104ce40ce79f3432b30a62322ce8303b0b5f","unresolved":true,"context_lines":[{"line_number":2782,"context_line":"            mock_get_bdms.return_value \u003d bdms"},{"line_number":2783,"context_line":"            mock_get_volume.return_value \u003d mock.sentinel.volume"},{"line_number":2784,"context_line":""},{"line_number":2785,"context_line":"            self._live_migrate_instance(instance)"},{"line_number":2786,"context_line":""},{"line_number":2787,"context_line":"    @mock.patch(\u0027nova.objects.block_device.BlockDeviceMappingList\u0027"},{"line_number":2788,"context_line":"                \u0027.get_by_instance_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a14a9e61_97d69c0e","line":2785,"updated":"2026-01-27 08:10:33.000000000","message":"This seems to be a test case helper. As the bdm mocking is needed in each case this helper is used, I suggest to move the bdm mocking and asserting there.","commit_id":"1e9f07c941bf1f185454045909a87f0d49f9edea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a08c104ce40ce79f3432b30a62322ce8303b0b5f","unresolved":true,"context_lines":[{"line_number":2856,"context_line":"                    self.context, instance.uuid)"},{"line_number":2857,"context_line":"                mock_get_volume.assert_called_once_with("},{"line_number":2858,"context_line":"                    self.context, uuids.volume_id)"},{"line_number":2859,"context_line":""},{"line_number":2860,"context_line":"    @mock.patch.object(objects.RequestSpec, \u0027get_by_instance_uuid\u0027)"},{"line_number":2861,"context_line":"    @mock.patch.object(objects.InstanceAction, \u0027action_start\u0027)"},{"line_number":2862,"context_line":"    @mock.patch.object(objects.ComputeNodeList, \u0027get_all_by_host\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1e00fca_9b31f788","line":2859,"updated":"2026-01-27 08:10:33.000000000","message":"I think you missed adding test coverage for the new case where the early volume check rejects the live migration.","commit_id":"1e9f07c941bf1f185454045909a87f0d49f9edea"}]}