)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"703e016d3fb180e43f0b63adffa9a4b1c4e1f609","unresolved":true,"context_lines":[{"line_number":10,"context_line":"server will used for the new requests and 2nd for completing the in-progress"},{"line_number":11,"context_line":"tasks. The 2nd RPC server will use the same transport bus and same endpoint("},{"line_number":12,"context_line":"compute manager instance) but listen to the different topic then 1st RPC"},{"line_number":13,"context_line":"server. By having two different topic, other service (API, conductor, or compute)"},{"line_number":14,"context_line":"can make difference on which topic they want to send the RPC request to the"},{"line_number":15,"context_line":"compute service. That will be done via RPC client sending the request to specific"},{"line_number":16,"context_line":"topic."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7c70d42d_6c40721f","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":37},"updated":"2026-01-30 10:11:56.000000000","message":"nit:topics","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"495f3bb5666dce0ceda2f7c142994e50abfb36df","unresolved":false,"context_lines":[{"line_number":10,"context_line":"server will used for the new requests and 2nd for completing the in-progress"},{"line_number":11,"context_line":"tasks. The 2nd RPC server will use the same transport bus and same endpoint("},{"line_number":12,"context_line":"compute manager instance) but listen to the different topic then 1st RPC"},{"line_number":13,"context_line":"server. By having two different topic, other service (API, conductor, or compute)"},{"line_number":14,"context_line":"can make difference on which topic they want to send the RPC request to the"},{"line_number":15,"context_line":"compute service. That will be done via RPC client sending the request to specific"},{"line_number":16,"context_line":"topic."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fdf32371_db0645db","line":13,"range":{"start_line":13,"start_character":32,"end_line":13,"end_character":37},"in_reply_to":"7c70d42d_6c40721f","updated":"2026-01-30 19:23:59.000000000","message":"Done","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"703e016d3fb180e43f0b63adffa9a4b1c4e1f609","unresolved":true,"context_lines":[{"line_number":15,"context_line":"compute service. That will be done via RPC client sending the request to specific"},{"line_number":16,"context_line":"topic."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change stop the both RPC servers but later in this series we will keep"},{"line_number":19,"context_line":"the 2nd RPC server active so that compute service can listen to the in-progress"},{"line_number":20,"context_line":"tasks required communication coming from other services."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b3867830_dad8798f","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":37},"updated":"2026-01-30 10:11:56.000000000","message":"nit: stop both RPC servers","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"495f3bb5666dce0ceda2f7c142994e50abfb36df","unresolved":false,"context_lines":[{"line_number":15,"context_line":"compute service. That will be done via RPC client sending the request to specific"},{"line_number":16,"context_line":"topic."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change stop the both RPC servers but later in this series we will keep"},{"line_number":19,"context_line":"the 2nd RPC server active so that compute service can listen to the in-progress"},{"line_number":20,"context_line":"tasks required communication coming from other services."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8569528f_ebf23928","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":37},"in_reply_to":"b3867830_dad8798f","updated":"2026-01-30 19:23:59.000000000","message":"Done","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"703e016d3fb180e43f0b63adffa9a4b1c4e1f609","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This change stop the both RPC servers but later in this series we will keep"},{"line_number":19,"context_line":"the 2nd RPC server active so that compute service can listen to the in-progress"},{"line_number":20,"context_line":"tasks required communication coming from other services."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The next change in this series will use this 2nd RPC server. The tasks (compute"},{"line_number":23,"context_line":"RPC client methods) who needs to be using this 2nd RPC server will be modified in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"812b6740_af3a2c38","line":20,"updated":"2026-01-30 10:11:56.000000000","message":"++","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"703e016d3fb180e43f0b63adffa9a4b1c4e1f609","unresolved":true,"context_lines":[{"line_number":24,"context_line":"the next change."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partial implement blueprint nova-services-graceful-shutdown-part1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I26656869f00efe6d89d993000dcf2e91683a217e"},{"line_number":29,"context_line":"Signed-off-by: Ghanshyam Maan \u003cgmaan@ghanshyammann.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9bb71ce4_92ded55a","line":27,"updated":"2026-01-30 10:11:56.000000000","message":"nit: long lines","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"495f3bb5666dce0ceda2f7c142994e50abfb36df","unresolved":false,"context_lines":[{"line_number":24,"context_line":"the next change."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partial implement blueprint nova-services-graceful-shutdown-part1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I26656869f00efe6d89d993000dcf2e91683a217e"},{"line_number":29,"context_line":"Signed-off-by: Ghanshyam Maan \u003cgmaan@ghanshyammann.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6b62a990_3bd2f9fb","line":27,"in_reply_to":"9bb71ce4_92ded55a","updated":"2026-01-30 19:23:59.000000000","message":"Done","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"703e016d3fb180e43f0b63adffa9a4b1c4e1f609","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ac7c7ef_0ea05948","updated":"2026-01-30 10:11:56.000000000","message":"Looks good","commit_id":"781f781788d6612c06e33943b9b89c1a4ec74292"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"62277a8ae30b095e5682748257e1c8a4498d5474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c87281a0_3c73f9db","updated":"2026-02-05 15:50:27.000000000","message":"Actually I think my concern is more a -1","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c72c86a3b3015726f9c9cc1eb001bf4c95672102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b51b98f0_eb119a06","updated":"2026-02-05 15:49:59.000000000","message":"just a concern with the fact that we just create a new RPC topic now without any operator documentation.\nIf we need to have it now, then I\u0027d prefer to have a releasenote explaining why we have a new RPC topic","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4add4d4e5ee389052fbd42203b0f1da3d2d230d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6cbd811e_00f4febc","updated":"2026-02-04 02:01:06.000000000","message":"nova-next failure are know and this job is blocked","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1e5fb96ad81f996ab0e0676c08ac3fcf44ebc302","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cec287ec_7b13bd26","updated":"2026-02-12 16:15:16.000000000","message":"okay, then let\u0027s accept it","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1ab9f7bfa23efdb87e3d6f8fa0422537d39fa6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec426cbd_66327b2c","updated":"2026-02-02 16:30:45.000000000","message":"recheck kernal crash in many tests","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9600bc446195f41e5bbf442857e7e88c20bbedb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5490673b_a425e0e5","updated":"2026-02-02 02:47:02.000000000","message":"recheck nova-alt-configurations is fixed","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d870d5b975720bf9da3c44e45cc1dc47e50c594c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"60385263_979662a1","updated":"2026-02-05 01:12:55.000000000","message":"recheck nova-next job fix is merged now","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9a9dc1d033f6a54edb43b87eddecf26faf8e58fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a2256025_b47cd464","updated":"2026-02-03 16:01:17.000000000","message":"recheck timepout in tempest compute job","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bdc8a87853fa5d2f1bb8c26db32de48da09f3c6a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e6296727_9c7d40e2","in_reply_to":"b51b98f0_eb119a06","updated":"2026-02-05 16:20:31.000000000","message":"I am planning to add it in when we will actually use it in compute service until then it is not impacting upgrade or any user operations.\n\n- https://review.opendev.org/c/openstack/nova/+/975588/1","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e4390029e5900577512b2ee21c62818b8e51c730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c68fcad_c8bd04db","in_reply_to":"cec287ec_7b13bd26","updated":"2026-02-23 04:32:36.000000000","message":"added the releasenotes - https://review.opendev.org/c/openstack/nova/+/975588/22/releasenotes/notes/nova-services-graceful-shutdown-564a321e2769152d.yaml\n\nand operator doc - https://review.opendev.org/c/openstack/nova/+/977590","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"}],"nova/cmd/compute.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c72c86a3b3015726f9c9cc1eb001bf4c95672102","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    server \u003d service.Service.create("},{"line_number":63,"context_line":"        binary\u003d\u0027nova-compute\u0027,"},{"line_number":64,"context_line":"        topic\u003dcompute_rpcapi.RPC_TOPIC,"},{"line_number":65,"context_line":"        topic_alt\u003dcompute_rpcapi.RPC_TOPIC_ALT)"},{"line_number":66,"context_line":"    # Compute service should never fork worker processes"},{"line_number":67,"context_line":"    service.serve(server, workers\u003d1, no_fork\u003dTrue)"},{"line_number":68,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":4,"id":"05a0be9e_4322c382","line":65,"updated":"2026-02-05 15:49:59.000000000","message":"should we set it once we are done with the series ? If no, we would have a RPC topic without documentation for our operators.","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bdc8a87853fa5d2f1bb8c26db32de48da09f3c6a","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    server \u003d service.Service.create("},{"line_number":63,"context_line":"        binary\u003d\u0027nova-compute\u0027,"},{"line_number":64,"context_line":"        topic\u003dcompute_rpcapi.RPC_TOPIC,"},{"line_number":65,"context_line":"        topic_alt\u003dcompute_rpcapi.RPC_TOPIC_ALT)"},{"line_number":66,"context_line":"    # Compute service should never fork worker processes"},{"line_number":67,"context_line":"    service.serve(server, workers\u003d1, no_fork\u003dTrue)"},{"line_number":68,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":4,"id":"d7ca005f_a7b9b60e","line":65,"in_reply_to":"05a0be9e_4322c382","updated":"2026-02-05 16:20:31.000000000","message":"I am planning to add the documentation (including releasenotes etc) when we will use this new RPC server/topic in compute RPC. That need RPC versioning also. This is WIP change where we will use it and I will add the complete documentation and releasenotes there https://review.opendev.org/c/openstack/nova/+/975588/1\n\nI did not add it here because, it was not used in compute operation at this time.","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"}],"nova/service.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c72c86a3b3015726f9c9cc1eb001bf4c95672102","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def __init__(self, host, binary, topic, manager, report_interval\u003dNone,"},{"line_number":99,"context_line":"                 periodic_enable\u003dNone, periodic_fuzzy_delay\u003dNone,"},{"line_number":100,"context_line":"                 periodic_interval_max\u003dNone, topic_alt\u003dNone,"},{"line_number":101,"context_line":"                 *args, **kwargs):"},{"line_number":102,"context_line":"        super(Service, self).__init__()"},{"line_number":103,"context_line":"        self.host \u003d host"}],"source_content_type":"text/x-python","patch_set":4,"id":"2e820fa7_c89ef4de","line":100,"range":{"start_line":100,"start_character":44,"end_line":100,"end_character":60},"updated":"2026-02-05 15:49:59.000000000","message":"cool, given the None, it won\u0027t be an upgrade issue","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96014581a53a1bfc9a6dbc419832eb7dd61dac46","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        # dispatcher, consumers, rabbitmq queue, amqp listener, kombu"},{"line_number":110,"context_line":"        # connection etc). The endpoint (manager) stay same so that same"},{"line_number":111,"context_line":"        # manager will be serving the both rpc servers."},{"line_number":112,"context_line":"        self.topic_alt \u003d topic_alt"},{"line_number":113,"context_line":"        self.manager_class_name \u003d manager"},{"line_number":114,"context_line":"        self.servicegroup_api \u003d servicegroup.API()"},{"line_number":115,"context_line":"        manager_class \u003d importutils.import_class(self.manager_class_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"54fa5150_ccd41275","line":112,"updated":"2026-02-02 18:19:05.000000000","message":"Do we want to bump the compute service version or RPC minor version in this change? In general I think we will need to know when the compute.api can start sending messages to \"compute-alt\" on a given compute as we can have deployments where some computes are upgraded but some hasn\u0027t been.\n\nI\u0027m OK if we introduce that version in a later patch before we start using the \"compute-alt\" topic.","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4d5e2291bc9a57b1d06df2a4f94b085f0279c3f5","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # dispatcher, consumers, rabbitmq queue, amqp listener, kombu"},{"line_number":110,"context_line":"        # connection etc). The endpoint (manager) stay same so that same"},{"line_number":111,"context_line":"        # manager will be serving the both rpc servers."},{"line_number":112,"context_line":"        self.topic_alt \u003d topic_alt"},{"line_number":113,"context_line":"        self.manager_class_name \u003d manager"},{"line_number":114,"context_line":"        self.servicegroup_api \u003d servicegroup.API()"},{"line_number":115,"context_line":"        manager_class \u003d importutils.import_class(self.manager_class_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1dcdccdd_641c8f73","line":112,"in_reply_to":"0bf93cd9_516c6a46","updated":"2026-02-03 15:02:38.000000000","message":"OK that works for me.","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"26d8e2dda5d79ccddbff37e6ab256110e099299f","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        # dispatcher, consumers, rabbitmq queue, amqp listener, kombu"},{"line_number":110,"context_line":"        # connection etc). The endpoint (manager) stay same so that same"},{"line_number":111,"context_line":"        # manager will be serving the both rpc servers."},{"line_number":112,"context_line":"        self.topic_alt \u003d topic_alt"},{"line_number":113,"context_line":"        self.manager_class_name \u003d manager"},{"line_number":114,"context_line":"        self.servicegroup_api \u003d servicegroup.API()"},{"line_number":115,"context_line":"        manager_class \u003d importutils.import_class(self.manager_class_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0bf93cd9_516c6a46","line":112,"in_reply_to":"54fa5150_ccd41275","updated":"2026-02-02 18:21:11.000000000","message":"yeah, I was thinking to bump version when RPC client start using the \"compute-alt\" topic because that is where we need to take care of old vs new compute and fallback things.","commit_id":"82fd8ffdced6e976083c5066c5a88a5d7cec474d"}]}