)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8f1e8ea5db2c61cab008c4283336367ebc80a145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4e22bd2f_f4260472","updated":"2026-02-03 20:36:01.000000000","message":"-1 for the regression test not detecting regression. The other two tests are good.","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2c1cd7bb69b8d5e412e7e0e429ec8d7a3709ecd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab59d79b_b4b1ac33","updated":"2026-02-04 02:18:24.000000000","message":"This is working as expected now with the regression func test properly detecting regression, LGTM","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1d7384fcf27a61b3e8028ab376b9fb38431b31b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c27b369_df033b29","updated":"2026-02-04 14:57:11.000000000","message":"recheck ceph failed to deploy \n\nModule \u0027orchestrator\u0027 is not enabled/loaded (required by command \u0027orch set backend\u0027): use `ceph mgr module enable orchestrator` to enable it\n\nwe need to look into that seperately","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bfa493740b9bc3e0aa9d125ac51fa2f4ba5cda5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c2f2bdd7_3fb262cc","updated":"2026-02-04 17:51:10.000000000","message":"recheck mirror download failure","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6f8e77dfb5ac041f7114da5ee121912ed97f39fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57019f2a_7cedb32c","updated":"2026-02-04 10:25:24.000000000","message":"we could have splitted the change in twice by adding a regression test before, but lgtm.","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a4470b6bf0c98a075a553efe419b157d3dcccc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"48989306_74a29cb3","in_reply_to":"57019f2a_7cedb32c","updated":"2026-02-04 10:30:09.000000000","message":"ya since the gate was blocked i consider doing that hand havign the first patch skip the test and the second renableing it but decied to just have one since tempest is verifying the fix.","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"}],"nova/tests/fixtures/libvirt.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6f8e77dfb5ac041f7114da5ee121912ed97f39fa","unresolved":false,"context_lines":[{"line_number":926,"context_line":"        disk_info[\u0027blockio_logical_block_size\u0027] \u003d blockio.get("},{"line_number":927,"context_line":"            \u0027logical_block_size\u0027)"},{"line_number":928,"context_line":"        disk_info[\u0027blockio_physical_block_size\u0027] \u003d blockio.get("},{"line_number":929,"context_line":"            \u0027physical_block_size\u0027)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    return disk_info"},{"line_number":932,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c386351b_2d599202","line":929,"updated":"2026-02-04 10:25:24.000000000","message":"thanks for amending the fixture","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"}],"nova/tests/functional/regressions/test_bug_2127196.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8f1e8ea5db2c61cab008c4283336367ebc80a145","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                \u0027physical_block_size\u0027: \u0027512\u0027,"},{"line_number":53,"context_line":"            }"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class TestLunVolumeBlockio("},{"line_number":58,"context_line":"    base.ServersTestBase,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd01fedb_fba04c7b","line":55,"updated":"2026-02-03 20:36:01.000000000","message":"Note to self: I was thinking the all caps class attributes looked odd but found that it is already existing style in the CinderFixture.","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c45c636d6117c7c668732c98d7c63196dcda89b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                \u0027physical_block_size\u0027: \u0027512\u0027,"},{"line_number":53,"context_line":"            }"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class TestLunVolumeBlockio("},{"line_number":58,"context_line":"    base.ServersTestBase,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ba46971_ff2986d0","line":55,"in_reply_to":"fd01fedb_fba04c7b","updated":"2026-02-04 10:10:24.000000000","message":"Acknowledged","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8f1e8ea5db2c61cab008c4283336367ebc80a145","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    def setUp(self):"},{"line_number":71,"context_line":"        super().setUp()"},{"line_number":72,"context_line":"        self.cinder \u003d self.useFixture("},{"line_number":73,"context_line":"            CinderFixtureWithLunBlockSize(self))"},{"line_number":74,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":75,"context_line":"            \u0027nova.compute.manager.ComputeVirtAPI.wait_for_instance_event\u0027))"},{"line_number":76,"context_line":"        self.start_compute("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7f9a2a_2c867a70","line":73,"updated":"2026-02-03 20:36:01.000000000","message":"Note: this doesn\u0027t look like it needs to be a wrapped line.","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f314a873e88d788293c89c008450811abe0c2eec","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def setUp(self):"},{"line_number":71,"context_line":"        super().setUp()"},{"line_number":72,"context_line":"        self.cinder \u003d self.useFixture("},{"line_number":73,"context_line":"            CinderFixtureWithLunBlockSize(self))"},{"line_number":74,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":75,"context_line":"            \u0027nova.compute.manager.ComputeVirtAPI.wait_for_instance_event\u0027))"},{"line_number":76,"context_line":"        self.start_compute("}],"source_content_type":"text/x-python","patch_set":1,"id":"46c57255_47a91693","line":73,"in_reply_to":"1a7f9a2a_2c867a70","updated":"2026-02-03 22:15:45.000000000","message":"Done","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8f1e8ea5db2c61cab008c4283336367ebc80a145","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            \u0027device_type\u0027: \u0027lun\u0027,"},{"line_number":102,"context_line":"            \u0027disk_bus\u0027: \u0027scsi\u0027,"},{"line_number":103,"context_line":"        }]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        created_server \u003d self.api.post_server({\u0027server\u0027: server})"},{"line_number":106,"context_line":"        self._wait_for_state_change(created_server, \u0027ACTIVE\u0027)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"17f4f0ee_5dcd2c1f","line":104,"updated":"2026-02-03 20:36:01.000000000","message":"Locally I found that this test does not catch regression i.e. it passes even without the fix. Somehow `\u003cblockio\u003e` is never in the XML either way.","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fcf7f8c3708ab9b15acce45ad24743802d394c2f","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            \u0027device_type\u0027: \u0027lun\u0027,"},{"line_number":102,"context_line":"            \u0027disk_bus\u0027: \u0027scsi\u0027,"},{"line_number":103,"context_line":"        }]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        created_server \u003d self.api.post_server({\u0027server\u0027: server})"},{"line_number":106,"context_line":"        self._wait_for_state_change(created_server, \u0027ACTIVE\u0027)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2fef7103_0ebdc8fd","line":104,"in_reply_to":"17f4f0ee_5dcd2c1f","updated":"2026-02-03 22:10:05.000000000","message":"hum it looks like the libvirt fixture was droping the block io element\ni need to run the full test suite again but this might reslove it.","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c45c636d6117c7c668732c98d7c63196dcda89b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \u0027device_type\u0027: \u0027lun\u0027,"},{"line_number":102,"context_line":"            \u0027disk_bus\u0027: \u0027scsi\u0027,"},{"line_number":103,"context_line":"        }]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        created_server \u003d self.api.post_server({\u0027server\u0027: server})"},{"line_number":106,"context_line":"        self._wait_for_state_change(created_server, \u0027ACTIVE\u0027)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8e6f1d28_16731053","line":104,"in_reply_to":"2fef7103_0ebdc8fd","updated":"2026-02-04 10:10:24.000000000","message":"Done","commit_id":"2dd8ece67d0d3b38108a23a3e62e54a5356a6b85"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6f8e77dfb5ac041f7114da5ee121912ed97f39fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af5c80bf_9bcf06a5","line":126,"updated":"2026-02-04 10:25:24.000000000","message":"++","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6f8e77dfb5ac041f7114da5ee121912ed97f39fa","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        # NOTE(bug 2127196): Block size properties are not supported for"},{"line_number":1363,"context_line":"        # device\u003d\u0027lun\u0027 because QEMU\u0027s scsi-block driver does not support"},{"line_number":1364,"context_line":"        # physical_block_size and logical_block_size properties."},{"line_number":1365,"context_line":"        if (self.source_device !\u003d \u0027lun\u0027 and"},{"line_number":1366,"context_line":"                (self.logical_block_size is not None or"},{"line_number":1367,"context_line":"                 self.physical_block_size is not None)):"},{"line_number":1368,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b0cf66f7_5d45b18a","line":1365,"updated":"2026-02-04 10:25:24.000000000","message":"we already do those kinds of checks against a raw string for \u0027lun\u0027 (instead of having it a global variable or a field name) so I\u0027m cool with that this way.","commit_id":"c8d34ed3dc1ffc174ee56d3ca55e922afd75f619"}]}
