)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88e0a78572d6781492b9572e1f6e1e642d8a4eb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"afc397bb_89926b7b","updated":"2026-02-11 10:47:21.000000000","message":"Nice reproducer. Thanks","commit_id":"76d796193c6fe4ab9714ae14dabfd9682b54892b"}],"nova/tests/fixtures/libvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b29f9a8682fea56bbb4c15e07b046b9c6edab906","unresolved":true,"context_lines":[{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        iothreads \u003d tree.find(\u0027./iothreads\u0027)"},{"line_number":1232,"context_line":"        if iothreads is not None:"},{"line_number":1233,"context_line":"            definition[\u0027iothreads\u0027] \u003d iothreads.text"},{"line_number":1234,"context_line":""},{"line_number":1235,"context_line":"        iothread_pin \u003d tree.find(\u0027./cputune/iothreadpin\u0027)"},{"line_number":1236,"context_line":"        if iothread_pin is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4b123ed8_dc5062b7","line":1233,"updated":"2026-02-11 11:04:10.000000000","message":"ah we were droping them in the fixture...","commit_id":"76d796193c6fe4ab9714ae14dabfd9682b54892b"}],"nova/tests/functional/regressions/test_bug_2140537.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b002e4d14c5e5b702603cc33f48082fc8eba2b9e","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        server \u003d self._create_server("},{"line_number":85,"context_line":"            flavor_id\u003dflavor, host\u003d\u0027host1\u0027, networks\u003d\u0027none\u0027,"},{"line_number":86,"context_line":"            expected_state\u003d\u0027ERROR\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Verify the server is in ERROR state due to the libvirt XML error"},{"line_number":89,"context_line":"        self.assertEqual(\u0027ERROR\u0027, server[\u0027status\u0027])"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c0b8acd4_42463807","line":87,"updated":"2026-02-05 18:29:44.000000000","message":"I have to revisit tomorrow with clean mind if what I written here is really what it should work.","commit_id":"7fa9a836ddd9ed6709d9bfa55e2eaeb3b2638f60"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b9fea51dd41ba0062c2f355101e18ccb6200887","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class TestIOThreadPinningPinnedCPU("},{"line_number":33,"context_line":"    base.LibvirtMigrationMixin,"},{"line_number":34,"context_line":"    base.ServersTestBase,"},{"line_number":35,"context_line":"    integrated_helpers.InstanceHelperMixin"},{"line_number":36,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":3,"id":"012efdc3_ada283ab","line":33,"range":{"start_line":33,"start_character":9,"end_line":33,"end_character":30},"updated":"2026-02-11 09:55:31.000000000","message":"this baseclass is not necessary perhaps, I have to doublecheck","commit_id":"76d796193c6fe4ab9714ae14dabfd9682b54892b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b29f9a8682fea56bbb4c15e07b046b9c6edab906","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        # TODO(lajoskatona): remove this patch when the fix for"},{"line_number":50,"context_line":"        # bug/2140537 is merged, and the libvirt fixture has the"},{"line_number":51,"context_line":"        # necessary validation for XML fields for IOThreads."},{"line_number":52,"context_line":"        patcher \u003d mock.patch.object("},{"line_number":53,"context_line":"            fakelibvirt.Connection, \u0027defineXML\u0027,"},{"line_number":54,"context_line":"            fakelibvirt.Connection._defineXMLIOThreads)"},{"line_number":55,"context_line":"        patcher.start()"},{"line_number":56,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        super().setUp()"},{"line_number":59,"context_line":"        self.hostname \u003d self.start_compute("}],"source_content_type":"text/x-python","patch_set":3,"id":"621fa8a9_9a5085d3","line":56,"range":{"start_line":52,"start_character":2,"end_line":56,"end_character":37},"updated":"2026-02-11 11:04:10.000000000","message":"nit: you should use self.useFixture(fixtures.MockPatchObject(...))\ninstead","commit_id":"76d796193c6fe4ab9714ae14dabfd9682b54892b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b29f9a8682fea56bbb4c15e07b046b9c6edab906","unresolved":true,"context_lines":[{"line_number":296,"context_line":"        self.assertIsNotNone(srv_iothread)"},{"line_number":297,"context_line":"        self.assertEqual(\u00271\u0027, srv_iothread.text)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # And no pinning for shared CPUs, no iothreadpin"},{"line_number":300,"context_line":"        self.assertIsNone(srv_iothreadpin)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c654477_1ec722b0","line":299,"updated":"2026-02-11 11:04:10.000000000","message":"note that this is only ture when cpu_shared_set and vcpu_pin_set are not defiend","commit_id":"76d796193c6fe4ab9714ae14dabfd9682b54892b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffcf64c0bc95287627f3edea0d2ed9f8b6b14a2b","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        self.assertIsNotNone(srv_iothread)"},{"line_number":297,"context_line":"        self.assertEqual(\u00271\u0027, srv_iothread.text)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        # And no pinning for shared CPUs, no iothreadpin"},{"line_number":300,"context_line":"        self.assertIsNone(srv_iothreadpin)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d26c5962_34c338a7","line":299,"in_reply_to":"3c654477_1ec722b0","updated":"2026-02-11 11:56:49.000000000","message":"this is a little imprecice\n\nwhat i ment to say if if you use a default flavor witn no extra spces then\n\nthe iothread only float if cpu_shared_set and vcpu_pin_set are not defiend\n\nif they are defied the vm has cpuset defiend in the vcpu element and libvirt will implictly pin the iothread to the same cores without requireing use toe generate the iothreadpin element.\n\nso the assert is correct just noting that your relying on the implict default values fo the config for there to be \"no pinning\" of the shared cpus and io thread in general.","commit_id":"76d796193c6fe4ab9714ae14dabfd9682b54892b"}]}
