)]}'
{"id":"openstack%2Fnova~975961","triplet_id":"openstack%2Fnova~master~I36b9e9c11478d2d120c2b6e18b1f9e0fdae8e69a","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"I36b9e9c11478d2d120c2b6e18b1f9e0fdae8e69a","subject":"Fix unified limits to include all resource types","status":"ABANDONED","created":"2026-02-06 20:11:54.000000000","updated":"2026-02-06 21:27:50.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76811e7c6253fb5007e70b06b6d230a28a16f214","_number":975961,"virtual_id_number":975961,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-06 21:27:50.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"a77cb0abf5aa5c8e1b55f5535380df2be086707c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2026-02-06 20:11:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"98f068cc19ecbbd298a95fff9469170f560ba4c7","tag":"autogenerated:gerrit:abandon","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2026-02-06 20:14:29.000000000","message":"Abandoned\n\nhttps://review.opendev.org/c/openstack/nova/+/975872/4","accounts_in_message":[],"_revision_number":1},{"id":"76811e7c6253fb5007e70b06b6d230a28a16f214","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2026-02-06 21:27:50.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* quobyteci:  nova_quobyteci : FAILURE, logs at: https://oscilogs.quobyte.com/logs/I36b9e9c11478d2d120c2b6e18b1f9e0fdae8e69a .","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d06b02e8c35addaa4432e49667ee9ec4f9ad89cf","revisions":{"d06b02e8c35addaa4432e49667ee9ec4f9ad89cf":{"kind":"REWORK","_number":1,"created":"2026-02-06 20:11:54.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/61/975961/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/975961/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/975961/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/975961/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/975961/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/975961/1"}}},"commit":{"parents":[{"commit":"cbdc38f418998174fe1c273285ad82a3a7829667","subject":"Add regression test for unified limits resource bug","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cbdc38f418998174fe1c273285ad82a3a7829667"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2026-02-06 18:39:47.000000000","tz":0},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2026-02-06 20:00:40.000000000","tz":0},"subject":"Fix unified limits to include all resource types","message":"Fix unified limits to include all resource types\n\nThe unified limits quota check only considered flavor-based resources\n(VCPU, MEMORY_MB, DISK_GB). PCI device resource classes, neutron port\nbandwidth resources, and cyborg device profile resources were all\nmissing because resources_for_limits() built a minimal RequestSpec\nfrom just the flavor.\n\nRefactor enforce_num_instances_and_flavor() to accept a RequestSpec\ninstead of flavor + is_bfv. The caller now builds a RequestSpec that\nincludes PCI requests, port bandwidth resource requests, and cyborg\ndevice profile request groups. The enforcement code uses\nResourceRequest.from_request_spec() to extract all resources, which\nnaturally includes every resource type on the RequestSpec.\n\nThis removes the need for the resources_for_limits() helper and the\nPCI-specific code that was added to _get_resources() in\nscheduler/utils.py.\n\nGenerated-By: claude-code\nCloses-Bug: #2140631\nChange-Id: I36b9e9c11478d2d120c2b6e18b1f9e0fdae8e69a\nSigned-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d06b02e8c35addaa4432e49667ee9ec4f9ad89cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d06b02e8c35addaa4432e49667ee9ec4f9ad89cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
