)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"3dd2fee5398f73d63d0c9f7f1b52bd3f60811fc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e868bd99_5da4b03c","updated":"2026-03-04 12:21:16.000000000","message":"Asking for a review","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d4333da27dc4b9857873b6ae477289240a29758b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a03db5d_c644e117","updated":"2026-03-05 11:31:28.000000000","message":"can you add a release note\n\ni dont think this is just slowing down vtpm i suspect this is impacting things more broadly","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"b752bc432cef564d8c5884727d774437b937a405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"899cbdb3_ecd121ee","updated":"2026-02-18 15:08:39.000000000","message":"recheck","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"d4b827cb625ce2d10b2c4ae97792296fe5f5ae8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a034501f_d8d76e15","updated":"2026-02-25 19:44:01.000000000","message":"recheck","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"d14a43d394b712d0dba473e42db8a4e5c7d30393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63bc05ae_23dcf6b4","in_reply_to":"a034501f_d8d76e15","updated":"2026-02-25 19:45:25.000000000","message":"Seems like nova-next is expected failure today.","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"af61e774430dcb90116055d705134633739933ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45fc29f9_ea442bc4","updated":"2026-03-06 09:16:24.000000000","message":"I guess it\u0027s done","commit_id":"aadc92b497833b4a796860c46fc035652d1361f3"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"319ac0bfe2466fc642f062b72c16bb7985aef64f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"085474a4_ba3bcf46","updated":"2026-03-06 14:23:38.000000000","message":"recheck","commit_id":"0d654bc0c96cf51669c06dd8e86a681fdf1fd247"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"31e3b5a884eb92f6a939408796cef75217d27d2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db38ed2b_e434c175","updated":"2026-06-13 14:54:20.000000000","message":"It\u0027s been 3 months since patch is ready... cmon","commit_id":"2714c71d05e8501ddb3a8fc0c36f3406ef974072"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833c0979e06ecc1e51379c14df721dd856570ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19ec2dae_753b5c05","updated":"2026-03-13 21:59:47.000000000","message":"i dont have time to review this thisi evening but i think this looks promisitng\ni suspect but have not validated that this will help with startup time for all driver including ironic. ill see if i can loop back to it late next week once im back form pto","commit_id":"2714c71d05e8501ddb3a8fc0c36f3406ef974072"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"137cb2e0e4b0c1ee2d75d9c17c992ee31c04aeb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b15cde0f_dae5b84a","updated":"2026-05-28 15:02:06.000000000","message":"recheck logs have rotated","commit_id":"2714c71d05e8501ddb3a8fc0c36f3406ef974072"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"f2c1d83fcc892ce51f4b64ae38eb8ec8d0ba8553","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1b8f35db_02a0c64d","in_reply_to":"19ec2dae_753b5c05","updated":"2026-04-01 14:50:54.000000000","message":"Hi\nAny chance to get it merged into master and cherry-pick to older releases?","commit_id":"2714c71d05e8501ddb3a8fc0c36f3406ef974072"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d4333da27dc4b9857873b6ae477289240a29758b","unresolved":true,"context_lines":[{"line_number":1075,"context_line":"        if self.driver.capabilities.get(\u0027supports_vtpm\u0027, False):"},{"line_number":1076,"context_line":"            return"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        LOG.debug(\u0027Validating vTPM configuration for %d instances. \u0027"},{"line_number":1079,"context_line":"                  \u0027Note: if flavor/system_metadata are not pre-loaded, \u0027"},{"line_number":1080,"context_line":"                  \u0027this will trigger lazy-loading for each instance.\u0027,"},{"line_number":1081,"context_line":"                  len(instances))"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        for i, instance in enumerate(instances):"},{"line_number":1084,"context_line":"            if instance.deleted:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7f3e0b3_c2bc749d","line":1081,"range":{"start_line":1078,"start_character":1,"end_line":1081,"end_character":33},"updated":"2026-03-05 11:31:28.000000000","message":"i dont think this is needed","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"af61e774430dcb90116055d705134633739933ed","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"        if self.driver.capabilities.get(\u0027supports_vtpm\u0027, False):"},{"line_number":1076,"context_line":"            return"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        LOG.debug(\u0027Validating vTPM configuration for %d instances. \u0027"},{"line_number":1079,"context_line":"                  \u0027Note: if flavor/system_metadata are not pre-loaded, \u0027"},{"line_number":1080,"context_line":"                  \u0027this will trigger lazy-loading for each instance.\u0027,"},{"line_number":1081,"context_line":"                  len(instances))"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        for i, instance in enumerate(instances):"},{"line_number":1084,"context_line":"            if instance.deleted:"}],"source_content_type":"text/x-python","patch_set":1,"id":"93007d82_0c4dd1df","line":1081,"range":{"start_line":1078,"start_character":1,"end_line":1081,"end_character":33},"in_reply_to":"f7f3e0b3_c2bc749d","updated":"2026-03-06 09:16:24.000000000","message":"Acknowledged","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d4333da27dc4b9857873b6ae477289240a29758b","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"        for i, instance in enumerate(instances):"},{"line_number":1084,"context_line":"            if instance.deleted:"},{"line_number":1085,"context_line":"                continue"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"            LOG.debug(\u0027Checking vTPM constraint for instance %d/%d: %s\u0027,"},{"line_number":1088,"context_line":"                      i + 1, len(instances), instance.uuid)"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"            # NOTE(stephenfin): We don\u0027t have an attribute on the instance to"},{"line_number":1091,"context_line":"            # check for this, so we need to inspect the flavor/image metadata"}],"source_content_type":"text/x-python","patch_set":1,"id":"54697045_5c588be8","line":1088,"range":{"start_line":1086,"start_character":1,"end_line":1088,"end_character":59},"updated":"2026-03-05 11:31:28.000000000","message":"i guess you want to show the forward progress by pringing the total and the renmaining but calling len on the list repetadily woudl be better fo factor out of the loop","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"af61e774430dcb90116055d705134633739933ed","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        for i, instance in enumerate(instances):"},{"line_number":1084,"context_line":"            if instance.deleted:"},{"line_number":1085,"context_line":"                continue"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"            LOG.debug(\u0027Checking vTPM constraint for instance %d/%d: %s\u0027,"},{"line_number":1088,"context_line":"                      i + 1, len(instances), instance.uuid)"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"            # NOTE(stephenfin): We don\u0027t have an attribute on the instance to"},{"line_number":1091,"context_line":"            # check for this, so we need to inspect the flavor/image metadata"}],"source_content_type":"text/x-python","patch_set":1,"id":"aea49643_0ad5e664","line":1088,"range":{"start_line":1086,"start_character":1,"end_line":1088,"end_character":59},"in_reply_to":"54697045_5c588be8","updated":"2026-03-06 09:16:24.000000000","message":"Acknowledged","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d4333da27dc4b9857873b6ae477289240a29758b","unresolved":true,"context_lines":[{"line_number":1714,"context_line":"        # ours."},{"line_number":1715,"context_line":"        self._check_for_host_rename(nodes_by_uuid)"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"        LOG.debug(\u0027Loading instances for host %s with expected_attrs: \u0027"},{"line_number":1718,"context_line":"                  \u0027info_cache, metadata, system_metadata, numa_topology, \u0027"},{"line_number":1719,"context_line":"                  \u0027flavor\u0027, self.host)"},{"line_number":1720,"context_line":"        instances \u003d objects.InstanceList.get_by_host("},{"line_number":1721,"context_line":"            context, self.host,"},{"line_number":1722,"context_line":"            expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027, \u0027system_metadata\u0027,"},{"line_number":1723,"context_line":"                            \u0027numa_topology\u0027, \u0027flavor\u0027])"},{"line_number":1724,"context_line":"        LOG.debug(\u0027Loaded %d instances for host %s\u0027, len(instances), self.host)"},{"line_number":1725,"context_line":""},{"line_number":1726,"context_line":"        self.init_virt_events()"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c4e5dba_4ab07c47","line":1723,"range":{"start_line":1717,"start_character":0,"end_line":1723,"end_character":55},"updated":"2026-03-05 11:31:28.000000000","message":"if we are going to print that debug message let deduplicate this\n\n\n\n```suggestion\n        extra_attribs \u003d [\n            \u0027info_cache\u0027, \u0027metadata\u0027, \u0027system_metadata\u0027,\n            \u0027numa_topology\u0027, \u0027flavor\u0027]\n        LOG.debug(f\u0027Loading instances for host {self.host} with expected_attrs: \u0027\n                  + \u0027 \u0027.join(extra_attribs))\n        instances \u003d objects.InstanceList.get_by_host(\n            context, self.host,\n            expected_attrs\u003dextra_attribs)\n```\n\nthat way the two calls cant get out of sync\n\nim not sure the first debug log is actully that useful however","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"af61e774430dcb90116055d705134633739933ed","unresolved":false,"context_lines":[{"line_number":1714,"context_line":"        # ours."},{"line_number":1715,"context_line":"        self._check_for_host_rename(nodes_by_uuid)"},{"line_number":1716,"context_line":""},{"line_number":1717,"context_line":"        LOG.debug(\u0027Loading instances for host %s with expected_attrs: \u0027"},{"line_number":1718,"context_line":"                  \u0027info_cache, metadata, system_metadata, numa_topology, \u0027"},{"line_number":1719,"context_line":"                  \u0027flavor\u0027, self.host)"},{"line_number":1720,"context_line":"        instances \u003d objects.InstanceList.get_by_host("},{"line_number":1721,"context_line":"            context, self.host,"},{"line_number":1722,"context_line":"            expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027, \u0027system_metadata\u0027,"},{"line_number":1723,"context_line":"                            \u0027numa_topology\u0027, \u0027flavor\u0027])"},{"line_number":1724,"context_line":"        LOG.debug(\u0027Loaded %d instances for host %s\u0027, len(instances), self.host)"},{"line_number":1725,"context_line":""},{"line_number":1726,"context_line":"        self.init_virt_events()"}],"source_content_type":"text/x-python","patch_set":1,"id":"880211e2_09856650","line":1723,"range":{"start_line":1717,"start_character":0,"end_line":1723,"end_character":55},"in_reply_to":"2c4e5dba_4ab07c47","updated":"2026-03-06 09:16:24.000000000","message":"Acknowledged","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d4333da27dc4b9857873b6ae477289240a29758b","unresolved":true,"context_lines":[{"line_number":1721,"context_line":"            context, self.host,"},{"line_number":1722,"context_line":"            expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027, \u0027system_metadata\u0027,"},{"line_number":1723,"context_line":"                            \u0027numa_topology\u0027, \u0027flavor\u0027])"},{"line_number":1724,"context_line":"        LOG.debug(\u0027Loaded %d instances for host %s\u0027, len(instances), self.host)"},{"line_number":1725,"context_line":""},{"line_number":1726,"context_line":"        self.init_virt_events()"},{"line_number":1727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"371714d1_d2debbbf","line":1724,"range":{"start_line":1724,"start_character":69,"end_line":1724,"end_character":77},"updated":"2026-03-05 11:31:28.000000000","message":"we do not really need to include the host here again.","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"af61e774430dcb90116055d705134633739933ed","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"            context, self.host,"},{"line_number":1722,"context_line":"            expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027, \u0027system_metadata\u0027,"},{"line_number":1723,"context_line":"                            \u0027numa_topology\u0027, \u0027flavor\u0027])"},{"line_number":1724,"context_line":"        LOG.debug(\u0027Loaded %d instances for host %s\u0027, len(instances), self.host)"},{"line_number":1725,"context_line":""},{"line_number":1726,"context_line":"        self.init_virt_events()"},{"line_number":1727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"627715c8_97c13f57","line":1724,"range":{"start_line":1724,"start_character":69,"end_line":1724,"end_character":77},"in_reply_to":"371714d1_d2debbbf","updated":"2026-03-06 09:16:24.000000000","message":"Acknowledged","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"7edf6dbcdbb5ef7b5d7b18541122cd94ce1abcfa","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"            context, self.host,"},{"line_number":1722,"context_line":"            expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027, \u0027system_metadata\u0027,"},{"line_number":1723,"context_line":"                            \u0027numa_topology\u0027, \u0027flavor\u0027])"},{"line_number":1724,"context_line":"        LOG.debug(\u0027Loaded %d instances for host %s\u0027, len(instances), self.host)"},{"line_number":1725,"context_line":""},{"line_number":1726,"context_line":"        self.init_virt_events()"},{"line_number":1727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"13536984_202d2a6b","line":1724,"range":{"start_line":1724,"start_character":69,"end_line":1724,"end_character":77},"in_reply_to":"627715c8_97c13f57","updated":"2026-03-06 09:55:29.000000000","message":"Asking for review","commit_id":"7df62a21ec44b3152e083776b19724bd1850d7a1"}]}