)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":true,"context_lines":[{"line_number":17,"context_line":"resize/cold migration and what all will be using 2nd RPC server:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Resize/cold migration"},{"line_number":20,"context_line":"- prep_resize: Yes"},{"line_number":21,"context_line":"- resize_instance: Yes"},{"line_number":22,"context_line":"- finish_resize: Yes"},{"line_number":23,"context_line":"- cross cell resize case:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0a297d10_4d3a95bb","line":20,"updated":"2026-02-19 12:11:11.000000000","message":"Without looking at the code, I\u0027m wondering if we need some RPC method kept on the normal RPC topic in a normal resize to avoid a compute in graceful shutdown mode to accept a new resize operation received after the shutdown was initiated. Would it be possible to reject prep_resize as that is the first RPC from the conductor during a resize op?","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"964e437f17c19362e3521a490c6d12451dd75389","unresolved":false,"context_lines":[{"line_number":17,"context_line":"resize/cold migration and what all will be using 2nd RPC server:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Resize/cold migration"},{"line_number":20,"context_line":"- prep_resize: Yes"},{"line_number":21,"context_line":"- resize_instance: Yes"},{"line_number":22,"context_line":"- finish_resize: Yes"},{"line_number":23,"context_line":"- cross cell resize case:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"18e55912_f9fde46d","line":20,"in_reply_to":"0a297d10_4d3a95bb","updated":"2026-02-19 23:18:01.000000000","message":"yeah, this prep_resize is the initial checks and preparation but resize not started yet. It is called by conductor on destination host and destination host call resize_instance on source host to actually start the migration (resize_instance start migrating the disk to dest). One special case here is, if failure happen during prep_resize on dest then it will ask conductor to reschedule the resize on other host. But that is still a new request and actual migration is not yet started on source.\n\nWe need to keep prep_resize on normal RPC server otherwise new resize/migration request will keep coming during shutdown.\n\nI kept prep resize on normal RPC for cross cell resize case but missed in normal resize. thanks for cathing it.","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    migration is not started"},{"line_number":26,"context_line":"  - prep_snapshot_based_resize_at_source: Yes, this start the migration"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Confirm resize: NO"},{"line_number":29,"context_line":"- confirm_resize: NO"},{"line_number":30,"context_line":"- cross cell confirm resize case:"},{"line_number":31,"context_line":"  - confirm_snapshot_based_resize - NO"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a5644141_8dc6043f","line":28,"updated":"2026-02-19 12:11:11.000000000","message":"I agree, confirm can wait","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":false,"context_lines":[{"line_number":34,"context_line":"- revert_resize - NO"},{"line_number":35,"context_line":"- finish_revert_resize on source- YES, at this stage, revert resize is"},{"line_number":36,"context_line":"  in progress and abandoning it here can lead migration to unreocverable"},{"line_number":37,"context_line":"  state."},{"line_number":38,"context_line":"- cross cell revert case:"},{"line_number":39,"context_line":"  - revert_snapshot_based_resize_at_dest: NO"},{"line_number":40,"context_line":"  - finish_revert_snapshot_based_resize_at_source: YES"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e6ffb26f_1f3c1f3b","line":37,"updated":"2026-02-19 12:11:11.000000000","message":"++","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0fb81fe64048f6da1318f02369d6555e559dc91b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Revert resize:"},{"line_number":34,"context_line":"- revert_resize - NO"},{"line_number":35,"context_line":"- check_instance_shared_storage: YES. This is called from dest to source"},{"line_number":36,"context_line":"  so we need source to respond to it so that revert can be continue."},{"line_number":37,"context_line":"- finish_revert_resize on source- YES, at this stage, revert resize is"},{"line_number":38,"context_line":"  in progress and abandoning it here can lead migration to unreocverable"},{"line_number":39,"context_line":"  state."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"dfe62b3d_f423926b","line":36,"updated":"2026-02-23 17:38:58.000000000","message":"nit: can continue\n++ adding this to the new rpc topic for revert","commit_id":"bbe4f0bd7a67a8a3697d98495e7c167f66927372"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3713078587cceb7565db7639c5ab8f4550a4589d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Revert resize:"},{"line_number":34,"context_line":"- revert_resize - NO"},{"line_number":35,"context_line":"- check_instance_shared_storage: YES. This is called from dest to source"},{"line_number":36,"context_line":"  so we need source to respond to it so that revert can be continue."},{"line_number":37,"context_line":"- finish_revert_resize on source- YES, at this stage, revert resize is"},{"line_number":38,"context_line":"  in progress and abandoning it here can lead migration to unreocverable"},{"line_number":39,"context_line":"  state."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"df77eb7a_3613cbc8","line":36,"in_reply_to":"dfe62b3d_f423926b","updated":"2026-02-23 20:52:42.000000000","message":"done","commit_id":"bbe4f0bd7a67a8a3697d98495e7c167f66927372"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e72c8d70918c4a11a68b688d4d9bf42979653a1d","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    migration is not started"},{"line_number":26,"context_line":"  - prep_snapshot_based_resize_at_source: Yes, this start the migration"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Confirm resize: NO"},{"line_number":29,"context_line":"- confirm_resize: NO"},{"line_number":30,"context_line":"- cross cell confirm resize case:"},{"line_number":31,"context_line":"  - confirm_snapshot_based_resize - NO"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Revert resize:"},{"line_number":34,"context_line":"- revert_resize - NO"},{"line_number":35,"context_line":"- check_instance_shared_storage: YES. This is called from dest to source"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"e7c90f38_8498c28d","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":1},"updated":"2026-02-25 15:14:04.000000000","message":"so by default resize_confirm_window is 0\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.resize_confirm_window\n\nso we do not auto confirm but i know may public/private clouds set this to 1 to avoid server staying in resize_verify for a long period of time\n\ni woudl actully condier addign a -1 to mean alwasy confirm imetrially.\n\nthe reason ibring this up is to aks have you considerd how that impact gracefuly shutdown if its set to  non 0 value.\n\ni woudl personly set this to 1 adn did in my personal clouds in the past\n\ni didnt override it in our product to avoid the behvior change but its imporant that we reason about this properly.\n\nwe should be ok as long as that background action does nto put the servier in error.\n\nit would be nice to have a test for that.","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e578515fc70ae170da966ece772bc6d8f41f6d93","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    migration is not started"},{"line_number":26,"context_line":"  - prep_snapshot_based_resize_at_source: Yes, this start the migration"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Confirm resize: NO"},{"line_number":29,"context_line":"- confirm_resize: NO"},{"line_number":30,"context_line":"- cross cell confirm resize case:"},{"line_number":31,"context_line":"  - confirm_snapshot_based_resize - NO"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Revert resize:"},{"line_number":34,"context_line":"- revert_resize - NO"},{"line_number":35,"context_line":"- check_instance_shared_storage: YES. This is called from dest to source"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f51de92_825e21b3","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"839bd604_8a41c754","updated":"2026-02-25 20:54:06.000000000","message":"Acknowledged","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5da4b2f835f8a6f1ff13c5abf48fb431a3165d9","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    migration is not started"},{"line_number":26,"context_line":"  - prep_snapshot_based_resize_at_source: Yes, this start the migration"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Confirm resize: NO"},{"line_number":29,"context_line":"- confirm_resize: NO"},{"line_number":30,"context_line":"- cross cell confirm resize case:"},{"line_number":31,"context_line":"  - confirm_snapshot_based_resize - NO"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Revert resize:"},{"line_number":34,"context_line":"- revert_resize - NO"},{"line_number":35,"context_line":"- check_instance_shared_storage: YES. This is called from dest to source"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"839bd604_8a41c754","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"e7c90f38_8498c28d","updated":"2026-02-25 20:36:03.000000000","message":"ack. if it is auto confirm then it will still be stayting in RPC queue and if comoute serviec comes up then it will be proceeded and if not then user will see it is failing and confirm manually.","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6d648a8c9e4e42cd6ec74a7f786310b744c43c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cccc3263_095fd18e","updated":"2026-02-20 18:16:49.000000000","message":"recheck ssh timeout","commit_id":"bfc559e28fa6c07ae0ca60b4918a8716263cc30c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4e23fa78a309a9c553080ed480f9b859d1e546ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3c1f9421_169c38b3","updated":"2026-02-24 15:36:26.000000000","message":"Looks good","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e72c8d70918c4a11a68b688d4d9bf42979653a1d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"48a0d5ff_cb7fb2dc","updated":"2026-02-25 15:14:04.000000000","message":"i think we shoudl have more  unit/functionalt test for this feature.\nim not sure if that should be adressed before merging but i was hoping that you would have functional tests for the move operation for durign graceful shutdown.","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90964aa1935fc17d50e92babdf8de873ceb32931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"99489482_a6638023","updated":"2026-02-24 17:56:28.000000000","message":"recheck ServerActionsTestJSON timeout","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a582a80248f4efa25f79befb4396927c0c3cc517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e18f033b_7aee886e","updated":"2026-02-24 08:35:14.000000000","message":"recheck nova-next post failure","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e76c4b1f07b7347adc5a3f1678b68a23440d223c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ef662f08_0d6c90c4","updated":"2026-02-24 22:32:23.000000000","message":"recheck test_resize_volume_backed_server_confirm ssh timeout","commit_id":"3e4e9e1656d7d3a3e50912d48f6bce6740aa39ca"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":true,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def test_rollback_live_migration_at_destination(self):"},{"line_number":519,"context_line":"        self._test_compute_api("},{"line_number":520,"context_line":"    \u0027rollback_live_migration_at_destination\u0027,"},{"line_number":521,"context_line":"    \u0027cast\u0027,"},{"line_number":522,"context_line":"    instance\u003dself.fake_instance_obj,"},{"line_number":523,"context_line":"    host\u003d\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"66934b57_8ade5358","line":520,"updated":"2026-02-19 12:11:11.000000000","message":"I guess autopep8 formatted it this way but I don\u0027t like it","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"964e437f17c19362e3521a490c6d12451dd75389","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def test_rollback_live_migration_at_destination(self):"},{"line_number":519,"context_line":"        self._test_compute_api("},{"line_number":520,"context_line":"    \u0027rollback_live_migration_at_destination\u0027,"},{"line_number":521,"context_line":"    \u0027cast\u0027,"},{"line_number":522,"context_line":"    instance\u003dself.fake_instance_obj,"},{"line_number":523,"context_line":"    host\u003d\u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"258b04c5_7e748512","line":520,"in_reply_to":"66934b57_8ade5358","updated":"2026-02-19 23:18:01.000000000","message":"yeah, I fixed it in previous PS but it came again from autopep8. done","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"}],"roles/run-graceful-shutdown-tests/files/start_operations.sh":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        # If task_state is already None/empty, migration completed quickly"},{"line_number":41,"context_line":"        if [ \"${server_task_state}\" \u003d\u003d \"None\" ] || [ -z \"${server_task_state}\" ]; then"},{"line_number":42,"context_line":"            echo \"Live migration appears to have already completed\""},{"line_number":43,"context_line":"            live_migration_started\u003dTrue"},{"line_number":44,"context_line":"        fi"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"    if [ \"${cold_migration_started}\" !\u003d \"True\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c67042b5_b5ff5b6f","line":43,"updated":"2026-02-19 12:11:11.000000000","message":"I think this is cheating as if the migration finished before we shutdown then we are not testing what we want to test here.","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"964e437f17c19362e3521a490c6d12451dd75389","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # If task_state is already None/empty, migration completed quickly"},{"line_number":41,"context_line":"        if [ \"${server_task_state}\" \u003d\u003d \"None\" ] || [ -z \"${server_task_state}\" ]; then"},{"line_number":42,"context_line":"            echo \"Live migration appears to have already completed\""},{"line_number":43,"context_line":"            live_migration_started\u003dTrue"},{"line_number":44,"context_line":"        fi"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"    if [ \"${cold_migration_started}\" !\u003d \"True\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1b352fa2_1c774be8","line":43,"in_reply_to":"c67042b5_b5ff5b6f","updated":"2026-02-19 23:18:01.000000000","message":"yeah, good point. In this case, let me skip the further verification at least. Failing job would not be a good idea.","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        server1_status\u003d$(openstack server show server-cm -f value -c status)"},{"line_number":53,"context_line":"        if [ \"${server1_status}\" \u003d\u003d \"VERIFY_RESIZE\" ]; then"},{"line_number":54,"context_line":"            echo \"Cold migration appears to have already completed\""},{"line_number":55,"context_line":"            cold_migration_started\u003dTrue"},{"line_number":56,"context_line":"        fi"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    if [ \"${live_migration_started}\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"${cold_migration_started}\" \u003d\u003d \"True\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5e326728_52a4d36d","line":55,"updated":"2026-02-19 12:11:11.000000000","message":"ditto","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"964e437f17c19362e3521a490c6d12451dd75389","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        server1_status\u003d$(openstack server show server-cm -f value -c status)"},{"line_number":53,"context_line":"        if [ \"${server1_status}\" \u003d\u003d \"VERIFY_RESIZE\" ]; then"},{"line_number":54,"context_line":"            echo \"Cold migration appears to have already completed\""},{"line_number":55,"context_line":"            cold_migration_started\u003dTrue"},{"line_number":56,"context_line":"        fi"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    if [ \"${live_migration_started}\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"${cold_migration_started}\" \u003d\u003d \"True\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"451af540_647fe51a","line":55,"in_reply_to":"5e326728_52a4d36d","updated":"2026-02-19 23:18:01.000000000","message":"Done","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f185e842b825479374f329e3b1976ca31ab10f38","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            cold_migration_started\u003dTrue"},{"line_number":56,"context_line":"        fi"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    if [ \"${live_migration_started}\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"${cold_migration_started}\" \u003d\u003d \"True\" ]; then"},{"line_number":59,"context_line":"        break"},{"line_number":60,"context_line":"    fi"},{"line_number":61,"context_line":"    sleep 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"45468e81_23d254fc","line":58,"updated":"2026-02-19 12:11:11.000000000","message":"I\u0027m wondering if this will scale well as we add more operations to test. At some point if we have many parallel operations some will finish before all reaches the in-progress state. I guess we either need to slow down our ops by using bigger / busier VMs or we need to split this test loop into separate test cases each doing its own gracefull shutdown","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"964e437f17c19362e3521a490c6d12451dd75389","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            cold_migration_started\u003dTrue"},{"line_number":56,"context_line":"        fi"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    if [ \"${live_migration_started}\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"${cold_migration_started}\" \u003d\u003d \"True\" ]; then"},{"line_number":59,"context_line":"        break"},{"line_number":60,"context_line":"    fi"},{"line_number":61,"context_line":"    sleep 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5c373325_8979caaa","line":58,"in_reply_to":"45468e81_23d254fc","updated":"2026-02-19 23:18:01.000000000","message":"True, for now, multiple migration operations in parallel are working fine in a single shutdown, but I agree that we need to do it case by case and at least for small running operations to be separate out in separate shutdowns. let\u0027s see how it grows and I will refactor that time. \n\nFor example, I am thinking of a new test with source compute shutdown and see how these migration will progress but that will be done in separate shutdown.","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7c5f72a1b3f9ccad38e59883c00a51a3da601844","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            cold_migration_started\u003dTrue"},{"line_number":56,"context_line":"        fi"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":"    if [ \"${live_migration_started}\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"${cold_migration_started}\" \u003d\u003d \"True\" ]; then"},{"line_number":59,"context_line":"        break"},{"line_number":60,"context_line":"    fi"},{"line_number":61,"context_line":"    sleep 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df9359cd_26a9cc37","line":58,"in_reply_to":"5c373325_8979caaa","updated":"2026-02-23 04:25:59.000000000","message":"I faced the failure for that so separated the live and cold migrations per shutdown. This way is more stable now. done","commit_id":"3d205161c62ee6ba17548fb262284a036255e892"}],"roles/run-graceful-shutdown-tests/tasks/main.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0fb81fe64048f6da1318f02369d6555e559dc91b","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        cold_migrations_completed_before_sigterm: \"{{ start_cold_migrations_result.rc \u003d\u003d 2 }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - name: Send SIGTERM to source compute to start the source compute graceful shutdown"},{"line_number":63,"context_line":"      when: not cold_migrations_completed_before_sigterm"},{"line_number":64,"context_line":"      delegate_to: compute1"},{"line_number":65,"context_line":"      become: true"},{"line_number":66,"context_line":"      shell: \"kill -15 $(systemctl show devstack@n-cpu -p MainPID --value)\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"446c9845_55a444bd","line":63,"updated":"2026-02-23 17:38:58.000000000","message":"ditto: I would rather fail the test if the migration was too fast otherwise this will silently pass without testing the intention here.","commit_id":"bbe4f0bd7a67a8a3697d98495e7c167f66927372"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94ec85211217030d92c868e001841994fd88d365","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        cold_migrations_completed_before_sigterm: \"{{ start_cold_migrations_result.rc \u003d\u003d 2 }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - name: Send SIGTERM to source compute to start the source compute graceful shutdown"},{"line_number":63,"context_line":"      when: not cold_migrations_completed_before_sigterm"},{"line_number":64,"context_line":"      delegate_to: compute1"},{"line_number":65,"context_line":"      become: true"},{"line_number":66,"context_line":"      shell: \"kill -15 $(systemctl show devstack@n-cpu -p MainPID --value)\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bb057ef1_c9e9e67b","line":63,"in_reply_to":"446c9845_55a444bd","updated":"2026-02-23 18:09:02.000000000","message":"ack, will do that way.","commit_id":"bbe4f0bd7a67a8a3697d98495e7c167f66927372"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3713078587cceb7565db7639c5ab8f4550a4589d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        cold_migrations_completed_before_sigterm: \"{{ start_cold_migrations_result.rc \u003d\u003d 2 }}\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    - name: Send SIGTERM to source compute to start the source compute graceful shutdown"},{"line_number":63,"context_line":"      when: not cold_migrations_completed_before_sigterm"},{"line_number":64,"context_line":"      delegate_to: compute1"},{"line_number":65,"context_line":"      become: true"},{"line_number":66,"context_line":"      shell: \"kill -15 $(systemctl show devstack@n-cpu -p MainPID --value)\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8ab91615_cbeb2ea2","line":63,"in_reply_to":"bb057ef1_c9e9e67b","updated":"2026-02-23 20:52:42.000000000","message":"Done","commit_id":"bbe4f0bd7a67a8a3697d98495e7c167f66927372"}]}