)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"73493d39d44badd93e0f5227c6fce49a9676a42d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Adding more tests for graceful shutdown:"},{"line_number":10,"context_line":"- shutdown the destination compute and see how live and cold migration"},{"line_number":11,"context_line":"progress"},{"line_number":12,"context_line":"- start build instance and ocne comoute start building instance then"},{"line_number":13,"context_line":"shutdown the comoute service and see if build instance finish or not."},{"line_number":14,"context_line":"- revert resize server"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial implement blueprint nova-services-graceful-shutdown-part1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a76af8f4_01dedefa","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":68},"updated":"2026-02-25 15:30:51.000000000","message":"nit: spelling/wording\n```suggestion\n- start build an instance and once the compute starts building the instance shutdown the compute service and see if instance build finishes or not.\n```","commit_id":"b1d24ce1cdb6a6aadce3df90cf45d9ced94fa3b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b7f7691c1f63ad8fdcae93b8ab7ec2c568d3e257","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Adding more tests for graceful shutdown:"},{"line_number":10,"context_line":"- shutdown the destination compute and see how live and cold migration"},{"line_number":11,"context_line":"progress"},{"line_number":12,"context_line":"- start build instance and ocne comoute start building instance then"},{"line_number":13,"context_line":"shutdown the comoute service and see if build instance finish or not."},{"line_number":14,"context_line":"- revert resize server"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial implement blueprint nova-services-graceful-shutdown-part1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a426b9a7_5624b6de","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":68},"in_reply_to":"a76af8f4_01dedefa","updated":"2026-02-25 20:46:20.000000000","message":"ack, will fix it if I end up respin it.","commit_id":"b1d24ce1cdb6a6aadce3df90cf45d9ced94fa3b4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a5f515167417db7600caecdb5fab3ed51fe0f3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8f1e2359_9e07f56f","updated":"2026-02-23 17:40:47.000000000","message":"other than the issue I noted in the previous patches this looks good","commit_id":"b4ba21594bb2c3ce4b2d72416b1877b8c005a254"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f2dec7e40c8ca54e4e7a8e203b978235fef2efa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b2c4a125_99472047","updated":"2026-02-24 05:31:36.000000000","message":"doing migration with flavor.small is failing on allocation due to CI resource limitation. let me revert it to use tiny flavor VM","commit_id":"590dc648665ff79d2ef6ce7d20f0400c4cb4bba7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0ae2884312b91da2bbd1b6594e4726930be3c24c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e82a9f4e_438c9e37","updated":"2026-02-25 20:55:43.000000000","message":"ok we can proceed with this for now and imporve it in followups","commit_id":"b47d217ca792cecd8f1d91064abc47094682a4e9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ac4b457fdd14b90699fee3f528c0123630b7904a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5720abbc_faf83c19","updated":"2026-02-26 10:55:56.000000000","message":"seems good to me !","commit_id":"b47d217ca792cecd8f1d91064abc47094682a4e9"}],"roles/run-graceful-shutdown-tests/files/build_instance.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"73493d39d44badd93e0f5227c6fce49a9676a42d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7469ffeb_0680259a","line":44,"updated":"2026-02-25 15:30:51.000000000","message":"this is racy as it could compelte before we stop the compute service.\n\nthat is partly why i was expectign use to have funtional test for this not intergartion style checks since the funcitonl tests are really the only way we can do this without haveing races.","commit_id":"b1d24ce1cdb6a6aadce3df90cf45d9ced94fa3b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b7f7691c1f63ad8fdcae93b8ab7ec2c568d3e257","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2e368a8d_c4dc720f","line":44,"in_reply_to":"7469ffeb_0680259a","updated":"2026-02-25 20:46:20.000000000","message":"I know, that is why we will fail the job if any of the operations are finishing before SIGTERM and that time we can see if these integration testing is doanble in upstream CI or not. But i do not disagree with the functional tests when we will have task tracking things and way to have 2nd RPC server in fake RPC server used by the functional tests.","commit_id":"b1d24ce1cdb6a6aadce3df90cf45d9ced94fa3b4"}],"roles/run-graceful-shutdown-tests/tasks/main.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"73493d39d44badd93e0f5227c6fce49a9676a42d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"          environment:"},{"line_number":132,"context_line":"            CONTROLLER_HOSTNAME: \"{{ hostvars[\u0027controller\u0027][\u0027ansible_hostname\u0027] }}\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Sleep for 180 sec: default graceful_shutdown_timeout"},{"line_number":135,"context_line":"        - name: Sleep for 180 seconds to allow dest compute graceful shutdown to complete"},{"line_number":136,"context_line":"          pause:"},{"line_number":137,"context_line":"            seconds: 180"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        - name: Verify dest compute service is stopped after graceful shutdown"},{"line_number":140,"context_line":"          become: true"},{"line_number":141,"context_line":"          become_user: stack"},{"line_number":142,"context_line":"          script: \"start_and_verify_compute_service.sh {{ hostvars[\u0027controller\u0027][\u0027ansible_hostname\u0027] }} inactive\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    - name: Start and verify dest compute service is running"},{"line_number":145,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ea6e65b6_f005c9d1","line":142,"range":{"start_line":134,"start_character":3,"end_line":142,"end_character":113},"updated":"2026-02-25 15:30:51.000000000","message":"instead of this pattther i think you shoudl intead  poll with a delay upto the default timeout so that we dont add a 3 minute wait to each test stage\n\nsomething like this\n\n```\n- name: Verify dest compute service is stopped (polling)\n  become: true\n  become_user: stack\n  script: \"start_and_verify_compute_service.sh {{ hostvars[\u0027controller\u0027][\u0027ansible_hostname\u0027] }} inactive\"\n  register: compute_status\n  # The loop continues until the return code is 0 (success)\n  until: compute_status.rc \u003d\u003d 0\n  # Try 18 times with a 10-second delay to match your 180s timeout\n  retries: 18\n  delay: 10\n  # This prevents the task from failing immediately if the script returns a non-zero RC \n  # during the polling period.\n  ignore_errors: no\n```","commit_id":"b1d24ce1cdb6a6aadce3df90cf45d9ced94fa3b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b7f7691c1f63ad8fdcae93b8ab7ec2c568d3e257","unresolved":true,"context_lines":[{"line_number":131,"context_line":"          environment:"},{"line_number":132,"context_line":"            CONTROLLER_HOSTNAME: \"{{ hostvars[\u0027controller\u0027][\u0027ansible_hostname\u0027] }}\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Sleep for 180 sec: default graceful_shutdown_timeout"},{"line_number":135,"context_line":"        - name: Sleep for 180 seconds to allow dest compute graceful shutdown to complete"},{"line_number":136,"context_line":"          pause:"},{"line_number":137,"context_line":"            seconds: 180"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        - name: Verify dest compute service is stopped after graceful shutdown"},{"line_number":140,"context_line":"          become: true"},{"line_number":141,"context_line":"          become_user: stack"},{"line_number":142,"context_line":"          script: \"start_and_verify_compute_service.sh {{ hostvars[\u0027controller\u0027][\u0027ansible_hostname\u0027] }} inactive\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    - name: Start and verify dest compute service is running"},{"line_number":145,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f3888b63_d0d600a6","line":142,"range":{"start_line":134,"start_character":3,"end_line":142,"end_character":113},"in_reply_to":"ea6e65b6_f005c9d1","updated":"2026-02-25 20:46:20.000000000","message":"we have sleep in shutdownn so anyways it will wait for that time, eithe we wait without monioring or with monitor, it does not speed up the tests. Yes, I can improve it once task tracking is done instead if manual sleep.","commit_id":"b1d24ce1cdb6a6aadce3df90cf45d9ced94fa3b4"}]}