)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f3fc8513eb84cdf7250af6bc4c8c203351693cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be64b846_54875c4c","updated":"2026-02-23 17:48:13.000000000","message":"couple of suggestions","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1fbe8105adb32eea9b49eee23f8038c47c7f6fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f72d6cfa_fa5629a8","updated":"2026-02-24 15:40:17.000000000","message":"On small thing. Otherwise looks OK to me.","commit_id":"88d5f552d596ec09b2132b6f1bea56040a2f7345"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9276a98882f9bdd105aa37ab81e7ef11100622b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8dc8bab6_073a90b4","updated":"2026-02-25 21:32:56.000000000","message":"im ok with this version","commit_id":"686a61b7665f12c85dfd135dee755bfe51f9abc3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3337a3bf384ff6c655869311c4bf0a5c563fd387","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4822859c_b4613b13","updated":"2026-02-26 10:56:18.000000000","message":"perfect thanks !","commit_id":"a877e0ed1595e882931cedd073d5bb6fce133a51"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b5665fd4c8518d1b5839258150f0368a367205e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8aa7e121_15fdb350","updated":"2026-02-26 09:24:37.000000000","message":"still looks good","commit_id":"a877e0ed1595e882931cedd073d5bb6fce133a51"}],"doc/source/admin/graceful-shutdown.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f3fc8513eb84cdf7250af6bc4c8c203351693cd","unresolved":true,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."}],"source_content_type":"text/x-rst","patch_set":1,"id":"769b9ba3_c8046e68","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":39},"updated":"2026-02-23 17:48:13.000000000","message":"this is true for the services that are implementing an RPC server like nova-compute but confusing for the API services that doesn\u0027t Maybe we need a section about the API services before and make it clear that this section is for services with RPC server.","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be4df307ed7f328fea708a03b672939d4984c987","unresolved":true,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."}],"source_content_type":"text/x-rst","patch_set":1,"id":"97091403_9b0fd015","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":39},"in_reply_to":"769b9ba3_c8046e68","updated":"2026-02-23 18:12:15.000000000","message":"yes, let me rephrase it to apply it for all services/worker.","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1fbe8105adb32eea9b49eee23f8038c47c7f6fd0","unresolved":true,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."}],"source_content_type":"text/x-rst","patch_set":1,"id":"aca38827_d06487f8","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":39},"in_reply_to":"94fea6dd_59234827","updated":"2026-02-24 15:40:17.000000000","message":"This still talks about RPC requests and Nova services, but not all Nova services accepting RPC requests. \n\nCan we say something like:\n\nNova services support graceful shutdown on ``SIGTERM``. When a service worker implementing an RPC server receives ...","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4b20566bb4793a4c3c255217f9aa74f83f79c38","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."}],"source_content_type":"text/x-rst","patch_set":1,"id":"94fea6dd_59234827","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":39},"in_reply_to":"97091403_9b0fd015","updated":"2026-02-24 03:43:01.000000000","message":"Done","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1b08faadfaa38e4f359c41123d7e01beb5cb5b4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."}],"source_content_type":"text/x-rst","patch_set":1,"id":"08277eff_d21db60f","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":39},"in_reply_to":"aca38827_d06487f8","updated":"2026-02-24 17:46:06.000000000","message":"Done","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f3fc8513eb84cdf7250af6bc4c8c203351693cd","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8d5f8671_84c17d3c","line":8,"range":{"start_line":8,"start_character":25,"end_line":8,"end_character":50},"updated":"2026-02-23 17:48:13.000000000","message":"nit: or migrations of instances","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be4df307ed7f328fea708a03b672939d4984c987","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service receives"},{"line_number":6,"context_line":"``SIGTERM``, it stops accepting new RPC requests and waits for in-progress"},{"line_number":7,"context_line":"tasks to reach a safe termination point before exiting. This reduces the risk"},{"line_number":8,"context_line":"of leaving instances or migrations in an instances in an unwanted or"},{"line_number":9,"context_line":"unrecoverable state."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"287882fc_ff7cff67","line":8,"range":{"start_line":8,"start_character":25,"end_line":8,"end_character":50},"in_reply_to":"8d5f8671_84c17d3c","updated":"2026-02-23 18:12:15.000000000","message":"Done","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f3fc8513eb84cdf7250af6bc4c8c203351693cd","unresolved":true,"context_lines":[{"line_number":15,"context_line":"     to complete. A future release will improve this by a proper task tracking"},{"line_number":16,"context_line":"     system."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"How graceful shutdown works"},{"line_number":19,"context_line":"---------------------------"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When ``nova-compute`` receives ``SIGTERM``, the following sequence occurs:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"679f4b2a_5c6e94a2","line":18,"updated":"2026-02-23 17:48:13.000000000","message":"... for nova-compute. \n\nThe rest of the RPC servers does not have alt topics","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be4df307ed7f328fea708a03b672939d4984c987","unresolved":false,"context_lines":[{"line_number":15,"context_line":"     to complete. A future release will improve this by a proper task tracking"},{"line_number":16,"context_line":"     system."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"How graceful shutdown works"},{"line_number":19,"context_line":"---------------------------"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When ``nova-compute`` receives ``SIGTERM``, the following sequence occurs:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0c5730f7_d39c843e","line":18,"in_reply_to":"679f4b2a_5c6e94a2","updated":"2026-02-23 18:12:15.000000000","message":"Done","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f3fc8513eb84cdf7250af6bc4c8c203351693cd","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When ``nova-compute`` receives ``SIGTERM``, the following sequence occurs:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#. The primary RPC server (``compute`` topic) stops accepting new requests."},{"line_number":24,"context_line":"#. The service manager waits up to"},{"line_number":25,"context_line":"   :oslo.config:option:`manager_shutdown_timeout` seconds for in-progress"},{"line_number":26,"context_line":"   tasks to complete."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7c51f6c0_0dd638df","line":23,"updated":"2026-02-23 17:48:13.000000000","message":"... while the secondary RPC server (``compute-alt`` topic) still running and handling a subset of RPCs needed to finish ongoing tasks.","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be4df307ed7f328fea708a03b672939d4984c987","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When ``nova-compute`` receives ``SIGTERM``, the following sequence occurs:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#. The primary RPC server (``compute`` topic) stops accepting new requests."},{"line_number":24,"context_line":"#. The service manager waits up to"},{"line_number":25,"context_line":"   :oslo.config:option:`manager_shutdown_timeout` seconds for in-progress"},{"line_number":26,"context_line":"   tasks to complete."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0a18c722_73df6722","line":23,"in_reply_to":"7c51f6c0_0dd638df","updated":"2026-02-23 18:12:15.000000000","message":"Done","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1f3fc8513eb84cdf7250af6bc4c8c203351693cd","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Setting this option to ``0`` disables the wait entirely: the manager does not"},{"line_number":92,"context_line":"wait for in-progress tasks before proceeding with shutdown."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The operators may want to set the above config options value based on how long"},{"line_number":95,"context_line":"their typical long-running operations (e.g. live migrations) take to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Upgrade considerations"},{"line_number":98,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"016a8685_fde3120a","line":95,"range":{"start_line":93,"start_character":0,"end_line":95,"end_character":78},"updated":"2026-02-23 17:48:13.000000000","message":"This is now a duplicate sentence from L85.","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be4df307ed7f328fea708a03b672939d4984c987","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Setting this option to ``0`` disables the wait entirely: the manager does not"},{"line_number":92,"context_line":"wait for in-progress tasks before proceeding with shutdown."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The operators may want to set the above config options value based on how long"},{"line_number":95,"context_line":"their typical long-running operations (e.g. live migrations) take to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Upgrade considerations"},{"line_number":98,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b87280e0_7ca80f19","line":95,"range":{"start_line":93,"start_character":0,"end_line":95,"end_character":78},"in_reply_to":"016a8685_fde3120a","updated":"2026-02-23 18:12:15.000000000","message":"ah, I copied it from there but forgot to delete L85","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4b20566bb4793a4c3c255217f9aa74f83f79c38","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Setting this option to ``0`` disables the wait entirely: the manager does not"},{"line_number":92,"context_line":"wait for in-progress tasks before proceeding with shutdown."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The operators may want to set the above config options value based on how long"},{"line_number":95,"context_line":"their typical long-running operations (e.g. live migrations) take to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Upgrade considerations"},{"line_number":98,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bc7271cd_34ac4b99","line":95,"range":{"start_line":93,"start_character":0,"end_line":95,"end_character":78},"in_reply_to":"b87280e0_7ca80f19","updated":"2026-02-24 03:43:01.000000000","message":"Done","commit_id":"de833b94e82beef964808dcf559a16a92237e2ac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebd11107feae1bdb79ecb8d1a9a7ffc683f758a5","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Graceful Shutdown"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service worker"},{"line_number":6,"context_line":"implementing an RPC server receives ``SIGTERM``, that worker stops accepting"},{"line_number":7,"context_line":"new RPC requests and waits for in-progress tasks to reach a safe termination"},{"line_number":8,"context_line":"point before exiting. This reduces the risk of leaving instances or migrations"}],"source_content_type":"text/x-rst","patch_set":5,"id":"007c3503_d28a5bb7","line":5,"range":{"start_line":5,"start_character":1,"end_line":5,"end_character":56},"updated":"2026-02-25 16:27:26.000000000","message":"agaiin i dont think compelteing phase 1 is enought to claim this and i said that in the spec review\n\nwhat we ahve don in this cycle IMO is not suffent to calim we supprot graceful shutdown yet.\n\nso i would prefer if we were less commital here  until we complete spec 3\nor at a minitum spec 2\nhttps://github.com/openstack/nova-specs/blob/master/specs/backlog/approved/nova-services-graceful-shutdown.rst#spec-2-smartly-track-and-wait-for-the-in-progress-operations\nhttps://github.com/openstack/nova-specs/blob/master/specs/backlog/approved/nova-services-graceful-shutdown.rst#spec-3-safe-termination-point-for-nova-operations\n\n\n\n```suggestion\nNova services have experimental support graceful shutdown on ``SIGTERM``. When a service worker\n```","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2716fe8e71804319ced2a5175b18394700723945","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Graceful Shutdown"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Nova services support graceful shutdown on ``SIGTERM``. When a service worker"},{"line_number":6,"context_line":"implementing an RPC server receives ``SIGTERM``, that worker stops accepting"},{"line_number":7,"context_line":"new RPC requests and waits for in-progress tasks to reach a safe termination"},{"line_number":8,"context_line":"point before exiting. This reduces the risk of leaving instances or migrations"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0028ed4b_ca267f7a","line":5,"range":{"start_line":5,"start_character":1,"end_line":5,"end_character":56},"in_reply_to":"007c3503_d28a5bb7","updated":"2026-02-25 20:59:42.000000000","message":"Done","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebd11107feae1bdb79ecb8d1a9a7ffc683f758a5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"multiple worker for the ``nova-conductor`` and ``nova-scheduler`` service,"},{"line_number":11,"context_line":"then new requests are handled by the other workers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. note::"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"     The current implementation waits for the"},{"line_number":16,"context_line":"     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df4e19dc_d22b60a4","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":7},"updated":"2026-02-25 16:27:26.000000000","message":"this should be `.. important::`\n\nthis need to be more then just a note IMO","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2716fe8e71804319ced2a5175b18394700723945","unresolved":false,"context_lines":[{"line_number":10,"context_line":"multiple worker for the ``nova-conductor`` and ``nova-scheduler`` service,"},{"line_number":11,"context_line":"then new requests are handled by the other workers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. note::"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"     The current implementation waits for the"},{"line_number":16,"context_line":"     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5b23a7e4_a9c2b885","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":7},"in_reply_to":"df4e19dc_d22b60a4","updated":"2026-02-25 20:59:42.000000000","message":"Done","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebd11107feae1bdb79ecb8d1a9a7ffc683f758a5","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. note::"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"     The current implementation waits for the"},{"line_number":16,"context_line":"     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks"},{"line_number":17,"context_line":"     to complete. A future release will improve this by a proper task tracking"},{"line_number":18,"context_line":"     system."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"How graceful shutdown works for nova-compute service"},{"line_number":21,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0c7458c1_77f8778e","line":18,"range":{"start_line":15,"start_character":5,"end_line":18,"end_character":12},"updated":"2026-02-25 16:27:26.000000000","message":"```suggestion\n     The current implementation waits for the\n     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks\n     to complete. A future release will improve this by a proper task tracking\n     system. As a result opertions can be interupted ungracefully fi the do not\n     complete within this time out leaving instnaces in a poticlaly broke/error\n     state that cannot be fixed via the api requiring operator intervention.\n```","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2716fe8e71804319ced2a5175b18394700723945","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. note::"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"     The current implementation waits for the"},{"line_number":16,"context_line":"     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks"},{"line_number":17,"context_line":"     to complete. A future release will improve this by a proper task tracking"},{"line_number":18,"context_line":"     system."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"How graceful shutdown works for nova-compute service"},{"line_number":21,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c9184aef_84f56a83","line":18,"range":{"start_line":15,"start_character":5,"end_line":18,"end_character":12},"in_reply_to":"0c7458c1_77f8778e","updated":"2026-02-25 20:59:42.000000000","message":"Done","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebd11107feae1bdb79ecb8d1a9a7ffc683f758a5","unresolved":true,"context_lines":[{"line_number":55,"context_line":"The following operations use the secondary RPC server so that they will be"},{"line_number":56,"context_line":"allowed to complete during a graceful shutdown:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Live migration"},{"line_number":59,"context_line":"* Cold migration"},{"line_number":60,"context_line":"* Revert resize"},{"line_number":61,"context_line":"* Cross-cell resize"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e8f7a8bd_4b92ec79","line":58,"range":{"start_line":58,"start_character":1,"end_line":58,"end_character":16},"updated":"2026-02-25 16:27:26.000000000","message":"if the live migration is in process but post_live_migration does not complete before the time out the instnace can be running on the destination host but in the database it can be listed on the souce host.\n\nso this is only partly supproted in this release.\nits better then it was but once the souce node has tarted hte migration on the libvirt levelif its restarted post live migtion may not be triggred properly.\n\ni dont think \nhttps://review.opendev.org/c/openstack/nova/+/975588/26 adresses that.\n\nhttps://review.opendev.org/c/openstack/nova/+/975588/26/roles/run-graceful-shutdown-tests/tasks/main.yaml only test stopign the destination compute. not stoping the souce compute after the call to start the migration in libvirt has started.","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9276a98882f9bdd105aa37ab81e7ef11100622b8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"The following operations use the secondary RPC server so that they will be"},{"line_number":56,"context_line":"allowed to complete during a graceful shutdown:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Live migration"},{"line_number":59,"context_line":"* Cold migration"},{"line_number":60,"context_line":"* Revert resize"},{"line_number":61,"context_line":"* Cross-cell resize"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bcd339c4_d5a1dcdc","line":58,"range":{"start_line":58,"start_character":1,"end_line":58,"end_character":16},"in_reply_to":"56e4089d_6fa48b34","updated":"2026-02-25 21:32:56.000000000","message":"Acknowledged","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2716fe8e71804319ced2a5175b18394700723945","unresolved":true,"context_lines":[{"line_number":55,"context_line":"The following operations use the secondary RPC server so that they will be"},{"line_number":56,"context_line":"allowed to complete during a graceful shutdown:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Live migration"},{"line_number":59,"context_line":"* Cold migration"},{"line_number":60,"context_line":"* Revert resize"},{"line_number":61,"context_line":"* Cross-cell resize"}],"source_content_type":"text/x-rst","patch_set":5,"id":"56e4089d_6fa48b34","line":58,"range":{"start_line":58,"start_character":1,"end_line":58,"end_character":16},"in_reply_to":"e8f7a8bd_4b92ec79","updated":"2026-02-25 20:59:42.000000000","message":"True that is where we have noted that operator needs to tune the timeout based on how long their long runing operations takes. And calling experimental and in note, make it clear about it. This section is what all operations use 2nd RPC and will be allowed to complete.","commit_id":"33bc834f09773d2db2a25fee4960f18a6ee0b071"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9276a98882f9bdd105aa37ab81e7ef11100622b8","unresolved":true,"context_lines":[{"line_number":16,"context_line":"     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks"},{"line_number":17,"context_line":"     to complete. A future release will improve this by a proper task tracking"},{"line_number":18,"context_line":"     system. As a result operations can be interupted ungracefully if they do"},{"line_number":19,"context_line":"     not complete within this time out and can leave instnaces in a unwanted"},{"line_number":20,"context_line":"     state."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"How graceful shutdown works for nova-compute service"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d1ad574a_3635b217","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":38},"updated":"2026-02-25 21:32:56.000000000","message":"nit: this is my mistake but i think that should be timeout","commit_id":"686a61b7665f12c85dfd135dee755bfe51f9abc3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"52b510b90b3372786122ef875ebd7525b84735d6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"     :oslo.config:option:`manager_shutdown_timeout` time for in-progress tasks"},{"line_number":17,"context_line":"     to complete. A future release will improve this by a proper task tracking"},{"line_number":18,"context_line":"     system. As a result operations can be interupted ungracefully if they do"},{"line_number":19,"context_line":"     not complete within this time out and can leave instnaces in a unwanted"},{"line_number":20,"context_line":"     state."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"How graceful shutdown works for nova-compute service"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c4a62446_2fef85ed","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":38},"in_reply_to":"d1ad574a_3635b217","updated":"2026-02-26 01:33:14.000000000","message":"Done","commit_id":"686a61b7665f12c85dfd135dee755bfe51f9abc3"}]}