)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daecdc43769a7f6c11a7480e2b166ccce6846fab","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: honor flavor disk bus and SCSI model for BFV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In boot-from-volume cases, image metadata is not always propagated with"},{"line_number":10,"context_line":"hw_disk_bus, hw_cdrom_bus, and hw_scsi_model. As a result, libvirt may"},{"line_number":11,"context_line":"fall back to defaults and ignore operator intent from flavor extra specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add flavor extra spec fallback for:"},{"line_number":14,"context_line":"- hw:disk_bus"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b4ba7490_ce120b49","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":73},"updated":"2026-03-11 14:11:44.000000000","message":"we do not support setting this form flavor today so this is very misleading\nit implies that its expected to work and that its a bug that it does not instead of it explicyt not being supproted.","commit_id":"fd105d08b4d2e257bbd3a1b956c01efdaff63b0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daecdc43769a7f6c11a7480e2b166ccce6846fab","unresolved":true,"context_lines":[{"line_number":15,"context_line":"- hw:cdrom_bus"},{"line_number":16,"context_line":"- hw:scsi_model"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"while keeping existing precedence:"},{"line_number":19,"context_line":"image metadata \u003e flavor extra specs"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also register these three hw:* keys in extra spec validators, add unit"},{"line_number":22,"context_line":"tests for validation, and add a release note."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1cbc89cf_13f9333b","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":35},"updated":"2026-03-11 14:11:44.000000000","message":"incorrect.\n\nif we supprot it in both we have 2 conventison\n\nthe older convention was flavor had precendece over image\nbut we repelaced that with raisign an explcit error if the two conflict\n\nthere is only one case where we allow the image to refine what the flavor selected\n\nthat is hw:mem_page_size where any or large allows the image to refine the selection to a compatible size.","commit_id":"fd105d08b4d2e257bbd3a1b956c01efdaff63b0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daecdc43769a7f6c11a7480e2b166ccce6846fab","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Also register these three hw:* keys in extra spec validators, add unit"},{"line_number":22,"context_line":"tests for validation, and add a release note."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements: blueprint libvirt-honor-flavor-disk-bus-and-scsi-model-for-bfv"},{"line_number":25,"context_line":"Change-Id: I9315ea1d9c72c55950243ca36704725f831e95b8"},{"line_number":26,"context_line":"Signed-off-by: akamio \u003ckamio_akira@cyberagent.co.jp\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f718b671_62309be9","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":74},"updated":"2026-03-11 14:11:44.000000000","message":"we have not agreed that this should be done.\nthere was a similar request for thsi feature a while ago in \nhttps://bugs.launchpad.net/nova/+bug/2112373\nthat is not a bug but a feature request","commit_id":"fd105d08b4d2e257bbd3a1b956c01efdaff63b0a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f576cf6ea309d8eff8f9773d4bafa53f7c4da06d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b76bb56_fff1aaea","updated":"2026-03-11 15:47:50.000000000","message":"-1 due to the fact the api check is missing and because the dierction and scope has not been agreed\n\nbefore we proceed to far with this we would need to agree to consider this a specless bluepirnt in a nova irc meeting or approvve a nova spec.\n\naddtional we will need to update the documenation for the new extra specs and discuss if we need addtioanl testing i.e. tempest test for this.","commit_id":"5a0b2769add2259de5d3f834d8f5c1a423d0e88f"},{"author":{"_account_id":13570,"name":"Akira KAMIO","email":"kamioakira2.0@gmail.com","username":"kamio"},"change_message_id":"847f39a7a2f888d1d0b3fdefced73bfcb451c3e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6d1b38a9_2eba4782","updated":"2026-03-11 15:24:04.000000000","message":"Thanks for the feedback.\n\nI\u0027ve updated the commit message accordingly.\n\nThis change is not specific to BFV, so I removed the BFV wording and\ndescribed it more generally as adding support in the libvirt driver for\nhonoring the following flavor extra specs when the corresponding image\nproperties are not set:\n\n- hw:disk_bus\n- hw:cdrom_bus\n- hw:scsi_model\n\nI also removed the precedence statement and clarified that Nova raises\nFlavorImageConflict if both image properties and flavor extra specs\ndefine the same key with different values.","commit_id":"5a0b2769add2259de5d3f834d8f5c1a423d0e88f"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f576cf6ea309d8eff8f9773d4bafa53f7c4da06d","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    # For explicit image property and flavor extra spec values, reject"},{"line_number":237,"context_line":"    # conflicts and otherwise select either one."},{"line_number":238,"context_line":"    flavor \u003d instance.get_flavor()"},{"line_number":239,"context_line":"    disk_bus \u003d hardware._get_unique_flavor_image_meta("},{"line_number":240,"context_line":"        f\"{device_type}_bus\", flavor, image_meta)"},{"line_number":241,"context_line":"    # Keep the existing libosinfo fallback for disks when neither explicit"},{"line_number":242,"context_line":"    # image property nor flavor extra spec selected a bus."}],"source_content_type":"text/x-python","patch_set":2,"id":"6cbff8f9_8b1d78a6","line":239,"updated":"2026-03-11 15:47:50.000000000","message":"ack thsi is the correct fuction but its private becuase we actully need to do this check in the api.\n\nthe pattehr we don is to add a new public helper function that we call in both the api to valiedate the compatiablty and in the driver to set the correct value in the xml.\n\nwe then to name these functions get_\u003cthing\u003e_constraint \ni.e. get_mem_encryption_constraint\n\nhttps://github.com/openstack/nova/blob/c33df9dc4bea75c91c3dec2c826b80087ed81dc5/nova/virt/hardware.py#L1160\n\n\nin the api we invoke it form _validate_flavor_image_nostatus \nhttps://github.com/openstack/nova/blob/c33df9dc4bea75c91c3dec2c826b80087ed81dc5/nova/compute/api.py#L777\n\nfor example\n\n        # Verify flavor/image Virtio Packed Ring configuration conflict.\n        hardware.get_packed_virtqueue_constraint(flavor, image)\n        \nhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L813-L814\n\ncan you follow that pattern\n\nalso if we are going to do this we likely woudl want this to have a spec or at least dsicuss also covfing the other storage image properties \n\nhw_cdrom_bus\nhw_rescue_bus\nhw_rescue_device\n\nto cover all the storage parmater\n\nim not gong to suggest expanding the scope more to supprot non storage bus or models \n\n```\n  # name of the video adapter model to use, eg cirrus, vga, xen, qxl\n        \u0027hw_video_model\u0027: fields.VideoModelField(),\n\n        # MB of video RAM to provide eg 64\n        \u0027hw_video_ram\u0027: fields.IntegerField(),\n\n        # name of a NIC device model eg virtio, e1000, rtl8139\n        \u0027hw_vif_model\u0027: fields.VIFModelField(),\n\n        # name of IOMMU device model eg virtio, intel, smmuv3, or auto\n        \u0027hw_viommu_model\u0027: fields.VIOMMUModelField(),\n        \n                # name of emulated TPM model to use.\n        \u0027hw_tpm_model\u0027: fields.TPMModelField(),\n        # version of emulated TPM to use.\n        \u0027hw_tpm_version\u0027: fields.TPMVersionField(),\n\n```\n\nbut by openen gthe dore to supproting the disk_bus we woudl have to review if we shoudl consdier full partity or  other image properties to have partial partity betwen flavors and iamges.","commit_id":"5a0b2769add2259de5d3f834d8f5c1a423d0e88f"}],"releasenotes/notes/bp-libvirt-honor-flavor-disk-bus-scsi-model-7b50a1fd8d66d4d0.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daecdc43769a7f6c11a7480e2b166ccce6846fab","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added validation support for the ``hw:disk_bus``, ``hw:cdrom_bus``, and"},{"line_number":5,"context_line":"    ``hw:scsi_model`` flavor extra specs."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    For the libvirt driver, these extra specs can be used as fallback values"},{"line_number":8,"context_line":"    for boot-from-volume instances when the corresponding image metadata"},{"line_number":9,"context_line":"    (``hw_disk_bus``, ``hw_cdrom_bus``, and ``hw_scsi_model``) is unavailable."},{"line_number":10,"context_line":"    Image metadata continues to take precedence over flavor extra specs."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"26d1a255_09978dac","line":10,"range":{"start_line":6,"start_character":1,"end_line":10,"end_character":72},"updated":"2026-03-11 14:11:44.000000000","message":"this is incrrect if we were to add this feature we woudl retrun a flaovr image conflict expction if the image and flavor values did not match.","commit_id":"fd105d08b4d2e257bbd3a1b956c01efdaff63b0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f576cf6ea309d8eff8f9773d4bafa53f7c4da06d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added validation support for the ``hw:disk_bus``, ``hw:cdrom_bus``, and"},{"line_number":5,"context_line":"    ``hw:scsi_model`` flavor extra specs."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    For the libvirt driver, these extra specs can be used as fallback values"},{"line_number":8,"context_line":"    for boot-from-volume instances when the corresponding image metadata"},{"line_number":9,"context_line":"    (``hw_disk_bus``, ``hw_cdrom_bus``, and ``hw_scsi_model``) is unavailable."},{"line_number":10,"context_line":"    Image metadata continues to take precedence over flavor extra specs."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"09b0ec77_652e7937","line":10,"range":{"start_line":6,"start_character":1,"end_line":10,"end_character":72},"in_reply_to":"26d1a255_09978dac","updated":"2026-03-11 15:47:50.000000000","message":"Done","commit_id":"fd105d08b4d2e257bbd3a1b956c01efdaff63b0a"}]}