)]}'
{"nova/tests/fixtures/nova.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"950eaf314de18e9434675a91f10cb95d8a88c3f8","unresolved":true,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        # Save the current cell routing for this thread/greenlet so we"},{"line_number":458,"context_line":"        # can restore it when we leave this context."},{"line_number":459,"context_line":"        previous \u003d getattr(self._local, \u0027ctxt_mgr\u0027, self._default_ctxt_mgr)"},{"line_number":460,"context_line":"        self._local.ctxt_mgr \u003d desired"},{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            with self._real_target_cell(context, cell_mapping) as c:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebbc2e4b_adda309b","line":459,"updated":"2026-04-15 13:56:33.000000000","message":"If each service start sets ctxt_mgr to the default, how can be that we see a not defined ctxt_mgr in the thread local? I guess it is possible that the service spawn threads later and those threads are not inheriting the DB context, so if such thread tries to access the DB without targeting a specific cell we need to fall back to the default ctxt_mgr here\n.","commit_id":"9b0508fa6b0347a851c7c347bbd9a0f1d44b24e4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"950eaf314de18e9434675a91f10cb95d8a88c3f8","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        self._local.ctxt_mgr \u003d desired"},{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            with self._real_target_cell(context, cell_mapping) as c:"},{"line_number":463,"context_line":"                yield c"},{"line_number":464,"context_line":"        finally:"},{"line_number":465,"context_line":"            self._local.ctxt_mgr \u003d previous"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b5ef5f95_c8487736","line":463,"updated":"2026-04-15 13:56:33.000000000","message":"OK, so while we within this context the self._local.ctxt_mgr is set to \"desired\" ctxt_mgr that maps to the proper cell DB. But I don\u0027t see when the current value of self._local.ctxt_mgr is read and therefore affecting the current thread\u0027s access to the DB.","commit_id":"9b0508fa6b0347a851c7c347bbd9a0f1d44b24e4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2b9ea3c0eadb002d9f7699e6392752f660ef4da7","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        self._local.ctxt_mgr \u003d desired"},{"line_number":461,"context_line":"        try:"},{"line_number":462,"context_line":"            with self._real_target_cell(context, cell_mapping) as c:"},{"line_number":463,"context_line":"                yield c"},{"line_number":464,"context_line":"        finally:"},{"line_number":465,"context_line":"            self._local.ctxt_mgr \u003d previous"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"591cfcab_b925a4e9","line":463,"in_reply_to":"b5ef5f95_c8487736","updated":"2026-04-15 16:01:52.000000000","message":"Yes, you are right this is not being used 😩 must have been some mess up while iterating on the change locally. I\u0027ll fix this.","commit_id":"9b0508fa6b0347a851c7c347bbd9a0f1d44b24e4"}]}
