)]}'
{"nova/tests/compute/test_rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5b44b58e57aeb4d6816ae3c9b9610b7eab04edf7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                         \u0027instance_type_id\u0027: 1}"},{"line_number":42,"context_line":"        inst \u003d db.instance_create(self.context, instance_attr)"},{"line_number":43,"context_line":"        self.fake_instance \u003d jsonutils.to_primitive(inst)"},{"line_number":44,"context_line":"        self.fake_instance_obj \u003d fake_instance_obj(self.context,"},{"line_number":45,"context_line":"                                                   **instance_attr)"},{"line_number":46,"context_line":"        self.fake_volume_bdm \u003d jsonutils.to_primitive("},{"line_number":47,"context_line":"                fake_block_device.FakeDbBlockDeviceDict("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_a5b53d33","line":44,"updated":"2014-06-27 16:30:18.000000000","message":"Just convert self.fake_instance into an object, don\u0027t need to create a duplicate.","commit_id":"a5169dbc6e5aff9de00b4668d7fbf9d57f404856"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"c9aa4ac567b36f37cd6aa59bfd57a8a53893474d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                         \u0027instance_type_id\u0027: 1}"},{"line_number":42,"context_line":"        inst \u003d db.instance_create(self.context, instance_attr)"},{"line_number":43,"context_line":"        self.fake_instance \u003d jsonutils.to_primitive(inst)"},{"line_number":44,"context_line":"        self.fake_instance_obj \u003d fake_instance_obj(self.context,"},{"line_number":45,"context_line":"                                                   **instance_attr)"},{"line_number":46,"context_line":"        self.fake_volume_bdm \u003d jsonutils.to_primitive("},{"line_number":47,"context_line":"                fake_block_device.FakeDbBlockDeviceDict("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_7b4bd22a","line":44,"in_reply_to":"1ae5cdf2_a5b53d33","updated":"2014-06-27 17:37:23.000000000","message":"But this will be cleaner when we can eventually remove the db_objects all together.   It doesn\u0027t add any significant overhead, so this seemed cleaner to me","commit_id":"a5169dbc6e5aff9de00b4668d7fbf9d57f404856"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"250410211e0859fbf1c501473bc44c214c2619ac","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                         \u0027instance_type_id\u0027: 1}"},{"line_number":41,"context_line":"        self.fake_instance_obj \u003d fake_instance_obj(self.context,"},{"line_number":42,"context_line":"                                                   **instance_attr)"},{"line_number":43,"context_line":"        self.fake_instance \u003d jsonutils.to_primitive(self.fake_instance_obj)"},{"line_number":44,"context_line":"        self.fake_volume_bdm \u003d jsonutils.to_primitive("},{"line_number":45,"context_line":"                fake_block_device.FakeDbBlockDeviceDict("},{"line_number":46,"context_line":"                    {\u0027source_type\u0027: \u0027volume\u0027, \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_fb3a7de4","line":43,"updated":"2014-06-27 20:46:01.000000000","message":"Sorry, not exactly what I was thinking, if anything in this test relies on self.fake_instance being in the database this has changed now since I don\u0027t think fake_instance_obj actually creates an instance in the database.\n\nI was actually thinking more along the lines of just using the existing fake_instance dict to create the instance object by calling objects.Instance._from_db_object.","commit_id":"c2aa27d6f86d9ead2a9653b07de425669351d93d"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cdc7b0b06d4dc857be3c54bf5c78c54aedbc028d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                         \u0027instance_type_id\u0027: 1}"},{"line_number":41,"context_line":"        self.fake_instance_obj \u003d fake_instance_obj(self.context,"},{"line_number":42,"context_line":"                                                   **instance_attr)"},{"line_number":43,"context_line":"        self.fake_instance \u003d jsonutils.to_primitive(self.fake_instance_obj)"},{"line_number":44,"context_line":"        self.fake_volume_bdm \u003d jsonutils.to_primitive("},{"line_number":45,"context_line":"                fake_block_device.FakeDbBlockDeviceDict("},{"line_number":46,"context_line":"                    {\u0027source_type\u0027: \u0027volume\u0027, \u0027destination_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2fe7f613","line":43,"in_reply_to":"1ae5cdf2_fb3a7de4","updated":"2014-07-01 14:04:14.000000000","message":"From what I can see nothing should be depending on the instance being in the db.  And if it were I would hope that the test would fail.","commit_id":"c2aa27d6f86d9ead2a9653b07de425669351d93d"}]}