)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"166fb28ca746e824acc13e40c087bfae86631b19","unresolved":false,"context_lines":[{"line_number":3975,"context_line":"    def get_console_output(self, context, instance, tail_length):"},{"line_number":3976,"context_line":"        \"\"\"Send the console output for the given instance.\"\"\""},{"line_number":3977,"context_line":"        instance \u003d objects.Instance._from_db_object("},{"line_number":3978,"context_line":"            context, objects.Instance(), instance)"},{"line_number":3979,"context_line":"        context \u003d context.elevated()"},{"line_number":3980,"context_line":"        LOG.audit(_(\"Get console output\"), context\u003dcontext,"},{"line_number":3981,"context_line":"                  instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e5bca5de","side":"PARENT","line":3978,"updated":"2014-06-12 22:50:32.000000000","message":"No fair, too easy! :)","commit_id":"f807356df966b971a6be5f0440f1131b6aaff7d6"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e2839b4c3b7606fc780575b40ca59ab98288cb4a","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def get_console_output(self, ctxt, instance, tail_length):"},{"line_number":450,"context_line":"        # NOTE(russellb) Havana compat"},{"line_number":451,"context_line":"        version \u003d self._get_compat_version(\u00273.0\u0027, \u00272.0\u0027)"},{"line_number":452,"context_line":"        if self.client.can_send_version(\u00273.28\u0027):"},{"line_number":453,"context_line":"            version \u003d \u00273.28\u0027"},{"line_number":454,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0089e825","line":451,"updated":"2014-06-10 14:05:53.000000000","message":"It would be better to move the above line(451) to line455 like the other method such as line479 for the readability.","commit_id":"4bb9cde53f8616e04f166ade6d3e81a00368fd07"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e2839b4c3b7606fc780575b40ca59ab98288cb4a","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        if self.client.can_send_version(\u00273.18\u0027):"},{"line_number":476,"context_line":"            version \u003d \u00273.18\u0027"},{"line_number":477,"context_line":"        else:"},{"line_number":478,"context_line":"            # NOTE(russellb) Havana compat"},{"line_number":479,"context_line":"            version \u003d self._get_compat_version(\u00273.0\u0027, \u00272.0\u0027)"},{"line_number":480,"context_line":"            instance \u003d jsonutils.to_primitive(instance)"},{"line_number":481,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(None, instance),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_00bba8e5","line":478,"updated":"2014-06-10 14:05:53.000000000","message":"here","commit_id":"4bb9cde53f8616e04f166ade6d3e81a00368fd07"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"166fb28ca746e824acc13e40c087bfae86631b19","unresolved":false,"context_lines":[{"line_number":254,"context_line":"               rollback_live_migration_at_destination() take an object"},{"line_number":255,"context_line":"        ...  - Removed run_instance()"},{"line_number":256,"context_line":"        3.27 - Make run_instance() accept a new-world object"},{"line_number":257,"context_line":"        3.28 - Update get_console_output() to take an object"},{"line_number":258,"context_line":"    \u0027\u0027\u0027"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c5ea49d7","line":257,"updated":"2014-06-12 22:50:32.000000000","message":"I\u0027d love to complain that you should say \"a new-world\" object like the rest of the comments here, but since the rest of this looks good, I\u0027ll spare you :P","commit_id":"56b80902900bc904af1a431c5a7dea06ce0facc0"}],"nova/tests/api/openstack/compute/contrib/test_console_output.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f268d8c2cdf53b35ecd77a1b5b237e0c9b9cf5c7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return string.printable"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fake_get(self, context, instance_uuid, want_objects\u003dFalse):"},{"line_number":49,"context_line":"    return fake_instance.fake_instance_obj(context, **{\u0027uuid\u0027: instance_uuid})"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c16b02ef","line":48,"updated":"2014-06-13 17:42:50.000000000","message":"Seems a bit odd that this would default to False and then always return an object...","commit_id":"56b80902900bc904af1a431c5a7dea06ce0facc0"}]}