)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"08031a17138db3e38eea062b99c5c6c6cc67e537","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alessio Ababilov \u003caababilov@griddynamics.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-07-16 18:32:56 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"implement network association in OS API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iafaf4a5ae3d3e16a6c649f1d7850fceba732efab"},{"line_number":10,"context_line":"Implements: blueprint os-api-network-associate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAKX%2F%2F3Ys%3D","line":7,"updated":"2012-07-20 17:27:37.000000000","message":"This commit message needs to be expanded.  Please see the new \"Commit Messages\" section in HACKING.rst.","commit_id":"362644de2b8871a05614347f055ae29c06c9dec5"}],"nova/api/openstack/compute/contrib/networks.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"08031a17138db3e38eea062b99c5c6c6cc67e537","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        network_id \u003d body.get(\u0027id\u0027, None)"},{"line_number":218,"context_line":"        project_id \u003d context.project_id"},{"line_number":219,"context_line":"        LOG.debug(_(\"Associating network %s with project %s\") %"},{"line_number":220,"context_line":"                  (network_id or \u0027\u0027, project_id))"},{"line_number":221,"context_line":"        try:"},{"line_number":222,"context_line":"            self.network_api.add_network_to_project("},{"line_number":223,"context_line":"                context, project_id, network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F3Yg%3D","line":220,"updated":"2012-07-20 17:27:37.000000000","message":"You need to use dict-style expandos for internationalized strings like this, something like:\n\n    LOG.debug(_(\"Associating network %(network)s with project %(project)s\") %\n              dict(network\u003dnetwork_id or \u0027\u0027, project\u003dproject_id))","commit_id":"362644de2b8871a05614347f055ae29c06c9dec5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1d722b1cb1c44a7d14791dea2260fce097d30496","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        network_id \u003d body.get(\u0027id\u0027, None)"},{"line_number":218,"context_line":"        project_id \u003d context.project_id"},{"line_number":219,"context_line":"        LOG.debug(_(\"Associating network %s with project %s\") %"},{"line_number":220,"context_line":"                  (network_id or \u0027\u0027, project_id))"},{"line_number":221,"context_line":"        try:"},{"line_number":222,"context_line":"            self.network_api.add_network_to_project("},{"line_number":223,"context_line":"                context, project_id, network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F2SA%3D","line":220,"in_reply_to":"AAAAKX%2F%2F2f0%3D","updated":"2012-07-23 15:05:37.000000000","message":"*shrug* I can\u0027t disagree with you, but I don\u0027t think a final decision on this has been made yet.","commit_id":"362644de2b8871a05614347f055ae29c06c9dec5"},{"author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"change_message_id":"b7049c68f26fb3fe1af8dd6a9abe97f0d02b069c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        network_id \u003d body.get(\u0027id\u0027, None)"},{"line_number":218,"context_line":"        project_id \u003d context.project_id"},{"line_number":219,"context_line":"        LOG.debug(_(\"Associating network %s with project %s\") %"},{"line_number":220,"context_line":"                  (network_id or \u0027\u0027, project_id))"},{"line_number":221,"context_line":"        try:"},{"line_number":222,"context_line":"            self.network_api.add_network_to_project("},{"line_number":223,"context_line":"                context, project_id, network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F2f0%3D","line":220,"in_reply_to":"AAAAKX%2F%2F3Yg%3D","updated":"2012-07-23 10:02:27.000000000","message":"OK!\nBTW, I can see no reason to internationalize debug and log messages. They are devoted to admins, not to end users. And the admin ought to understand English. Also, it\u0027s reasonable to google you error in English rather than in some other language.","commit_id":"362644de2b8871a05614347f055ae29c06c9dec5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"08031a17138db3e38eea062b99c5c6c6cc67e537","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            raise exc.HTTPBadRequest("},{"line_number":226,"context_line":"                explanation\u003d"},{"line_number":227,"context_line":"                _(\"Cannot associate network %s with project %s: %s\") %"},{"line_number":228,"context_line":"                (network_id or \u0027\u0027, project_id, getattr(ex, \"value\", str(ex))))"},{"line_number":229,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F3YY%3D","line":228,"updated":"2012-07-20 17:27:37.000000000","message":"Again, you need to fix up your internationalized string.  I\u0027d recommend restructuring this so that you do something like:\n\n    msg \u003d _(\"Cannot …\") % …\n    raise exc.HTTPBadRequest(explanation\u003dmsg)","commit_id":"362644de2b8871a05614347f055ae29c06c9dec5"},{"author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"change_message_id":"b7049c68f26fb3fe1af8dd6a9abe97f0d02b069c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            raise exc.HTTPBadRequest("},{"line_number":226,"context_line":"                explanation\u003d"},{"line_number":227,"context_line":"                _(\"Cannot associate network %s with project %s: %s\") %"},{"line_number":228,"context_line":"                (network_id or \u0027\u0027, project_id, getattr(ex, \"value\", str(ex))))"},{"line_number":229,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAKX%2F%2F2fw%3D","line":228,"in_reply_to":"AAAAKX%2F%2F3YY%3D","updated":"2012-07-23 10:02:27.000000000","message":"Done","commit_id":"362644de2b8871a05614347f055ae29c06c9dec5"}]}
