)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38234,"name":"Ian Watson","display_name":"Ian Watson","email":"ianwatson92@hotmail.co.uk","username":"ianwatsonit"},"change_message_id":"5fe6392519052d3d2a93649f87610053de897f00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b37fb7d7_b4b6e30e","updated":"2026-04-22 13:43:58.000000000","message":"Hey there I’ve already proposed a PR for this here https://review.opendev.org/c/openstack/nova/+/955685","commit_id":"9215a204918471a1a28533da468eafc0336aa36b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5db48bbe4ac64fa8ec0b6493ae0ca2d7e2de28ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62a088a0_7cef901f","updated":"2026-05-11 16:53:41.000000000","message":"I think I prefer the alternate approach as it reuses more code. That one seems to be lacking in the test a bit though.","commit_id":"9215a204918471a1a28533da468eafc0336aa36b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"cbc31c081947b40e2cd674fbfc96b7dc622b1cb1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6cf6f48_c3e09bd9","updated":"2026-04-22 09:31:25.000000000","message":"That looks not too complicated. So I tried to propose something.\nHowever due to my Ironic knowledge, I\u0027m not sure about what I\u0027m doing. :)\nAlso, I think a real test with Ironic might be required to check that the propose fix work as expected.","commit_id":"9215a204918471a1a28533da468eafc0336aa36b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"709170b0e483b84aa643b7e36cdc4fdc141d571c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b76d04d_472aa861","updated":"2026-04-22 15:18:31.000000000","message":"https://review.opendev.org/c/openstack/nova/+/955685","commit_id":"9215a204918471a1a28533da468eafc0336aa36b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"709170b0e483b84aa643b7e36cdc4fdc141d571c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7428737e_1ab47bbd","in_reply_to":"b37fb7d7_b4b6e30e","updated":"2026-04-22 15:18:31.000000000","message":"https://review.opendev.org/c/openstack/nova/+/955685 i think is clean but this change has slight better testing so ya i woudlk sugget we use https://review.opendev.org/c/openstack/nova/+/955685 and just rebase this on top to provde the extra tests or squash them in","commit_id":"9215a204918471a1a28533da468eafc0336aa36b"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5db48bbe4ac64fa8ec0b6493ae0ca2d7e2de28ec","unresolved":true,"context_lines":[{"line_number":640,"context_line":"        if not self.node_cache:"},{"line_number":641,"context_line":"            self._refresh_cache()"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        return sum(1 for node in self.node_cache.values()"},{"line_number":644,"context_line":"                   if node.instance_id is not None)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def list_instances(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"48121c4e_6291f0f7","line":643,"updated":"2026-05-11 16:53:41.000000000","message":"This seems weird to me (maybe a claude artifact). The length of the list is the thing we are actually returning here right? If so, I think that would be a lot more obvious to a reader.","commit_id":"9215a204918471a1a28533da468eafc0336aa36b"}]}