)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"23b7b47a6db3d25dce05cc9b5e8c197037b9ef80","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b134fa4c_b018ad26","updated":"2026-04-24 19:13:15.000000000","message":"As someone who might be a candidate for \"external expert\" in these proposals, I\u0027ll note I strongly prefer those where the +A would be held by Nova-specific experts, even if a +2 is permitted from external experts.\n\nEven if not enforced by Gerrit, I doubt I\u0027d feel comfortable being the final approver for patches in Nova. Just my $0.02 if you care for them :). \n\nBTW -- I really like the way you all have structured this. Thanks!","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"136a8bdb8b01e3c8a410dc7239cf215e19586e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a6f20bf7_a8fc2472","updated":"2026-04-24 16:47:29.000000000","message":"I am in favor of this option","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c41427c960a45037dd444c4d8af431a8cbe3a544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab845666_44f3e200","updated":"2026-04-24 22:32:36.000000000","message":"I like this too, and thanks for pioneering this change; i\u0027m hoping this helps as a pattern to other teams. We\u0027ve seen success with this elsewhere, and I would love to see this in Nova.","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9f6d8c6c0dac7cd5314a13d1fe5c4951a49b543f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4832894_826da49a","updated":"2026-04-29 17:16:49.000000000","message":"I wish we could have had -1 for preference -2 for \"I\u0027m not okay with this\" more in line with how these typically go. So count me as -0.9 here.. I don\u0027t want to do this, but I certainly don\u0027t want to block the team from doing it if that\u0027s the consensus (like the -1s on the higher proposals appear to be doing).\n\nI think this adds complexity and mechanics (i.e. new group, new rules, new membership discussions) for the sake of showing a +2 and that seems like a lot of overhead to me. It also seems to me like in two years if this doesn\u0027t pan out, we\u0027ll look back at a patch and be confused why some (seemingly random) people were +2 on a thing here. It\u0027s a common thing to do when trying to figure out why we made a change, to go look at who proposed and reviewed it.\n\nIn reading the four of these options, I wondered if another option might be worth considering. That would be to just relax the \"two cores\" requirement for some situations. Basically, if a single core felt like a change was trivial or straightforward enough to just fast approve, we\u0027d allow for more of that. That could mean that if a single core feels like an Ironic driver change is contained enough to not impact the other drivers (so like the metadata change would not qualify) and it\u0027s reviewed by an ironic person, then ... +2+W. Cinder stuff that brings API changes would be above the bar, but smaller changes to interact with brick or cinderclient might be under it. I feel like it would be a thing we could document by example fairly easy.\n\nAnd that leads right into what my question was going to be (which is also gibi\u0027s question): how are we going to decide who is in the other group? Even if we agree to do that, if we can\u0027t agree on anyone that goes in that group then nothing has changed. I can certainly imagine that being even more contentious than agreeing on the general principle. Leaving it up to cores in the moment with judgment and examples might include a wider swath of people actually being able to inform the merge of a patch. It also could decrease some of the pressure we have where one of the cores that would be working to approve a piece of code is also the author and thus requires a third core to take time to review it.","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2709ce2a66adf7a903ca2304624d4c8b00380e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70ef2907_67b7321e","updated":"2026-04-28 14:41:44.000000000","message":"Works for me. I guess if we go with this we need a way to recruit / select folks for the new group from the adjacent services.","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ff92c7b1d93c17c4d756cb83ac7ae51da213f70c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f73ffe08_23b9e5de","updated":"2026-04-26 17:37:44.000000000","message":"this is my prefered option","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c41427c960a45037dd444c4d8af431a8cbe3a544","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9c84dbd_6296a95c","in_reply_to":"352a22ff_2a291e73","updated":"2026-04-24 22:32:36.000000000","message":"+1","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5ca1b18f259a15910acacaf68afd050e6d441305","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"352a22ff_2a291e73","in_reply_to":"b134fa4c_b018ad26","updated":"2026-04-24 19:51:34.000000000","message":"Thanks, Jay. In my mind there\u0027s an implicit assumption here that a nova-specific expert would be the second reviewer (or would spin back around to +W later on) but I didn\u0027t vocalise that today, so I\u0027d be disinclined to update this for now. It might be something to encode later on though.","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"}],"doc/source/contributor/policies.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c41427c960a45037dd444c4d8af431a8cbe3a544","unresolved":true,"context_lines":[{"line_number":105,"context_line":"too thin and the core team shrinks."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. [#f1] What constitutes \"non-trivial\" is of course subjective, but it"},{"line_number":108,"context_line":"         includes things like obvious typo fixes or small, provably correct bug"},{"line_number":109,"context_line":"         fixes."},{"line_number":110,"context_line":".. [#f2] By way of a concrete example, it is desirable that patches that add a"},{"line_number":111,"context_line":"         new feature that depends on neutron would be reviewed by neutron"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f0753b3_96c64018","line":108,"range":{"start_line":108,"start_character":59,"end_line":108,"end_character":67},"updated":"2026-04-24 22:32:36.000000000","message":"sorry, hate nit picking, but get this typo when/if you make another update","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f0393e8f2aaa8a8a602b31408ae188cc563a46c","unresolved":true,"context_lines":[{"line_number":105,"context_line":"too thin and the core team shrinks."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. [#f1] What constitutes \"non-trivial\" is of course subjective, but it"},{"line_number":108,"context_line":"         includes things like obvious typo fixes or small, provably correct bug"},{"line_number":109,"context_line":"         fixes."},{"line_number":110,"context_line":".. [#f2] By way of a concrete example, it is desirable that patches that add a"},{"line_number":111,"context_line":"         new feature that depends on neutron would be reviewed by neutron"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d888643b_ed2d38f0","line":108,"range":{"start_line":108,"start_character":59,"end_line":108,"end_character":67},"in_reply_to":"7f0753b3_96c64018","updated":"2026-04-26 17:37:34.000000000","message":"this is correctly spelled\n`provably`  as in something that is provabvle or demonstratable.","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"20134131a65ddbae99f3e30cad9a154e2e8357ce","unresolved":false,"context_lines":[{"line_number":105,"context_line":"too thin and the core team shrinks."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. [#f1] What constitutes \"non-trivial\" is of course subjective, but it"},{"line_number":108,"context_line":"         includes things like obvious typo fixes or small, provably correct bug"},{"line_number":109,"context_line":"         fixes."},{"line_number":110,"context_line":".. [#f2] By way of a concrete example, it is desirable that patches that add a"},{"line_number":111,"context_line":"         new feature that depends on neutron would be reviewed by neutron"}],"source_content_type":"text/x-rst","patch_set":1,"id":"35ba863f_4ff0c105","line":108,"range":{"start_line":108,"start_character":59,"end_line":108,"end_character":67},"in_reply_to":"c32f61e5_db79c476","updated":"2026-04-27 18:41:11.000000000","message":"Done","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c45c9798588d04a61758387bb4fd666809584fd6","unresolved":true,"context_lines":[{"line_number":105,"context_line":"too thin and the core team shrinks."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. [#f1] What constitutes \"non-trivial\" is of course subjective, but it"},{"line_number":108,"context_line":"         includes things like obvious typo fixes or small, provably correct bug"},{"line_number":109,"context_line":"         fixes."},{"line_number":110,"context_line":".. [#f2] By way of a concrete example, it is desirable that patches that add a"},{"line_number":111,"context_line":"         new feature that depends on neutron would be reviewed by neutron"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c32f61e5_db79c476","line":108,"range":{"start_line":108,"start_character":59,"end_line":108,"end_character":67},"in_reply_to":"d888643b_ed2d38f0","updated":"2026-04-27 18:41:02.000000000","message":"AH, my bad then. Sorry about the noise","commit_id":"fa388a8200493b039c0f7e9e136e7b31403d2be6"}]}
