)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6e6a18e61fad7dcca69ed93f2b4f19fd94d32afa","unresolved":true,"context_lines":[{"line_number":10,"context_line":"which is used to disable the policy scope enforcement."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/oslo.policy/+/986475"},{"line_number":12,"context_line":"- https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/M72AY5ABQFXQ7XHLVEGHLBBK4XFQGVFK/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It means scope will be enforced always and no way to disable it. Updating"},{"line_number":15,"context_line":"the nova unit tests accordingly. Nova used to test the policy rules with"},{"line_number":16,"context_line":"enforce_scope\u003dFalse (scope enforcement disable) which is no more valid"},{"line_number":17,"context_line":"config so removing those tests."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/placement/+/987568"},{"line_number":20,"context_line":"Needed-By: https://review.opendev.org/c/openstack/oslo.policy/+/986475"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b7650676_25325474","line":18,"range":{"start_line":13,"start_character":1,"end_line":18,"end_character":1},"updated":"2026-06-24 10:45:27.000000000","message":"nit: wrap at \u003c\u003d 72 chars","commit_id":"21b4c1131c6e1efe0d3d0971bf053b7a571c205b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"654c521af173dc345bb21a90efb7aae033ee357f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"which is used to disable the policy scope enforcement."},{"line_number":11,"context_line":"- https://review.opendev.org/c/openstack/oslo.policy/+/986475"},{"line_number":12,"context_line":"- https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/M72AY5ABQFXQ7XHLVEGHLBBK4XFQGVFK/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It means scope will be enforced always and no way to disable it. Updating"},{"line_number":15,"context_line":"the nova unit tests accordingly. Nova used to test the policy rules with"},{"line_number":16,"context_line":"enforce_scope\u003dFalse (scope enforcement disable) which is no more valid"},{"line_number":17,"context_line":"config so removing those tests."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/placement/+/987568"},{"line_number":20,"context_line":"Needed-By: https://review.opendev.org/c/openstack/oslo.policy/+/986475"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d752e881_c753ac68","line":18,"range":{"start_line":13,"start_character":1,"end_line":18,"end_character":1},"in_reply_to":"b7650676_25325474","updated":"2026-06-25 18:29:22.000000000","message":"Done","commit_id":"21b4c1131c6e1efe0d3d0971bf053b7a571c205b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a52e799d122250cbb49019ac84eb0acfafbbf97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25b8c6f8_bd8ad4b8","updated":"2026-05-06 19:27:39.000000000","message":"testing with oslo.policy change in https://review.opendev.org/c/openstack/nova/+/986479","commit_id":"5b7a5f70a515482e4a3a0b2f83dadb5c7108c1ee"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a0a28eeb97578ff1fe20fc37df9dfabc2727c52d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a57d9eb_a2bb24c4","updated":"2026-06-18 05:12:09.000000000","message":"recheck deps on updated","commit_id":"2cbd3e05e8d8917c68147f588ddd20ac64061905"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8117c1d6c04708f3998db25d5279a7d9fe5e6e31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b6f25d9_716a675c","updated":"2026-06-22 20:36:04.000000000","message":"recheck deps updated","commit_id":"2cbd3e05e8d8917c68147f588ddd20ac64061905"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"14dcfdcefa386f5dd9c3d340b0bfd2de49dfa8b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45dc1182_9a6c176e","updated":"2026-06-18 04:20:28.000000000","message":"recheck refresh logs","commit_id":"2cbd3e05e8d8917c68147f588ddd20ac64061905"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"54378e316741d6583d0a713f0b398437731e2563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4781de02_e2327bf0","updated":"2026-06-23 01:47:29.000000000","message":"this change test nova with the oslo.policy enforce_scope removal change https://review.opendev.org/c/openstack/nova/+/986479\n\nso nova is passing before and after the oslo.policy change is merge","commit_id":"2cbd3e05e8d8917c68147f588ddd20ac64061905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a68cba848928de698dce2775e6fdddf9e003c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0ff4bf1_3113218a","updated":"2026-06-24 10:45:03.000000000","message":"As with [the placement change](https://review.opendev.org/c/openstack/placement/+/987568), I am broadly in favour of this, but I think we should be explicitly checking for `enforce_scope` set to `False` here and failing to start if so.","commit_id":"21b4c1131c6e1efe0d3d0971bf053b7a571c205b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"654c521af173dc345bb21a90efb7aae033ee357f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7e6acfa1_800659d6","updated":"2026-06-25 18:29:22.000000000","message":"separated it from the releasenotes and oslo.policy enforce_scope removal. this is test update only","commit_id":"5acdefc9e9e9458c353191196971a98f80db0efe"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c7612e4968dd8a4bb722d71f256b76ad7b9fbe57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4f7fbd43_d51b7e87","updated":"2026-06-26 20:01:18.000000000","message":"Looks mostly good but I think there might be one piece of test coverage loss, commented inline.","commit_id":"ae230f48614725ecac291233b95231b3b0255355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"489164cf28187cd78eace48f28b4e4a0433e92c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56e96b9c_257efd49","updated":"2026-06-25 22:19:22.000000000","message":"recheck unrelated failure","commit_id":"ae230f48614725ecac291233b95231b3b0255355"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bb7de2679ba63051e76981df5203d9659ce35ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b63b33a4_383d392a","updated":"2026-06-26 20:57:24.000000000","message":"This LGTM now","commit_id":"86cf62641d1d62e853a849cad409fee6f9889e35"}],"nova/tests/unit/policies/test_extensions.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c7612e4968dd8a4bb722d71f256b76ad7b9fbe57","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class ExtensionsNoLegacyPolicyTest(ExtensionsPolicyTest):"},{"line_number":54,"context_line":"    \"\"\"Test Extensions APIs policies with system scope enabled,"},{"line_number":55,"context_line":"    and no more deprecated rules."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    without_deprecated_rules \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"10936805_68d882ce","line":54,"range":{"start_line":54,"start_character":37,"end_line":54,"end_character":62},"updated":"2026-06-26 20:01:18.000000000","message":"Nit: I think other files removed this part of the docstring.","commit_id":"ae230f48614725ecac291233b95231b3b0255355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81b6b6bd6552ed5089a95601a12f3e10b62e3160","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class ExtensionsNoLegacyPolicyTest(ExtensionsPolicyTest):"},{"line_number":54,"context_line":"    \"\"\"Test Extensions APIs policies with system scope enabled,"},{"line_number":55,"context_line":"    and no more deprecated rules."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    without_deprecated_rules \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"18d8ec4f_85376d35","line":54,"range":{"start_line":54,"start_character":37,"end_line":54,"end_character":62},"in_reply_to":"10936805_68d882ce","updated":"2026-06-26 20:26:16.000000000","message":"Acknowledged","commit_id":"ae230f48614725ecac291233b95231b3b0255355"}],"nova/tests/unit/policies/test_instance_actions.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c7612e4968dd8a4bb722d71f256b76ad7b9fbe57","unresolved":true,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch(\u0027nova.objects.InstanceActionEventList.get_by_action\u0027)"},{"line_number":236,"context_line":"    @mock.patch(\u0027nova.objects.InstanceAction.get_by_request_id\u0027)"},{"line_number":237,"context_line":"    def test_show_instance_action_policy_with_show_details("},{"line_number":238,"context_line":"            self, mock_get_action, mock_get_events):"},{"line_number":239,"context_line":"        \"\"\"Test to ensure skip checking policy rule"},{"line_number":240,"context_line":"        \u0027os_compute_api:os-instance-actions:show\u0027."}],"source_content_type":"text/x-python","patch_set":7,"id":"9388a19e_dc9e327d","side":"PARENT","line":237,"updated":"2026-06-26 20:01:18.000000000","message":"I think maybe this test should not be removed and instead should be moved under the base class, because otherwise the coverage is not represented elsewhere?","commit_id":"6d52ef14b602396d3bc5298fc7c827d6c56cc708"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81b6b6bd6552ed5089a95601a12f3e10b62e3160","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch(\u0027nova.objects.InstanceActionEventList.get_by_action\u0027)"},{"line_number":236,"context_line":"    @mock.patch(\u0027nova.objects.InstanceAction.get_by_request_id\u0027)"},{"line_number":237,"context_line":"    def test_show_instance_action_policy_with_show_details("},{"line_number":238,"context_line":"            self, mock_get_action, mock_get_events):"},{"line_number":239,"context_line":"        \"\"\"Test to ensure skip checking policy rule"},{"line_number":240,"context_line":"        \u0027os_compute_api:os-instance-actions:show\u0027."}],"source_content_type":"text/x-python","patch_set":7,"id":"9535c3d4_7ad256ad","side":"PARENT","line":237,"in_reply_to":"9388a19e_dc9e327d","updated":"2026-06-26 20:26:16.000000000","message":"nice catch, yes this should not be removed. Though it was strange that this test only exist in scope test and not in non-scope test class. After checking history, it was added in https://review.opendev.org/c/openstack/nova/+/694430 when event:details was added in API response and we had SYSTEM_READER things and that was exposed to SYSTEM_READER only that is why it was added in scope testing only.\n\nWhen we removed the SYSTEM scope from nova policy and made it to admin access, we did not fix this test to be in base class so that it can be tested in scope as well as non-scope testing.\n\nI will fix it.","commit_id":"6d52ef14b602396d3bc5298fc7c827d6c56cc708"}]}