)]}'
{"nova/image/glance.py":[{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"cff87c050217569beb43ed00707149cbf7282c93","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.IntOpt(\u0027glance_request_timeout\u0027,"},{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               help\u003d\u0027http/https timeout value for glance operations. If no \u0027"},{"line_number":74,"context_line":"                    \u0027value (None) is supplied here, the glanceclient default \u0027"},{"line_number":75,"context_line":"                    \u0027value is used.\u0027)"},{"line_number":76,"context_line":"    ]"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e1e6f9e7","line":74,"updated":"2014-06-09 10:23:49.000000000","message":"its very helpful to mention the timeout unit such as \"timeout value in seconds\"","commit_id":"ecf4f25967e219d88a39c0123cb85d71a6eaecdc"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"cff87c050217569beb43ed00707149cbf7282c93","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        scheme \u003d \u0027http\u0027"},{"line_number":127,"context_line":"    if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":128,"context_line":"        params[\u0027token\u0027] \u003d context.auth_token"},{"line_number":129,"context_line":"    if CONF.glance_request_timeout is not None:"},{"line_number":130,"context_line":"        params[\u0027timeout\u0027] \u003d CONF.glance_request_timeout"},{"line_number":131,"context_line":"    endpoint \u003d \u0027%s://%s\u0027 % (scheme, netloc)"},{"line_number":132,"context_line":"    return glanceclient.Client(str(version), endpoint, **params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_41f40d87","line":129,"updated":"2014-06-09 10:23:49.000000000","message":"this could be if not CONF.glance_request_timeout:","commit_id":"ecf4f25967e219d88a39c0123cb85d71a6eaecdc"},{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"cff87c050217569beb43ed00707149cbf7282c93","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                  \"%(extra)s.\") % {\u0027netloc\u0027: netloc,"},{"line_number":220,"context_line":"                                                   \u0027method\u0027: method,"},{"line_number":221,"context_line":"                                                   \u0027extra\u0027: extra,"},{"line_number":222,"context_line":"                                                   }"},{"line_number":223,"context_line":"                    LOG.exception(error_msg)"},{"line_number":224,"context_line":"                    raise exception.GlanceConnectionFailed(reason\u003de)"},{"line_number":225,"context_line":"                LOG.exception(error_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9c19187c","line":222,"updated":"2014-06-09 10:23:49.000000000","message":"please change the above code (208-222) as follows:\n1. first identify the value for extra based on num_attempts\n2. assign value for the error_msg\n\nBecause the logic used for \u0027error_msg\u0027 is repeated.","commit_id":"ecf4f25967e219d88a39c0123cb85d71a6eaecdc"}],"nova/virt/hyperv/snapshotops.py":[{"author":{"_account_id":10487,"name":"Kanagaraj Manickam","email":"mkr1481@gmail.com","username":"kanagarajm"},"change_message_id":"cff87c050217569beb43ed00707149cbf7282c93","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _save_glance_image(self, context, name, image_vhd_path):"},{"line_number":40,"context_line":"        (glance_image_service,"},{"line_number":41,"context_line":"         image_id) \u003d glance.get_remote_image_service(context, name)"},{"line_number":42,"context_line":"        image_metadata \u003d {\"is_public\": \u0027False\u0027,"},{"line_number":43,"context_line":"                          \"disk_format\": \"vhd\","},{"line_number":44,"context_line":"                          \"container_format\": \"bare\","},{"line_number":45,"context_line":"                          \"properties\": {}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3c6724ec","line":42,"updated":"2014-06-09 10:23:49.000000000","message":"use doubld quotes to be in sync with other values in this dict","commit_id":"ecf4f25967e219d88a39c0123cb85d71a6eaecdc"}]}