)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f7569888ce2d0c720d7852654e5ae15a579a516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be361103_23f4dce3","updated":"2026-05-07 15:30:22.000000000","message":"easy peasy, thanks for the quickwin","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7df5a9e67be095e7daa7314cabf21ba6fefc4b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0b1ddf2_3c2aec78","updated":"2026-05-07 20:20:53.000000000","message":"recheck failed to install ceph","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d96b0a87529f047d3f563b3fa9522402304b3f53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80510935_40b69c1a","updated":"2026-05-07 17:46:24.000000000","message":"there are some things we can clean up but i agree the fix looks reasonable to me and i dont see anything that cant be adressed later\n\nmy only real ask is that we add a releaes note in the followup as well to advertise this since its a public security but i think it shoudl have one","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"}],"nova/compute/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f7569888ce2d0c720d7852654e5ae15a579a516","unresolved":false,"context_lines":[{"line_number":4320,"context_line":"            new_flavor \u003d current_flavor"},{"line_number":4321,"context_line":"        else:"},{"line_number":4322,"context_line":"            new_flavor \u003d flavors.get_flavor_by_flavor_id("},{"line_number":4323,"context_line":"                flavor_id, ctxt\u003dcontext, read_deleted\u003d\"no\")"},{"line_number":4324,"context_line":"            # NOTE(wenping): We use this instead of the \u0027block_accelerator\u0027"},{"line_number":4325,"context_line":"            # decorator since the operation can differ depending on args,"},{"line_number":4326,"context_line":"            # and for resize we have two flavors to worry about, we should"}],"source_content_type":"text/x-python","patch_set":1,"id":"84905bb0_7397de32","line":4323,"updated":"2026-05-07 15:30:22.000000000","message":"agreed with the fix","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"}],"nova/compute/flavors.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8ff385234486eabc3f638651f15dba81101f2b90","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    :raises: FlavorNotFound"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    if ctxt is None:"},{"line_number":137,"context_line":"        ctxt \u003d context.get_admin_context(read_deleted\u003dread_deleted)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    return objects.Flavor.get_by_flavor_id(ctxt, flavorid, read_deleted)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a389b0f3_85521d24","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":67},"updated":"2026-05-07 15:46:46.000000000","message":"In a follow up can we factor this branch away? All the non-test callers now pass a context explicitly so we can tighten up the code to prevent future bad usage of this call.","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d96b0a87529f047d3f563b3fa9522402304b3f53","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    :raises: FlavorNotFound"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    if ctxt is None:"},{"line_number":137,"context_line":"        ctxt \u003d context.get_admin_context(read_deleted\u003dread_deleted)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    return objects.Flavor.get_by_flavor_id(ctxt, flavorid, read_deleted)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"65b1150f_4a1e1b3f","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":67},"in_reply_to":"36af5a85_bf00c121","updated":"2026-05-07 17:46:24.000000000","message":"even if it was we could proably just have nova-mange create an admin context an dpass it but i agree that this can be adressed in a followup instead fo in this patch.","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"011c8c469fc2914b2157d289377a5534215fea99","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    :raises: FlavorNotFound"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    if ctxt is None:"},{"line_number":137,"context_line":"        ctxt \u003d context.get_admin_context(read_deleted\u003dread_deleted)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    return objects.Flavor.get_by_flavor_id(ctxt, flavorid, read_deleted)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"36af5a85_bf00c121","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":67},"in_reply_to":"a2c91444_11a139bb","updated":"2026-05-07 15:53:42.000000000","message":"It is not called from nova-manage or other CLI as far as I see","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"095ba25f185201cacb6724a362638e6b1e5d7479","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    :raises: FlavorNotFound"},{"line_number":135,"context_line":"    \"\"\""},{"line_number":136,"context_line":"    if ctxt is None:"},{"line_number":137,"context_line":"        ctxt \u003d context.get_admin_context(read_deleted\u003dread_deleted)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    return objects.Flavor.get_by_flavor_id(ctxt, flavorid, read_deleted)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a2c91444_11a139bb","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":67},"in_reply_to":"a389b0f3_85521d24","updated":"2026-05-07 15:49:23.000000000","message":"Yeah, might be good.. I was thinking this might be still called from nova-manage but I\u0027d have to go look (or maybe you know it\u0027s not).","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f7569888ce2d0c720d7852654e5ae15a579a516","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"            non_admin_api.post_server_action,"},{"line_number":2127,"context_line":"            server[\u0027id\u0027], resize_req)"},{"line_number":2128,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":2129,"context_line":""},{"line_number":2130,"context_line":"    def test_resize_delete_while_verify(self):"},{"line_number":2131,"context_line":"        \"\"\"Test scenario where the server is deleted while in the"},{"line_number":2132,"context_line":"        VERIFY_RESIZE state and ensures the allocations are properly"}],"source_content_type":"text/x-python","patch_set":1,"id":"00ccc64f_4ff2076e","line":2129,"updated":"2026-05-07 15:30:22.000000000","message":"awesome test","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d96b0a87529f047d3f563b3fa9522402304b3f53","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"            non_admin_api.post_server_action,"},{"line_number":2127,"context_line":"            server[\u0027id\u0027], resize_req)"},{"line_number":2128,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":2129,"context_line":""},{"line_number":2130,"context_line":"    def test_resize_delete_while_verify(self):"},{"line_number":2131,"context_line":"        \"\"\"Test scenario where the server is deleted while in the"},{"line_number":2132,"context_line":"        VERIFY_RESIZE state and ensures the allocations are properly"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bbf62b8_1e24eeda","line":2129,"in_reply_to":"00ccc64f_4ff2076e","updated":"2026-05-07 17:46:24.000000000","message":"my only nit is it should likely be in the regressiosn forlder or have a refence to the bug that its here to prevent regressing but i agree it repocuded the new expected behvior.","commit_id":"ef7ddda106e9f3c745043db96e4c76cc3b9ace2a"}]}
