)]}'
{"nova/image/__init__.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"ccdf31ffab1075e972c17ac34b594228f6fc3271","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    if \u0027/\u0027 not in str(image_href):"},{"line_number":45,"context_line":"        return (get_default_image_service(), image_href)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    else:"},{"line_number":48,"context_line":"        (glance_client, image_id) \u003d glance.get_glance_client(context,"},{"line_number":49,"context_line":"                                                             image_href)"},{"line_number":50,"context_line":"        image_service \u003d nova.image.glance.GlanceImageService(glance_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7iE%3D","line":47,"updated":"2011-10-20 18:13:03.000000000","message":"Do we need this \u0027else\u0027?","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6c0f7eda4445186a357b98ea90265b4c57eb2689","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    if \u0027/\u0027 not in str(image_href):"},{"line_number":45,"context_line":"        return (get_default_image_service(), image_href)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    else:"},{"line_number":48,"context_line":"        (glance_client, image_id) \u003d glance.get_glance_client(context,"},{"line_number":49,"context_line":"                                                             image_href)"},{"line_number":50,"context_line":"        image_service \u003d nova.image.glance.GlanceImageService(glance_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7hw%3D","line":47,"in_reply_to":"AAAACX%2F%2F7iE%3D","updated":"2011-10-20 18:28:20.000000000","message":"I think it\u0027s easier to read. We will never logically get to this block of code if the first conditional succeeds.","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"}],"nova/image/glance.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"ccdf31ffab1075e972c17ac34b594228f6fc3271","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                              glance_port)"},{"line_number":108,"context_line":"        return (glance_client, image_href)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    else:"},{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            (image_id, host, port) \u003d _parse_image_ref(image_href)"},{"line_number":113,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7iA%3D","line":110,"updated":"2011-10-20 18:13:03.000000000","message":"Do we need this \u0027else\u0027?","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6c0f7eda4445186a357b98ea90265b4c57eb2689","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                              glance_port)"},{"line_number":108,"context_line":"        return (glance_client, image_href)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    else:"},{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            (image_id, host, port) \u003d _parse_image_ref(image_href)"},{"line_number":113,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7ho%3D","line":110,"in_reply_to":"AAAACX%2F%2F7iA%3D","updated":"2011-10-20 18:28:20.000000000","message":"Same reasoning as the other \u0027else\u0027 you commented on","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"}],"nova/tests/image/test_s3.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"ccdf31ffab1075e972c17ac34b594228f6fc3271","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import stubout"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova import context"},{"line_number":21,"context_line":"import nova.db.api"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7h8%3D","line":18,"updated":"2011-10-20 18:13:03.000000000","message":"This doesn\u0027t seem to be used.","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6c0f7eda4445186a357b98ea90265b4c57eb2689","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import stubout"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova import context"},{"line_number":21,"context_line":"import nova.db.api"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7hk%3D","line":18,"in_reply_to":"AAAACX%2F%2F7h8%3D","updated":"2011-10-20 18:28:20.000000000","message":"It was temporarily, but not anymore. Good catch.","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"}],"nova/tests/test_image.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"ccdf31ffab1075e972c17ac34b594228f6fc3271","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.image_service.show(self.context, \u002734\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_create_rejects_duplicate_ids(self):"},{"line_number":96,"context_line":"        print self.image_service.create(self.context, {\u0027id\u0027: \u002734\u0027})"},{"line_number":97,"context_line":"        self.assertRaises(exception.Duplicate,"},{"line_number":98,"context_line":"                          self.image_service.create,"},{"line_number":99,"context_line":"                          self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7h4%3D","line":96,"updated":"2011-10-20 18:13:03.000000000","message":"Is this for debugging?","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6c0f7eda4445186a357b98ea90265b4c57eb2689","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.image_service.show(self.context, \u002734\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_create_rejects_duplicate_ids(self):"},{"line_number":96,"context_line":"        print self.image_service.create(self.context, {\u0027id\u0027: \u002734\u0027})"},{"line_number":97,"context_line":"        self.assertRaises(exception.Duplicate,"},{"line_number":98,"context_line":"                          self.image_service.create,"},{"line_number":99,"context_line":"                          self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F7hg%3D","line":96,"in_reply_to":"AAAACX%2F%2F7h4%3D","updated":"2011-10-20 18:28:20.000000000","message":"Yep, removed.","commit_id":"8254fa28f72df2d8c2386d66ac518aaede9e20ad"}]}
