)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3d2cf5b0141dd39b0bf434c7837458cbe91840d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32ab182c_8124877d","updated":"2026-05-19 16:29:33.000000000","message":"+1 but this shoudl be trivial to add a unit test for just to assert the secret is not in the warning","commit_id":"0a46ce217314ff1ccd887d216c48a889018020cd"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"bd500dc7ada41007a56bd58aea24f08c41b46506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d9e034d_a66abeec","updated":"2026-05-13 16:50:47.000000000","message":"LGTM, thanks Elod","commit_id":"0a46ce217314ff1ccd887d216c48a889018020cd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"131ca9c449426979295c5d0a7017eb8e99f0b291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ceb6c19e_88b39867","updated":"2026-05-21 02:08:30.000000000","message":"This LGTM, thanks","commit_id":"821f1e13ffeb2c4ccea74ff3fc98215ef16bc7ee"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fb1520c3e5bb2c05d88e29e46c06f8f231bbf749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38bc5da6_87c2452e","updated":"2026-05-21 02:03:30.000000000","message":"recheck https://review.opendev.org/c/openstack/tempest/+/938766 has merged","commit_id":"821f1e13ffeb2c4ccea74ff3fc98215ef16bc7ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbdbbc8e9232293904d8fdad58f5941f2e31dbdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f91f328a_7ac75f78","updated":"2026-05-20 13:08:49.000000000","message":"thanks","commit_id":"821f1e13ffeb2c4ccea74ff3fc98215ef16bc7ee"}],"nova/api/metadata/handler.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3d2cf5b0141dd39b0bf434c7837458cbe91840d","unresolved":true,"context_lines":[{"line_number":312,"context_line":"                             \u0027requestor_id\u0027: requestor_id,"},{"line_number":313,"context_line":"                             \u0027requestor_address\u0027: requestor_address})"},{"line_number":314,"context_line":"            msg \u003d _(\u0027Invalid proxy request signature.\u0027)"},{"line_number":315,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def _get_meta_by_instance_id(self, instance_id, tenant_id, remote_address):"},{"line_number":318,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f38305e_71f77ca3","line":315,"updated":"2026-05-19 16:29:33.000000000","message":"this really shoudl have a unit test to prevent regressing this.","commit_id":"0a46ce217314ff1ccd887d216c48a889018020cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbdbbc8e9232293904d8fdad58f5941f2e31dbdf","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                             \u0027requestor_id\u0027: requestor_id,"},{"line_number":313,"context_line":"                             \u0027requestor_address\u0027: requestor_address})"},{"line_number":314,"context_line":"            msg \u003d _(\u0027Invalid proxy request signature.\u0027)"},{"line_number":315,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def _get_meta_by_instance_id(self, instance_id, tenant_id, remote_address):"},{"line_number":318,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b88dbb2_10f06d7b","line":315,"in_reply_to":"2f38305e_71f77ca3","updated":"2026-05-20 13:08:49.000000000","message":"Done","commit_id":"0a46ce217314ff1ccd887d216c48a889018020cd"}],"releasenotes/notes/metadata-proxy-shared-secret-381e253a215e0f2c.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3d2cf5b0141dd39b0bf434c7837458cbe91840d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    anymore. In case of concerns regarding the logged signature, it is advised"},{"line_number":8,"context_line":"    to replace ``metadata_proxy_shared_secret`` in nova and neutron"},{"line_number":9,"context_line":"    configuration."},{"line_number":10,"context_line":"    See `bug #2150094`_ description for more details."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. _`bug #2150094`: https://bugs.launchpad.net/nova/+bug/2150094"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4a9f115e_bcd4df06","line":10,"updated":"2026-05-19 16:29:33.000000000","message":"the logs are generall consider prvialdges but we do treat logign fo secret as security harding opertunities\n\nso while this might be a littel over stated in that the metadata_proxy_shared_secret is not actully leaked to an non privdage context\nit does not hurt to rotate it if you are concerend.","commit_id":"0a46ce217314ff1ccd887d216c48a889018020cd"}]}