)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"47b4f171818a2e980f30dfec2b6fe7b47f1c0708","unresolved":true,"context_lines":[{"line_number":2551,"context_line":"                    return"},{"line_number":2552,"context_line":"                elif result \u003d\u003d build_results.RESCHEDULED:"},{"line_number":2553,"context_line":"                    self._build_failed(node)"},{"line_number":2554,"context_line":"                else:"},{"line_number":2555,"context_line":"                    self._build_succeeded(node)"},{"line_number":2556,"context_line":""},{"line_number":2557,"context_line":"        # NOTE(danms): We spawn here to return the RPC worker thread back to"}],"source_content_type":"text/x-python","patch_set":1,"id":"22e06232_df9c8662","line":2554,"range":{"start_line":2554,"start_character":16,"end_line":2554,"end_character":21},"updated":"2026-05-14 16:23:08.000000000","message":"I think I see an error here now:\n\nthe FAILED is actually a proper return value w/o an exception,\nso now if the result is FAILED, this _build_succeeded will be called, which is not good. Need to do smth like\n\nelif result !\u003d build_results.FAILED\n\ninstead here.","commit_id":"2771dff9eee2f321c376f07f18b98db0980501b7"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4cf256e3e9234b4df4f936297e9f21792b88e6ae","unresolved":false,"context_lines":[{"line_number":2551,"context_line":"                    return"},{"line_number":2552,"context_line":"                elif result \u003d\u003d build_results.RESCHEDULED:"},{"line_number":2553,"context_line":"                    self._build_failed(node)"},{"line_number":2554,"context_line":"                else:"},{"line_number":2555,"context_line":"                    self._build_succeeded(node)"},{"line_number":2556,"context_line":""},{"line_number":2557,"context_line":"        # NOTE(danms): We spawn here to return the RPC worker thread back to"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6bd11c8_4d623ef5","line":2554,"range":{"start_line":2554,"start_character":16,"end_line":2554,"end_character":21},"in_reply_to":"22e06232_df9c8662","updated":"2026-05-14 16:27:32.000000000","message":"Done","commit_id":"2771dff9eee2f321c376f07f18b98db0980501b7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9103de57d5ca1e91a0484517f2d4ae7fbd5d613","unresolved":false,"context_lines":[{"line_number":2545,"context_line":"                        self.reportclient.delete_allocation_for_instance("},{"line_number":2546,"context_line":"                            context, instance.uuid, force\u003dTrue)"},{"line_number":2547,"context_line":"                        self._build_failed(node)"},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":"                if result in (build_results.FAILED_BY_POLICY,"},{"line_number":2550,"context_line":"                              build_results.RESCHEDULED_BY_POLICY):"},{"line_number":2551,"context_line":"                    return"},{"line_number":2552,"context_line":"                elif result \u003d\u003d build_results.RESCHEDULED:"},{"line_number":2553,"context_line":"                    self._build_failed(node)"},{"line_number":2554,"context_line":"                else:"},{"line_number":2555,"context_line":"                    self._build_succeeded(node)"},{"line_number":2556,"context_line":""},{"line_number":2557,"context_line":"        # NOTE(danms): We spawn here to return the RPC worker thread back to"},{"line_number":2558,"context_line":"        # the pool. Since what follows could take a really long time, we don\u0027t"}],"source_content_type":"text/x-python","patch_set":1,"id":"3dc43609_48f5cf4f","line":2555,"range":{"start_line":2548,"start_character":1,"end_line":2555,"end_character":47},"updated":"2026-05-14 14:33:11.000000000","message":"Yeah, none of these will ever trigger in the failure path since we set `result \u003d build_results.FAILED`","commit_id":"2771dff9eee2f321c376f07f18b98db0980501b7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9282a2cbabd8fd4f5878789d90cbc0a312ffb9e","unresolved":true,"context_lines":[{"line_number":2545,"context_line":"                        self.reportclient.delete_allocation_for_instance("},{"line_number":2546,"context_line":"                            context, instance.uuid, force\u003dTrue)"},{"line_number":2547,"context_line":"                        self._build_failed(node)"},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":"                if result in (build_results.FAILED_BY_POLICY,"},{"line_number":2550,"context_line":"                              build_results.RESCHEDULED_BY_POLICY):"},{"line_number":2551,"context_line":"                    return"},{"line_number":2552,"context_line":"                elif result \u003d\u003d build_results.RESCHEDULED:"},{"line_number":2553,"context_line":"                    self._build_failed(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"02be9571_f1369fa9","line":2550,"range":{"start_line":2548,"start_character":1,"end_line":2550,"end_character":67},"updated":"2026-05-14 16:30:34.000000000","message":"Can you extend this tuple rather than changing the conditional below?","commit_id":"5585d14af0082123a6ea240de534e147b6e88188"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"deb21f3f6cb3b748301ad166743a2d6037ce5ff7","unresolved":false,"context_lines":[{"line_number":2545,"context_line":"                        self.reportclient.delete_allocation_for_instance("},{"line_number":2546,"context_line":"                            context, instance.uuid, force\u003dTrue)"},{"line_number":2547,"context_line":"                        self._build_failed(node)"},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":"                if result in (build_results.FAILED_BY_POLICY,"},{"line_number":2550,"context_line":"                              build_results.RESCHEDULED_BY_POLICY):"},{"line_number":2551,"context_line":"                    return"},{"line_number":2552,"context_line":"                elif result \u003d\u003d build_results.RESCHEDULED:"},{"line_number":2553,"context_line":"                    self._build_failed(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc5b1d7e_c2deab50","line":2550,"range":{"start_line":2548,"start_character":1,"end_line":2550,"end_character":67},"in_reply_to":"02be9571_f1369fa9","updated":"2026-05-15 10:48:05.000000000","message":"Indeed, thanks","commit_id":"5585d14af0082123a6ea240de534e147b6e88188"}]}