)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"14062ef77ba890f45b18964ac3cba9b2e8e65b53","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related to blueprint unpin-az"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Generated-By: Claude Opus 4.6"},{"line_number":15,"context_line":"Change-Id: I4278f6c43814ca620662b44cc4950467324211e2"},{"line_number":16,"context_line":"Signed-off-by: Dan Smith \u003cdansmith@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a9abe22_4f0d2b93","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"updated":"2026-06-12 16:59:35.000000000","message":"I think you should change it to Assisted-By now","commit_id":"8566da4291b4505c73562ebe184ff1bc007c68cf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd45dc740a9d9abc1dfad15540cb4320384c2a3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26a34c89_7637dc97","updated":"2026-06-11 01:55:00.000000000","message":"-1 for the need to update the api-ref. Also seems like there are unnecessary API samples added in here and we could easily avoid adding like 20 extra files.\n\nThe main change looks good to me ... I\u0027m a bit confused about many of the API samples additions.\n\nThe new microversion adds a new request parameter for the PUT /servers/{server_id} API but the response schemas are not changing, right? So I would have expected the only new samples we need are the one for the `server-update-req.json.tpl` and the generated `server-update-req.json`. Not any of the others.","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d84b598fad12145d0dc0b0c5d17cad1f4549c2b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef0ea1fd_29b85783","updated":"2026-06-09 14:52:45.000000000","message":"Note to reviewers: tempest tests here: https://review.opendev.org/c/openstack/tempest/+/992257","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"77f1cfc5863070225ae35a1bf4b63f60bba77372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57da9d46_1ef36ac5","updated":"2026-06-11 14:14:09.000000000","message":"I put the api-ref change in the next doc patch just to keep this one smaller, hope that\u0027s okay.","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"62994d5b4060bf60d9d672f73af88731346c5d04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73938781_e5cfc367","updated":"2026-06-11 17:11:03.000000000","message":"recheck ssh timeout","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6805ecfed9b530313a63c804c5b49a28d9e53683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d1577bfd_3d510ae4","updated":"2026-06-15 23:56:08.000000000","message":"This is much better with the API samples, LGTM.","commit_id":"4bb7256f60843a4de4cec39fddd9d30ad742283c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"621b8f945e08aede37f21716b822dbe17b68637a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c8bba940_7d5aff4b","updated":"2026-06-16 21:08:28.000000000","message":"recheck fixed by https://opendev.org/openstack/openstack-zuul-jobs/commit/e3089488531677ca6ed629db94aaeb47c88bac7e","commit_id":"4bb7256f60843a4de4cec39fddd9d30ad742283c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"531fe1a0cb3a458c009a5a62de28123649e89694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c235c5be_74548b50","updated":"2026-06-16 23:17:40.000000000","message":"recheck https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/993700 has merged","commit_id":"4bb7256f60843a4de4cec39fddd9d30ad742283c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"17f72e94a66b48b136bf5064fbbfabc46c503c5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d65782db_0629ee32","updated":"2026-06-16 15:05:21.000000000","message":"recheck unrelated","commit_id":"4bb7256f60843a4de4cec39fddd9d30ad742283c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"708715a7a5392fbc842df9169118ec57f7d4caa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7524996d_8c11f1cd","updated":"2026-06-12 23:07:52.000000000","message":"thanks for updates, lgtm","commit_id":"4bb7256f60843a4de4cec39fddd9d30ad742283c"}],"api-ref/source/servers.inc":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd45dc740a9d9abc1dfad15540cb4320384c2a3e","unresolved":true,"context_lines":[{"line_number":877,"context_line":"  - hostname: server_hostname_req"},{"line_number":878,"context_line":"  - OS-DCF:diskConfig: OS-DCF:diskConfig"},{"line_number":879,"context_line":"  - description: server_description"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":".. note::"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"   You can specify parameters to update independently."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"524640aa_a5c48363","line":880,"updated":"2026-06-11 01:55:00.000000000","message":"Need to add `pinned_availability_zone` to this list I think.","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6805ecfed9b530313a63c804c5b49a28d9e53683","unresolved":false,"context_lines":[{"line_number":877,"context_line":"  - hostname: server_hostname_req"},{"line_number":878,"context_line":"  - OS-DCF:diskConfig: OS-DCF:diskConfig"},{"line_number":879,"context_line":"  - description: server_description"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":".. note::"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"   You can specify parameters to update independently."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"2a352e48_9cf1983a","line":880,"in_reply_to":"40a805fc_da10abef","updated":"2026-06-15 23:56:08.000000000","message":"Done in https://review.opendev.org/c/openstack/nova/+/992469","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0e5a52f9a1d2af65648c1ef4728275de429f6e0b","unresolved":true,"context_lines":[{"line_number":877,"context_line":"  - hostname: server_hostname_req"},{"line_number":878,"context_line":"  - OS-DCF:diskConfig: OS-DCF:diskConfig"},{"line_number":879,"context_line":"  - description: server_description"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":".. note::"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"   You can specify parameters to update independently."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"40a805fc_da10abef","line":880,"in_reply_to":"524640aa_a5c48363","updated":"2026-06-11 13:39:35.000000000","message":"Ah, yes, thanks!","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd45dc740a9d9abc1dfad15540cb4320384c2a3e","unresolved":true,"context_lines":[{"line_number":887,"context_line":""},{"line_number":888,"context_line":".. literalinclude:: ../../doc/api_samples/servers/v2.63/server-update-req.json"},{"line_number":889,"context_line":"   :language: javascript"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"Response"},{"line_number":892,"context_line":"--------"},{"line_number":893,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"26a29f38_2dd01740","line":890,"updated":"2026-06-11 01:55:00.000000000","message":"And maybe a new example for 2.104 here.\n\nNote to self: I don\u0027t know why 2.63 was chosen for the request example given that there was no change to this API in 2.63 as far as I can tell.","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6805ecfed9b530313a63c804c5b49a28d9e53683","unresolved":false,"context_lines":[{"line_number":887,"context_line":""},{"line_number":888,"context_line":".. literalinclude:: ../../doc/api_samples/servers/v2.63/server-update-req.json"},{"line_number":889,"context_line":"   :language: javascript"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"Response"},{"line_number":892,"context_line":"--------"},{"line_number":893,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"e82320d1_467f5d37","line":890,"in_reply_to":"26a29f38_2dd01740","updated":"2026-06-15 23:56:08.000000000","message":"Done in https://review.opendev.org/c/openstack/nova/+/992469","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"}],"doc/api_samples/servers/v2.104/server-action-rebuild.json":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd45dc740a9d9abc1dfad15540cb4320384c2a3e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"user_data\": \"ZWNobyAiaGVsbG8gd29ybGQi\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"9a2359f1_59d3600d","line":15,"updated":"2026-06-11 01:55:00.000000000","message":"Do we really need to add samples for requests that are not changing as a result of the new microversion? Seems odd. Maybe I am missing something.","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6805ecfed9b530313a63c804c5b49a28d9e53683","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"user_data\": \"ZWNobyAiaGVsbG8gd29ybGQi\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"cb51eaa3_cd8600da","line":15,"in_reply_to":"1a0a4958_39127fc9","updated":"2026-06-15 23:56:08.000000000","message":"Done","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0e5a52f9a1d2af65648c1ef4728275de429f6e0b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"user_data\": \"ZWNobyAiaGVsbG8gd29ybGQi\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"a5dbd784_807f1c92","line":15,"in_reply_to":"9a2359f1_59d3600d","updated":"2026-06-11 13:39:35.000000000","message":"Seemed strange to me as well, but they\u0027re in the last few microversions\u0027 tests as well:\n\nhttps://github.com/openstack/nova/tree/master/doc/api_samples/servers/v2.98\n\nhttps://github.com/openstack/nova/tree/master/doc/api_samples/servers/v2.96\n\nhttps://github.com/openstack/nova/tree/master/doc/api_samples/servers/v2.94\n\n(and so on)\n\nThis commit by gmaan shows him fixing these for the last two:\n\nhttps://review.opendev.org/c/openstack/nova/+/942875\n\nWhich tells me that they\u0027re expected to be there :) I guess because server details is linked to rebuild now? I\u0027ll be honest and say that I was tickled that claude was able to just \"do\" the sample stuff for me. I saw this in the result and thought I had caught it doing something stupid, but they\u0027re in all the recent ones, so I assumed it was correct:\n```\n$ find . -name server-action-rebuild.json                               127 ↵  ✭bp/unpin-az\n./v2.100/server-action-rebuild.json\n./v2.47/server-action-rebuild.json\n./v2.71/server-action-rebuild.json\n./v2.98/server-action-rebuild.json\n./v2.54/server-action-rebuild.json\n./v2.96/server-action-rebuild.json\n./v2.90/server-action-rebuild.json\n./v2.63/server-action-rebuild.json\n./server-action-rebuild.json\n./v2.104/server-action-rebuild.json\n./v2.73/server-action-rebuild.json\n./v2.19/server-action-rebuild.json\n./v2.26/server-action-rebuild.json\n./v2.75/server-action-rebuild.json\n./v2.57/server-action-rebuild.json\n./v2.94/server-action-rebuild.json\n```\n\nTBH, I haven\u0027t added a microversion in a while so I don\u0027t even remember the process for generating them, so the \"just let claude do it\" approach seemed great once it appeared to work :)","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09a0adc8c4758124cb3d58d49f4a273cdc5df821","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        },"},{"line_number":13,"context_line":"        \"user_data\": \"ZWNobyAiaGVsbG8gd29ybGQi\""},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"1a0a4958_39127fc9","line":15,"in_reply_to":"a5dbd784_807f1c92","updated":"2026-06-11 19:07:39.000000000","message":"Those depend on how we are testing the new microversion change. If the other APIs (even if not changed) tests are running part of this microversion, then all the required sample files are expected to be present in that microversion dir. There are ways to use the common server schema present in \u0027functional/api_sample_tests/api_samples/servers\u0027 dir with use_common_server_api_samples otherwise we need to keep it in the new microversion dir.\n\nIn this case, you do not need to keep all of them if you do not run server get APIs test as part of this microversion tests. I commented it in https://review.opendev.org/c/openstack/nova/+/990682/3/nova/tests/functional/api_sample_tests/test_servers.py#749\n\nWe should improve it with fallback dir mechanism, but I thought of doing it in past but did not do. I will check it to make it better for future microversions.","commit_id":"598136032d0c2da482a6ed914c5ec6adb0815223"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09a0adc8c4758124cb3d58d49f4a273cdc5df821","unresolved":true,"context_lines":[{"line_number":746,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"class ServersSampleJson2104Test(ServersSampleJsonTest):"},{"line_number":750,"context_line":"    microversion \u003d \u00272.104\u0027"},{"line_number":751,"context_line":"    scenarios \u003d [(\u0027v2_104\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":752,"context_line":"    ADMIN_API \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"d3477acc_6bf22e68","line":749,"range":{"start_line":749,"start_character":32,"end_line":749,"end_character":53},"updated":"2026-06-11 19:07:39.000000000","message":"with this, you are running the server post/get tests also and that is why you need those API sample files too. if you drive it from ServersSampleBase then you will not need to do that.","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"909c6ae258641f984cee13fc191b46809dc5b79c","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"class ServersSampleJson2104Test(ServersSampleJsonTest):"},{"line_number":750,"context_line":"    microversion \u003d \u00272.104\u0027"},{"line_number":751,"context_line":"    scenarios \u003d [(\u0027v2_104\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":752,"context_line":"    ADMIN_API \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"9b982f5d_edb6c760","line":749,"range":{"start_line":749,"start_character":32,"end_line":749,"end_character":53},"in_reply_to":"d3477acc_6bf22e68","updated":"2026-06-12 14:25:57.000000000","message":"Done","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e72162344b7003f2bcef5f3950d438cae2e34f61","unresolved":true,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a022078_05092941","line":780,"updated":"2026-06-11 19:42:25.000000000","message":"I also notice we have some `ServersUpdateSampleJsonTest` and below here. So maybe it should go in this area and be named similarly with \"Update\" in the class name but still derive from `ServersSampleBase` or?","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"909c6ae258641f984cee13fc191b46809dc5b79c","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"c074d0ec_87407094","line":780,"in_reply_to":"28f120c0_94da5957","updated":"2026-06-12 14:25:57.000000000","message":"Done","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"10b0c0e821cc6a785193f2a772599e54df804167","unresolved":true,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"f7e22fa2_35b38f52","line":780,"in_reply_to":"31fa5ffe_9b637407","updated":"2026-06-12 17:02:10.000000000","message":"Yeah, these shouldn\u0027t be in here right:\n```\ndoc/api_samples/servers/v2.104/server-get-resp.json\ndoc/api_samples/servers/v2.104/servers-details-resp.json\ndoc/api_samples/servers/v2.104/servers-list-resp.json\nnova/tests/functional/api_sample_tests/api_samples/servers/v2.104/server-get-resp.json.tpl\nnova/tests/functional/api_sample_tests/api_samples/servers/v2.104/servers-details-resp.json.tpl\nnova/tests/functional/api_sample_tests/api_samples/servers/v2.104/servers-list-resp.json.tpl\n```\nSorry I didn\u0027t suggest `ServersUpdateSampleJsonTest` -- I was getting confused about which class should be inherited from 😓","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6805ecfed9b530313a63c804c5b49a28d9e53683","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"a72623f0_a4a90e89","line":780,"in_reply_to":"668d86ab_203df7bf","updated":"2026-06-15 23:56:08.000000000","message":"Done","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1aac8498c2b83e338901782c5fd10b45f1d2edde","unresolved":true,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"28f120c0_94da5957","line":780,"in_reply_to":"7a022078_05092941","updated":"2026-06-12 14:04:10.000000000","message":"Oh, I just saw this.. I guess I need to because these are here, but these are probably why I didn\u0027t find them as examples in the first place. I was searching through the file for `ServersSampleJson.*` and thus never hit those. But I guess since they\u0027re all there I better for consistency :(","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d43abf7bd9bafbd7e897422e5fe330a219a84630","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"31fa5ffe_9b637407","line":780,"in_reply_to":"c074d0ec_87407094","updated":"2026-06-12 16:51:45.000000000","message":"thanks for noticing it, I also forgot to check. so it can devried from ServersUpdateSampleJsonTest which will eliminate the need of server get schemas?","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"796b4db515e74aeeaac5ab48c3f7ed9ef44d9993","unresolved":true,"context_lines":[{"line_number":777,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":778,"context_line":"                                \u0027server-update-req\u0027, subs)"},{"line_number":779,"context_line":"        self._verify_response(\u0027server-update-resp\u0027, subs, response, 200)"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"class ServersUpdateSampleJson247Test(ServersUpdateSampleJsonTest):"},{"line_number":783,"context_line":"    microversion \u003d \u00272.47\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"668d86ab_203df7bf","line":780,"in_reply_to":"f7e22fa2_35b38f52","updated":"2026-06-12 17:08:51.000000000","message":"\u003e Yeah, these shouldn\u0027t be in here right:\n\u003e ```\n\u003e doc/api_samples/servers/v2.104/server-get-resp.json\n\u003e doc/api_samples/servers/v2.104/servers-details-resp.json\n\u003e doc/api_samples/servers/v2.104/servers-list-resp.json\n\u003e nova/tests/functional/api_sample_tests/api_samples/servers/v2.104/server-get-resp.json.tpl\n\u003e nova/tests/functional/api_sample_tests/api_samples/servers/v2.104/servers-details-resp.json.tpl\n\u003e nova/tests/functional/api_sample_tests/api_samples/servers/v2.104/servers-list-resp.json.tpl\n\u003e ```\n\nThese were my bad. I had initially changed this test to inherit, removed all but the update samples, then lost it in a rebase or something and added them back when the run complained. I think I must have changed the name of the test but didn\u0027t actually change the inheritance before I actually committed (or hit an errant ctrl-z at some point, idk).","commit_id":"db8eeed994e00d22c74f2942012c3510ca6cc607"}]}