)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"1ce2ccd1f121a05a2bfc4b1a2d68fbcbbc6fdb84","unresolved":true,"context_lines":[{"line_number":7778,"context_line":"        # the host/node set by the unshelve. See bug #2120927."},{"line_number":7779,"context_line":"        try:"},{"line_number":7780,"context_line":"            instance.save("},{"line_number":7781,"context_line":"                expected_task_state\u003dNone,"},{"line_number":7782,"context_line":"                expected_vm_state\u003d(vm_states.SHELVED_OFFLOADED,))"},{"line_number":7783,"context_line":"        except exception.InstanceUpdateConflict:"},{"line_number":7784,"context_line":"            LOG.info(\u0027Instance state changed during shelve offload, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"28cc9d8b_31da45b3","line":7781,"range":{"start_line":7781,"start_character":16,"end_line":7781,"end_character":41},"updated":"2026-09-07 11:57:20.000000000","message":"to catch in-progess unshelving this supposed to be `expected_task_state\u003d[None]`","commit_id":"b3a5608f71779e4d4162fd8114d85487c71e75ea"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"b2a01c61eb01a355ea9e670ea39556091c80c1f1","unresolved":true,"context_lines":[{"line_number":7778,"context_line":"        # the host/node set by the unshelve. See bug #2120927."},{"line_number":7779,"context_line":"        try:"},{"line_number":7780,"context_line":"            instance.save("},{"line_number":7781,"context_line":"                expected_task_state\u003dNone,"},{"line_number":7782,"context_line":"                expected_vm_state\u003d(vm_states.SHELVED_OFFLOADED,))"},{"line_number":7783,"context_line":"        except exception.InstanceUpdateConflict:"},{"line_number":7784,"context_line":"            LOG.info(\u0027Instance state changed during shelve offload, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb16c9da_64adf7ca","line":7781,"range":{"start_line":7781,"start_character":16,"end_line":7781,"end_character":41},"in_reply_to":"28cc9d8b_31da45b3","updated":"2026-09-21 09:46:08.000000000","message":"I changed the approach based on Gibi\u0027s comment. So that comment no longer applies..","commit_id":"b3a5608f71779e4d4162fd8114d85487c71e75ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96d3dfceae3a26a9d2665ec8d772e5af181ae5fd","unresolved":true,"context_lines":[{"line_number":7779,"context_line":"        try:"},{"line_number":7780,"context_line":"            instance.save("},{"line_number":7781,"context_line":"                expected_task_state\u003dNone,"},{"line_number":7782,"context_line":"                expected_vm_state\u003d(vm_states.SHELVED_OFFLOADED,))"},{"line_number":7783,"context_line":"        except exception.InstanceUpdateConflict:"},{"line_number":7784,"context_line":"            LOG.info(\u0027Instance state changed during shelve offload, \u0027"},{"line_number":7785,"context_line":"                     \u0027skipping host/node nil-out (likely unshelved \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5dd7443_f32efa0d","line":7782,"updated":"2026-08-26 14:28:36.000000000","message":"I feel like this is the wrong solution to abort the shelve_offload at this point due to a parallel unshelve happened in the meantime as this still allows to two instance action to execute in parallel. The unshelve and the shelve_offload up until this point. A much saver solution would be to avoid an intermittent instance state where the unshelve can start. I.e. we in case nova knows that a shelve is immediately followed by a shelve_offload it should not reset the task state of the instance and unshelve should check and reject if the task state is not None.","commit_id":"b3a5608f71779e4d4162fd8114d85487c71e75ea"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"b2a01c61eb01a355ea9e670ea39556091c80c1f1","unresolved":false,"context_lines":[{"line_number":7779,"context_line":"        try:"},{"line_number":7780,"context_line":"            instance.save("},{"line_number":7781,"context_line":"                expected_task_state\u003dNone,"},{"line_number":7782,"context_line":"                expected_vm_state\u003d(vm_states.SHELVED_OFFLOADED,))"},{"line_number":7783,"context_line":"        except exception.InstanceUpdateConflict:"},{"line_number":7784,"context_line":"            LOG.info(\u0027Instance state changed during shelve offload, \u0027"},{"line_number":7785,"context_line":"                     \u0027skipping host/node nil-out (likely unshelved \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"8af3368f_a2827c26","line":7782,"in_reply_to":"d5dd7443_f32efa0d","updated":"2026-09-21 09:46:08.000000000","message":"Done","commit_id":"b3a5608f71779e4d4162fd8114d85487c71e75ea"}]}