)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"edcba4b8e721d068eaa826af0d3a738869a6c9c0","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a resize fails in _cold_migrate(), the error"},{"line_number":10,"context_line":"notification was always sent with action \u0027migrate_server\u0027 regardless"},{"line_number":11,"context_line":"of whether the operation was a cold migrate or a resize"},{"line_number":12,"context_line":"Determine the action and operation label once from the flavor"},{"line_number":13,"context_line":"comparison before entering the try/except block, then use the"},{"line_number":14,"context_line":"correct action (\u0027resize_server\u0027 or \u0027migrate_server\u0027) consistently"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aabf1d56_1f97122b","line":11,"updated":"2026-06-04 15:22:32.000000000","message":"does this effect both legacy and versioned notifications?","commit_id":"aed11cbc13bd1b59e9b69f03d86a20fb8a3c52fe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"edcba4b8e721d068eaa826af0d3a738869a6c9c0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"comparison before entering the try/except block, then use the"},{"line_number":14,"context_line":"correct action (\u0027resize_server\u0027 or \u0027migrate_server\u0027) consistently"},{"line_number":15,"context_line":"across all three exception handlers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iae0d79d8e99a260ca081102c79d6ade2502a5c8e"},{"line_number":18,"context_line":"Signed-off-by: Kamil Sambor \u003ckamil.sambor@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7cd72d2e_9247c516","line":16,"updated":"2026-06-04 15:22:32.000000000","message":"Please add `Closes-Bug: #bugnumber`","commit_id":"aed11cbc13bd1b59e9b69f03d86a20fb8a3c52fe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d1242be30dc9ee14b7f4fdb98a9fb83f4cd6c29e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b2b7f79_b4919013","updated":"2026-06-08 08:36:55.000000000","message":"So this is a bit controversial.\n\nThe current resize code path emits resize notifications:\n        \u0027compute.instance.resize.end\u0027,\n        \u0027compute.instance.resize.error\u0027,\n        \u0027compute.instance.resize.prep.end\u0027,\n        \u0027compute.instance.resize.prep.start\u0027,\n        \u0027compute.instance.resize.revert.end\u0027,\n        \u0027compute.instance.resize.revert.start\u0027,\n        \u0027compute.instance.resize.start\u0027,\n\nExcept when the conductor task fails. As there is no \u0027compute_task.resize_server\u0027 notification type, both resize and cold_migrate goes out as \u0027compute_task.migrate_server\u0027.\n\nThis is true for both legacy and versioned notifications (the conductor task calls a single function to emit both notifications). So the bug report is valid https://bugs.launchpad.net/nova/+bug/2131879 This is pretty inconsistent.\n\nTechnically we could add a new \u0027compute_task.resize_server\u0027 legacy and versioned notifications and emit the correct one from the conductor.\n\nBUT:\n* the legacy notifications are deprecated and we said in the past we will not add new notification types to the legacy notifications. By this rule we should not add \u0027compute_task.resize_server\u0027 either.\n* if a notification consumer out there adapted to getting \u0027compute_task.migrate_server\u0027 during resize failure then switching the type breaks that consumer. But at the same time we say clients should not need to opt into API bugfixes. So if this is a bugfix then we can break them.\n* we can add a new versioned notification, that does not break any rules except the backward compatibility in the previous bullet point. However the code path is pretty common across both legacy and versioned notifications in this case so only adding this new to the versioned part creates code complexity.\n\nLets discuss this with the core team.","commit_id":"aed11cbc13bd1b59e9b69f03d86a20fb8a3c52fe"}],"nova/conductor/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"edcba4b8e721d068eaa826af0d3a738869a6c9c0","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                                          updates, ex, request_spec)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"            # if the flavor IDs match, it\u0027s migrate; otherwise resize"},{"line_number":430,"context_line":"            if op \u003d\u003d \u0027resize\u0027:"},{"line_number":431,"context_line":"                msg \u003d _(\"No valid host found for resize\")"},{"line_number":432,"context_line":"            else:"},{"line_number":433,"context_line":"                msg \u003d _(\"No valid host found for cold migrate\")"},{"line_number":434,"context_line":"            raise exception.NoValidHost(reason\u003dmsg)"},{"line_number":435,"context_line":"        except exception.UnsupportedPolicyException as ex:"},{"line_number":436,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":1,"id":"05a59b3f_4a44b91f","line":433,"range":{"start_line":430,"start_character":0,"end_line":433,"end_character":63},"updated":"2026-06-04 15:22:32.000000000","message":"This can be now simplified to not having an if:\n```\nmsg \u003d _(\"No valid host found for \" + op)\n```","commit_id":"aed11cbc13bd1b59e9b69f03d86a20fb8a3c52fe"}],"nova/rpc.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"edcba4b8e721d068eaa826af0d3a738869a6c9c0","unresolved":true,"context_lines":[{"line_number":367,"context_line":"        \u0027compute_task.build_instances\u0027,"},{"line_number":368,"context_line":"        \u0027compute_task.migrate_server\u0027,"},{"line_number":369,"context_line":"        \u0027compute_task.rebuild_server\u0027,"},{"line_number":370,"context_line":"        \u0027compute_task.resize_server\u0027,"},{"line_number":371,"context_line":"        \u0027HostAPI.power_action.end\u0027,"},{"line_number":372,"context_line":"        \u0027HostAPI.power_action.start\u0027,"},{"line_number":373,"context_line":"        \u0027HostAPI.set_enabled.end\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c7d0ebd_1c63596b","line":370,"updated":"2026-06-04 15:22:32.000000000","message":"I\u0027m very close to say that this is not something we do any more as per the comment above:\n\u003e    This list contains the already existing therefore allowed legacy\n\u003e    notification event_types. New items shall not be added to the list as\n\u003e    Nova does not allow new legacy notifications any more. This list will be\n\u003e    removed when all the notification is transformed to versioned\n\u003e    notifications.","commit_id":"aed11cbc13bd1b59e9b69f03d86a20fb8a3c52fe"}]}