)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b3a6fac2f74458d4e72622207d97b43c7dcadf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e72c38e_5a05837c","updated":"2026-06-11 09:56:26.000000000","message":"this is a good baseline\nit would be nice to adress some of the other edgcases as well if you have tiem to add tests for those","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"}],"nova/tests/functional/regressions/test_bug_1854844.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b3a6fac2f74458d4e72622207d97b43c7dcadf6","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        self.migrate_stub_ran \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_queue_size_preserved_with_different_host_settings(self):"},{"line_number":77,"context_line":"        \"\"\"Test that rx/tx queue_size from the source is preserved."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        The VM was booted on a source host with rx_queue_size\u003d1024."},{"line_number":80,"context_line":"        The destination host has rx_queue_size\u003d512 configured. During live"},{"line_number":81,"context_line":"        migration, the destination XML must still have rx_queue_size\u003d1024"},{"line_number":82,"context_line":"        to match the running VM\u0027s virtio device options."},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027auto\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # The fakelibvirt Domain.XMLDesc doesn\u0027t include \u003cdriver\u003e elements"}],"source_content_type":"text/x-python","patch_set":1,"id":"714c27a5_34ae775a","line":83,"range":{"start_line":77,"start_character":6,"end_line":83,"end_character":11},"updated":"2026-06-11 09:56:26.000000000","message":"nit your technially not checking the tx queue size in this test and they can have diffent values \n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#libvirt.rx_queue_size\nhttps://docs.openstack.org/nova/latest/configuration/config.html#libvirt.tx_queue_size\n\ntx_queue_size is only usabel with ovs-dpdk and vhost-user\n\nit would be nice ot add a second test for that.","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f1cfd6bcfd63915cb7e0e326a69cf02d9dec8ca5","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        self.migrate_stub_ran \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_queue_size_preserved_with_different_host_settings(self):"},{"line_number":77,"context_line":"        \"\"\"Test that rx/tx queue_size from the source is preserved."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        The VM was booted on a source host with rx_queue_size\u003d1024."},{"line_number":80,"context_line":"        The destination host has rx_queue_size\u003d512 configured. During live"},{"line_number":81,"context_line":"        migration, the destination XML must still have rx_queue_size\u003d1024"},{"line_number":82,"context_line":"        to match the running VM\u0027s virtio device options."},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027auto\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # The fakelibvirt Domain.XMLDesc doesn\u0027t include \u003cdriver\u003e elements"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d492a86_70263d2c","line":83,"range":{"start_line":77,"start_character":6,"end_line":83,"end_character":11},"in_reply_to":"714c27a5_34ae775a","updated":"2026-06-19 12:56:54.000000000","message":"I added only stubs for those cases now, I will fill them next week (I hope at least)","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9b05f3775a57a467758bbbd4e1935d7226d4caae","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        self.migrate_stub_ran \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_queue_size_preserved_with_different_host_settings(self):"},{"line_number":77,"context_line":"        \"\"\"Test that rx/tx queue_size from the source is preserved."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        The VM was booted on a source host with rx_queue_size\u003d1024."},{"line_number":80,"context_line":"        The destination host has rx_queue_size\u003d512 configured. During live"},{"line_number":81,"context_line":"        migration, the destination XML must still have rx_queue_size\u003d1024"},{"line_number":82,"context_line":"        to match the running VM\u0027s virtio device options."},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027auto\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # The fakelibvirt Domain.XMLDesc doesn\u0027t include \u003cdriver\u003e elements"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c7e5e89_e8c33e9e","line":83,"range":{"start_line":77,"start_character":6,"end_line":83,"end_character":11},"in_reply_to":"9d492a86_70263d2c","updated":"2026-06-23 17:07:55.000000000","message":"I added tests for tx_queue_size also to cover tha same scenarios with it","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ee2e8d3748706a59be725e4df21f0d4ef749e954","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        dom.XMLDesc \u003d _xml_desc_with_queue_size"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Change the config to simulate a destination host with a different"},{"line_number":111,"context_line":"        # rx_queue_size."},{"line_number":112,"context_line":"        self.flags(rx_queue_size\u003d512, group\u003d\u0027libvirt\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self._live_migrate(self.server, \u0027completed\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Verify the destination XML preserves the source\u0027s rx_queue_size"},{"line_number":117,"context_line":"        self.assertTrue(self.migrate_stub_ran)"}],"source_content_type":"text/x-python","patch_set":1,"id":"658f3392_4c2a499a","line":114,"range":{"start_line":110,"start_character":3,"end_line":114,"end_character":52},"updated":"2026-06-11 10:04:00.000000000","message":"thinking about this again this is not testing what you think its testing\n\n\nwhat this is actully testing is what happesn if you boot a vm with the config set to 1024\n\nthen restart the agent with it set to 512, the live migrate it\n\nthe destiation xml is genreated by the souce node using its config value not the value form the destiation host.\n\nwe do not have feild ot pass this info form the destiantion to the souce\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L39-L137\n\nso your test is nto invlaid, but the comment is misleading.\n\n\nhow this actully brakes on upgrade is you can live migrate away once, but once your on a host where the value ahs changed you cant live migrate back\n\nso your actully simulating the second live migation here not the first\n\nso you can boot with 1024 move to a host aht is configure for 512 but then you are stuck as the souce node will try to change it to 512 and that will fail.","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f1cfd6bcfd63915cb7e0e326a69cf02d9dec8ca5","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        dom.XMLDesc \u003d _xml_desc_with_queue_size"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Change the config to simulate a destination host with a different"},{"line_number":111,"context_line":"        # rx_queue_size."},{"line_number":112,"context_line":"        self.flags(rx_queue_size\u003d512, group\u003d\u0027libvirt\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self._live_migrate(self.server, \u0027completed\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Verify the destination XML preserves the source\u0027s rx_queue_size"},{"line_number":117,"context_line":"        self.assertTrue(self.migrate_stub_ran)"}],"source_content_type":"text/x-python","patch_set":1,"id":"399b3899_cc1895fc","line":114,"range":{"start_line":110,"start_character":3,"end_line":114,"end_character":52},"in_reply_to":"658f3392_4c2a499a","updated":"2026-06-19 12:56:54.000000000","message":"true, thanks. I updated now the comment to make it cleaner","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b3a6fac2f74458d4e72622207d97b43c7dcadf6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0efa5967_8cbc9e56","line":184,"updated":"2026-06-11 09:56:26.000000000","message":"it would be nice to also test that the queue size is not removed if the souce has it set and the dest had non although you could argue that is tested trasnstitivly vai the diffent size test bu the code paths may not be identical\n\nalso we dicsused the max queue count.\nhttps://docs.openstack.org/nova/latest/configuration/config.html#libvirt.max_queues\n\nit would be nice ot cover that as well\n\nthe same logic appliens in all 3 cases\n\nif a vm has any of these 3 values the value should not be updated.\nif the vm does not have any of thse 3 values they should not be added\n\nand ideally at some later point we can consider schduling on this in some way or a pre-live-migraiton check after the inital bug is fixed.","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f1cfd6bcfd63915cb7e0e326a69cf02d9dec8ca5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e835453_c59ded04","line":184,"in_reply_to":"0efa5967_8cbc9e56","updated":"2026-06-19 12:56:54.000000000","message":"max_queue is a really good idea, I added stubs now, will come back to these next week (see above 😉)","commit_id":"455ef1e8b4127d6839f7b624023327e998e92796"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9b05f3775a57a467758bbbd4e1935d7226d4caae","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        \"\"\""},{"line_number":221,"context_line":"        # TODO(lajoskatona) ...."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def test_mac_queue_not_added_when_source_has_none(self):"},{"line_number":224,"context_line":"        \"\"\"Test that max_queue is not added if the source doesn\u0027t have it."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        # TODO(lajoskatona) ...."}],"source_content_type":"text/x-python","patch_set":2,"id":"238a7fa4_ca2bf718","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":74},"updated":"2026-06-23 17:07:55.000000000","message":"If I understand well this is not adding coverage for this topic as the flavor will be the same on the src and on the dst host, so the queue size will remain the same with or without fix.","commit_id":"6f0958665c132e79aa27f767e7a5104db70dbf54"}]}