)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"7d63b71763430abe32394087a7f7546dd6196b50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix listing all tenants floatingip in nova-net"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When listiing floating-ips with \"--all-tenants\" pamameter in nova-network"},{"line_number":10,"context_line":"scenario, nova will raise an error for nova API need to get \u0027fixed_ip\u0027 in"},{"line_number":11,"context_line":"floatingip info, but \u0027fixed_ip\u0027 is not in floatingip\u0027s keys."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_32b7e4f6","line":9,"updated":"2014-06-11 15:56:44.000000000","message":"s/listiing/listing/","commit_id":"3b727b90e64b66b51a874443e57be07615c12693"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"443d8bd765d2923dc2fec5058a2baa5b4699c199","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix listing all tenants floatingip in nova-net"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When listiing floating-ips with \"--all-tenants\" pamameter in nova-network"},{"line_number":10,"context_line":"scenario, nova will raise an error for nova API need to get \u0027fixed_ip\u0027 in"},{"line_number":11,"context_line":"floatingip info, but \u0027fixed_ip\u0027 is not in floatingip\u0027s keys."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_1d3921f2","line":9,"updated":"2014-06-11 13:17:44.000000000","message":"s/pamameter/parameter/","commit_id":"3b727b90e64b66b51a874443e57be07615c12693"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"7d63b71763430abe32394087a7f7546dd6196b50","unresolved":false,"context_lines":[{"line_number":963,"context_line":"@require_admin_context"},{"line_number":964,"context_line":"def floating_ip_get_all_by_all_projects(context):"},{"line_number":965,"context_line":"    return _floating_ip_get_all(context).filter_by(auto_assigned\u003dFalse). \\"},{"line_number":966,"context_line":"        filter(models.FloatingIp.project_id !\u003d None). \\"},{"line_number":967,"context_line":"        options(joinedload_all(\u0027fixed_ip.instance\u0027)).all()"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_86c5dd8f","line":966,"updated":"2014-06-11 15:56:44.000000000","message":"There is another patch that enables a hacking check that would fail on this line:\nhttps://review.openstack.org/#/c/95215/\n\nThis should probably be:\n    filter(models.FloatingIp.project_id.isnot(None)). \\","commit_id":"3b727b90e64b66b51a874443e57be07615c12693"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"7d29c17661ec1a588bd38d692568e0381c273464","unresolved":false,"context_lines":[{"line_number":963,"context_line":"@require_admin_context"},{"line_number":964,"context_line":"def floating_ip_get_all_by_all_projects(context):"},{"line_number":965,"context_line":"    return _floating_ip_get_all(context).filter_by(auto_assigned\u003dFalse). \\"},{"line_number":966,"context_line":"        filter(models.FloatingIp.project_id !\u003d None). \\"},{"line_number":967,"context_line":"        options(joinedload_all(\u0027fixed_ip.instance\u0027)).all()"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_bac03d51","line":966,"updated":"2014-06-11 07:47:52.000000000","message":"why not project_id !\u003d None?","commit_id":"3b727b90e64b66b51a874443e57be07615c12693"},{"author":{"_account_id":10612,"name":"hzxiongwenwu","email":"xwwzzy@gmail.com","username":"hzxww"},"change_message_id":"6f57190cbc4e8cfaa6ba2bf66e8992771db20e7d","unresolved":false,"context_lines":[{"line_number":963,"context_line":"@require_admin_context"},{"line_number":964,"context_line":"def floating_ip_get_all_by_all_projects(context):"},{"line_number":965,"context_line":"    return _floating_ip_get_all(context).filter_by(auto_assigned\u003dFalse). \\"},{"line_number":966,"context_line":"        filter(models.FloatingIp.project_id !\u003d None). \\"},{"line_number":967,"context_line":"        options(joinedload_all(\u0027fixed_ip.instance\u0027)).all()"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_205fa042","line":966,"in_reply_to":"1ae5cdf2_45a11e93","updated":"2014-06-11 09:07:56.000000000","message":"that\u0027s right!","commit_id":"3b727b90e64b66b51a874443e57be07615c12693"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"ee36d5f184ebd369a0552b3cec77831c5258209d","unresolved":false,"context_lines":[{"line_number":963,"context_line":"@require_admin_context"},{"line_number":964,"context_line":"def floating_ip_get_all_by_all_projects(context):"},{"line_number":965,"context_line":"    return _floating_ip_get_all(context).filter_by(auto_assigned\u003dFalse). \\"},{"line_number":966,"context_line":"        filter(models.FloatingIp.project_id !\u003d None). \\"},{"line_number":967,"context_line":"        options(joinedload_all(\u0027fixed_ip.instance\u0027)).all()"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_45a11e93","line":966,"in_reply_to":"1ae5cdf2_bac03d51","updated":"2014-06-11 08:17:51.000000000","message":"In nova-network scenario, the floating_ips db table include the all floatingips of a floatingip pool(*.*.*.1~*.*.*.255), if just query all floatingips, will get the hundreds items, here use \"filter(models.FloatingIp.project_id !\u003d None)\" to select the all \"created\" (assigned to some projects) floatingips.","commit_id":"3b727b90e64b66b51a874443e57be07615c12693"}]}