)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d0ed87e31646eae19735c22d798fdfc19e4d015","unresolved":true,"context_lines":[{"line_number":9,"context_line":"get_diagnostics() and get_instance_diagnostics() walked the libvirt"},{"line_number":10,"context_line":"domain XML and immediately called .get(\u0027address\u0027) on the result of"},{"line_number":11,"context_line":"interface.find(\u0027mac\u0027). \u003cinterface type\u003d\u0027hostdev\u0027\u003e (used for PCI"},{"line_number":12,"context_line":"passthrough, including SR-IOV and DPDK) is not required to carry a"},{"line_number":13,"context_line":"\u003cmac\u003e child; for those instances the call raised"},{"line_number":14,"context_line":"AttributeError: \u0027NoneType\u0027 object has no attribute \u0027get\u0027, breaking"},{"line_number":15,"context_line":"the diagnostics API and any consumer (telemetry, monitoring) that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"23d787cc_07e2a308","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":38},"updated":"2026-06-17 20:20:04.000000000","message":"hostdev is not used for dpdk\n\nand we cant assuma all hostdevs have a mack in genreal.\n\n\u003cinterface type\u003d\u0027hostdev\u0027\u003e shoudl but \n\n\u003chostdev\u003e elemets that are used for geneic pci passthough cant be assuemd to be a nic and wont alwasy have them\n\nwe use the hostdev element for neutron PFs as well so even when it is a nic we cant assume it will have them\n\nDPDK usese `\u003cinterface type\u003d\u0027vhostuser\u0027\u003e`\n\n```\n  \u003cinterface type\u003d\u0027vhostuser\u0027\u003e\n    \u003cmac address\u003d\u002752:54:00:3b:83:1a\u0027/\u003e\n    \u003csource type\u003d\u0027unix\u0027 path\u003d\u0027/tmp/vhost1.sock\u0027 mode\u003d\u0027server\u0027/\u003e\n    \u003cmodel type\u003d\u0027virtio\u0027/\u003e\n  \u003c/interface\u003e\n```\n\nour normal host devs for VF tend to looks like this\n```\n  \u003cinterface type\u003d\u0027hostdev\u0027\u003e\n    \u003csource\u003e\n      \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x07\u0027 function\u003d\u00270x0\u0027/\u003e\n    \u003c/source\u003e\n    \u003cmac address\u003d\u002700:11:22:33:44:55\u0027/\u003e\n  \u003c/interface\u003e\n```\n\nwith a mac adress\n\nso im wondering how exactly you created a vm with interface hostdev that did not have a mac?","commit_id":"484e8de6f4e907811e4ee8e3ae6dca97fab591e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":39181,"name":"huangjs3","display_name":"huangjs3","email":"huangjs3@lenovo.com","username":"huangjs3"},"change_message_id":"a1e30a07c3ce9923d0e9be695c0f755433124540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e391260e_ace6c76d","updated":"2026-06-17 16:00:59.000000000","message":"recheck","commit_id":"484e8de6f4e907811e4ee8e3ae6dca97fab591e3"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0d0ed87e31646eae19735c22d798fdfc19e4d015","unresolved":true,"context_lines":[{"line_number":21272,"context_line":"    @mock.patch.object(host.Host, \u0027_get_domain\u0027)"},{"line_number":21273,"context_line":"    def test_diagnostic_hostdev_interface_without_mac("},{"line_number":21274,"context_line":"            self, mock_get_domain):"},{"line_number":21275,"context_line":"        \"\"\"Hostdev (PCI passthrough) \u003cinterface\u003e elements are not required"},{"line_number":21276,"context_line":"        to have a \u003cmac\u003e child. get_diagnostics() must not crash and must"},{"line_number":21277,"context_line":"        still record such NICs (with mac_address\u003dNone)."},{"line_number":21278,"context_line":"        \"\"\""},{"line_number":21279,"context_line":"        xml \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"233d464b_dbdfb567","line":21276,"range":{"start_line":21275,"start_character":11,"end_line":21276,"end_character":30},"updated":"2026-06-17 20:20:04.000000000","message":"while the mac is technially optional nova should alwasy set it to the mac of the neturon port.","commit_id":"484e8de6f4e907811e4ee8e3ae6dca97fab591e3"}]}