)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"427d02cba598264cd10e0d8b5996ecbeb9f4e5d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"367434fb_7e35f08c","updated":"2026-06-24 14:21:45.000000000","message":"I have only small things but the overall direction looks good to me","commit_id":"fc724a19a859a699012130772942dc982a410354"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"427d02cba598264cd10e0d8b5996ecbeb9f4e5d9","unresolved":true,"context_lines":[{"line_number":1177,"context_line":"                    instance.flavor, instance.image_meta,"},{"line_number":1178,"context_line":"                )"},{"line_number":1179,"context_line":"            except exception.FlavorImageConflict:"},{"line_number":1180,"context_line":"                continue"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"            if not mem_enc:"},{"line_number":1183,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"179967fe_57065fbf","line":1180,"updated":"2026-06-24 14:21:45.000000000","message":"yeah such VM should not exists in the first place as the VM scheduling should have been stopped with the same error. so we can skip the error here.","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b17c50e62732bf4aca7ebe01a112b632e868613e","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                    instance.flavor, instance.image_meta,"},{"line_number":1178,"context_line":"                )"},{"line_number":1179,"context_line":"            except exception.FlavorImageConflict:"},{"line_number":1180,"context_line":"                continue"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"            if not mem_enc:"},{"line_number":1183,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"ab361c47_7c75a03c","line":1180,"in_reply_to":"179967fe_57065fbf","updated":"2026-06-26 09:40:10.000000000","message":"Acknowledged","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"427d02cba598264cd10e0d8b5996ecbeb9f4e5d9","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"            if not mem_enc:"},{"line_number":1183,"context_line":"                continue"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"            if self.driver.is_supported_mem_encryption_model(mem_enc.model):"},{"line_number":1186,"context_line":"                continue"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":5,"id":"e79b6fc1_9801236f","line":1185,"updated":"2026-06-24 14:21:45.000000000","message":"As far as I see this is a cheap call, we return a cached boolean from the driver. So it fine to call it multiple times during startup.","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"427d02cba598264cd10e0d8b5996ecbeb9f4e5d9","unresolved":true,"context_lines":[{"line_number":1188,"context_line":"            msg \u003d _("},{"line_number":1189,"context_line":"                \u0027This host has instances with the memory encryption \u0027"},{"line_number":1190,"context_line":"                \u0027feature with %s enabled, but the host is not correctly \u0027"},{"line_number":1191,"context_line":"                \u0027configured.\u0027"},{"line_number":1192,"context_line":"            )"},{"line_number":1193,"context_line":"            raise exception.InvalidConfiguration(msg % mem_enc.model)"},{"line_number":1194,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f7382cf5_e58a8d99","line":1191,"updated":"2026-06-24 14:21:45.000000000","message":"1. I would be more specific. \"The host configured not to support the feature any more...\"\n\n   (We know that in the past the host supported the feature as VMs booted here)\n\n2. Also I would say the \"please move or delete these VMs before removing the feature support form the host. Note that you have to first restore the support for this feature to let nova-compute start up before you can move these VMs.\". to give help how to resolve the situation.\n\n3. If the user needs to (re)move these VMs then it might make sense to list all the VMs in the error message that requires this feature.","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b17c50e62732bf4aca7ebe01a112b632e868613e","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"            msg \u003d _("},{"line_number":1189,"context_line":"                \u0027This host has instances with the memory encryption \u0027"},{"line_number":1190,"context_line":"                \u0027feature with %s enabled, but the host is not correctly \u0027"},{"line_number":1191,"context_line":"                \u0027configured.\u0027"},{"line_number":1192,"context_line":"            )"},{"line_number":1193,"context_line":"            raise exception.InvalidConfiguration(msg % mem_enc.model)"},{"line_number":1194,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6317d621_1ac699fa","line":1191,"in_reply_to":"f7382cf5_e58a8d99","updated":"2026-06-26 09:40:10.000000000","message":"Mostly Done. The listing all instance uuids in the log can be done separately if we really want it.","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e99712c101e4928230707c1904c7cf884be0a25c","unresolved":true,"context_lines":[{"line_number":1188,"context_line":"            msg \u003d _("},{"line_number":1189,"context_line":"                \u0027This host has instances with the memory encryption \u0027"},{"line_number":1190,"context_line":"                \u0027feature with %s enabled, but the host is not correctly \u0027"},{"line_number":1191,"context_line":"                \u0027configured.\u0027"},{"line_number":1192,"context_line":"            )"},{"line_number":1193,"context_line":"            raise exception.InvalidConfiguration(msg % mem_enc.model)"},{"line_number":1194,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f4627fd8_b607e4db","line":1191,"in_reply_to":"f7382cf5_e58a8d99","updated":"2026-06-26 14:04:39.000000000","message":"Sorry I noticed my comment was not posted.\n\n\n\u003e 1. I would be more specific. \"The host configured not to support the feature any more...\"\n\nDone\n\n\u003e Also I would say the \"please move or delete these VMs before removing the feature support form the host. Note that you have to first restore the support for this feature to let nova-compute start up before you can move these VMs.\". to give help how to resolve the situation.\n\nI agree but I simplified the latter part because evacuating these instances from this host (without restoring the feature) is also an option.\n\n\u003e If the user needs to (re)move these VMs then it might make sense to list all the VMs in the error message that requires this feature.\n\nI prefer avoiding this now, because it may result in putting too many instances IDs in the log. Alternatively we can log the first instance id though that may not be quite useful in case there are multiple affected instances in the host.","commit_id":"fc724a19a859a699012130772942dc982a410354"}],"nova/tests/functional/libvirt/test_amd_sev.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"427d02cba598264cd10e0d8b5996ecbeb9f4e5d9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        mock_kernel \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":58,"context_line":"            side_effect\u003dmock_kernel)"},{"line_number":59,"context_line":"        mock_kernel.start()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.qemu_version \u003d versionutils.convert_version_to_int("},{"line_number":62,"context_line":"            host.MIN_QEMU_SEV_ES_VERSION)"}],"source_content_type":"text/x-python","patch_set":5,"id":"34cd1885_f07fa06c","line":59,"updated":"2026-06-24 14:21:45.000000000","message":"do we need to add a cleanup to remove this mock at the end of the test case?","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b17c50e62732bf4aca7ebe01a112b632e868613e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        mock_kernel \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":58,"context_line":"            side_effect\u003dmock_kernel)"},{"line_number":59,"context_line":"        mock_kernel.start()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.qemu_version \u003d versionutils.convert_version_to_int("},{"line_number":62,"context_line":"            host.MIN_QEMU_SEV_ES_VERSION)"}],"source_content_type":"text/x-python","patch_set":5,"id":"84704745_c4284f4a","line":59,"in_reply_to":"34cd1885_f07fa06c","updated":"2026-06-26 09:40:10.000000000","message":"Done","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e99712c101e4928230707c1904c7cf884be0a25c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        mock_kernel \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":58,"context_line":"            side_effect\u003dmock_kernel)"},{"line_number":59,"context_line":"        mock_kernel.start()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.qemu_version \u003d versionutils.convert_version_to_int("},{"line_number":62,"context_line":"            host.MIN_QEMU_SEV_ES_VERSION)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa585c5_4cae0037","line":59,"in_reply_to":"34cd1885_f07fa06c","updated":"2026-06-26 14:04:39.000000000","message":"Oh yes. We need to call stop. Fixed it.","commit_id":"fc724a19a859a699012130772942dc982a410354"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"427d02cba598264cd10e0d8b5996ecbeb9f4e5d9","unresolved":true,"context_lines":[{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":"    def test__validate_mem_encryption_configuration_supported(self):"},{"line_number":1883,"context_line":"        \"\"\"Test that the entire check is skipped if the driver supports"},{"line_number":1884,"context_line":"        amd-sev and amd-sev-es"},{"line_number":1885,"context_line":"        \"\"\""},{"line_number":1886,"context_line":"        self._test__validate_mem_encryption_configuration(True, True)"},{"line_number":1887,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"930090f7_5e5d63a1","line":1884,"updated":"2026-06-24 14:21:45.000000000","message":"hm that feels wrong. We don\u0027t have such a shortcut in the implementation. Maybe what you wanted to say here is that the check is passing as each feature is supported.","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b17c50e62732bf4aca7ebe01a112b632e868613e","unresolved":false,"context_lines":[{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":"    def test__validate_mem_encryption_configuration_supported(self):"},{"line_number":1883,"context_line":"        \"\"\"Test that the entire check is skipped if the driver supports"},{"line_number":1884,"context_line":"        amd-sev and amd-sev-es"},{"line_number":1885,"context_line":"        \"\"\""},{"line_number":1886,"context_line":"        self._test__validate_mem_encryption_configuration(True, True)"},{"line_number":1887,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"2dcb34c0_6335f7f4","line":1884,"in_reply_to":"930090f7_5e5d63a1","updated":"2026-06-26 09:40:10.000000000","message":"Done","commit_id":"fc724a19a859a699012130772942dc982a410354"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e99712c101e4928230707c1904c7cf884be0a25c","unresolved":false,"context_lines":[{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":"    def test__validate_mem_encryption_configuration_supported(self):"},{"line_number":1883,"context_line":"        \"\"\"Test that the entire check is skipped if the driver supports"},{"line_number":1884,"context_line":"        amd-sev and amd-sev-es"},{"line_number":1885,"context_line":"        \"\"\""},{"line_number":1886,"context_line":"        self._test__validate_mem_encryption_configuration(True, True)"},{"line_number":1887,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"344845ce_71fd83c0","line":1884,"in_reply_to":"930090f7_5e5d63a1","updated":"2026-06-26 14:04:39.000000000","message":"This was copied from vTPM but I should have updated it.","commit_id":"fc724a19a859a699012130772942dc982a410354"}]}