)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c438747715784508a469f8b7416f5dc4280cb08b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d49ad5d1_dca1f669","updated":"2026-06-24 14:03:16.000000000","message":"I have one question inline","commit_id":"b005628c0a2348620181f3690e4832ee1a43d170"}],"nova/tests/functional/regressions/test_bug_1928063.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c438747715784508a469f8b7416f5dc4280cb08b","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        super().setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":38,"context_line":"                        return_value\u003dTrue):"},{"line_number":39,"context_line":"            self.start_compute()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Create a SEV enabled image for the test"}],"source_content_type":"text/x-python","patch_set":1,"id":"64b913bf_46d722cd","line":38,"updated":"2026-06-24 14:03:16.000000000","message":"Hm, now one mock is covering the two calls form the baseline. The baseline returned true for sev and false for sev-es, in the other hand the current mock will return true for both calls (the two calls are differ in paramater value only)\n\nIs this now a different test case really?","commit_id":"b005628c0a2348620181f3690e4832ee1a43d170"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0fe3be3156c2f4649e93aeb98094d6f37d040e5","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        super().setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":38,"context_line":"                        return_value\u003dTrue):"},{"line_number":39,"context_line":"            self.start_compute()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Create a SEV enabled image for the test"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aef1a79_0f70cc08","line":38,"in_reply_to":"1b879019_879bf058","updated":"2026-06-24 15:25:36.000000000","message":"\u003e This case is expected to run tests with SEV enabled but SEV-ES disabled\n\nThis is not accurate, and the requirement in this case is just \"SEV is enabled\".\nSo we expect no problem when the minimum qemu version is bumped and the driver supports SEV-ES by default.","commit_id":"b005628c0a2348620181f3690e4832ee1a43d170"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"59492b32277e7117df9f60f2576fcbe883c9bf3d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super().setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":38,"context_line":"                        return_value\u003dTrue):"},{"line_number":39,"context_line":"            self.start_compute()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Create a SEV enabled image for the test"}],"source_content_type":"text/x-python","patch_set":1,"id":"58c761b9_5ed7ee34","line":38,"in_reply_to":"3aef1a79_0f70cc08","updated":"2026-06-24 15:40:42.000000000","message":"If the test case require only that SEV is supported and not sensitive at all for SEV-ES being supported then I\u0027m OK with this.","commit_id":"b005628c0a2348620181f3690e4832ee1a43d170"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a543d08ab43c3797cfea1d1ba55f9fcfee8d1c2","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        super().setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":38,"context_line":"                        return_value\u003dTrue):"},{"line_number":39,"context_line":"            self.start_compute()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Create a SEV enabled image for the test"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b879019_879bf058","line":38,"in_reply_to":"64b913bf_46d722cd","updated":"2026-06-24 15:16:45.000000000","message":"This effectively results in supports_amd_sev\u003dTrue and supports_amd_sev_es\u003dFalse, because the default QEMU version is below MIN_QEMU_SEV_ES_VERSION .\nThis case is expected to run tests with SEV enabled but SEV-ES disabled so this mocking is enough to simulate that condition.","commit_id":"b005628c0a2348620181f3690e4832ee1a43d170"}]}
