)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"62170dca5dd00da088079de79487bc545b1ab824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b24ec9a_3b8bca76","updated":"2026-06-24 03:07:53.000000000","message":"recheck","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dde869ad770860406138ae95441da5a784ffcff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aa71d01_9618a44b","updated":"2026-06-24 14:07:08.000000000","message":"similar question than in the parent patch","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"}],"nova/tests/functional/libvirt/test_reshape.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dde869ad770860406138ae95441da5a784ffcff8","unresolved":true,"context_lines":[{"line_number":290,"context_line":"            \u0027min_unit\u0027: 1,"},{"line_number":291,"context_line":"            \u0027reserved\u0027: 0,"},{"line_number":292,"context_line":"            \u0027step_size\u0027: 1,"},{"line_number":293,"context_line":"            \u0027total\u0027: 100}"},{"line_number":294,"context_line":"        self.placement.put("},{"line_number":295,"context_line":"            \u0027/resource_providers/%s/inventories\u0027 % compute_rp_uuid,"},{"line_number":296,"context_line":"            inventories)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c37d176_27328d26","line":293,"updated":"2026-06-24 14:07:08.000000000","message":"OK this is from _domain_capability_features_with_SEV_max_guests","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7b5c7b25183010619757d6c1020be372a93658dd","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027min_unit\u0027: 1,"},{"line_number":291,"context_line":"            \u0027reserved\u0027: 0,"},{"line_number":292,"context_line":"            \u0027step_size\u0027: 1,"},{"line_number":293,"context_line":"            \u0027total\u0027: 100}"},{"line_number":294,"context_line":"        self.placement.put("},{"line_number":295,"context_line":"            \u0027/resource_providers/%s/inventories\u0027 % compute_rp_uuid,"},{"line_number":296,"context_line":"            inventories)"}],"source_content_type":"text/x-python","patch_set":1,"id":"63a95e55_027d8b44","line":293,"in_reply_to":"9c37d176_27328d26","updated":"2026-06-24 15:43:09.000000000","message":"Done","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dde869ad770860406138ae95441da5a784ffcff8","unresolved":true,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # restart the compute service to trigger reshape"},{"line_number":318,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":319,"context_line":"                        return_value\u003dTrue):"},{"line_number":320,"context_line":"            self.compute \u003d self.restart_compute_service(self.hostname)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # verify that the inventory, usages and allocation are correct after"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5cdec30_4c49695d","line":319,"updated":"2026-06-24 14:07:08.000000000","message":"hm this now mean both SEV and SEV-ES is enable but the baseline only tested with SEV. Do we need two separate set of test cases one with SEV but without ES and one with both SEV an SEV-ES?","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7b5c7b25183010619757d6c1020be372a93658dd","unresolved":true,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # restart the compute service to trigger reshape"},{"line_number":318,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":319,"context_line":"                        return_value\u003dTrue):"},{"line_number":320,"context_line":"            self.compute \u003d self.restart_compute_service(self.hostname)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # verify that the inventory, usages and allocation are correct after"}],"source_content_type":"text/x-python","patch_set":1,"id":"408654d9_3f1fff97","line":319,"in_reply_to":"1e3d33e0_df401b3d","updated":"2026-06-24 15:43:09.000000000","message":"Can we do that change now to make this independent from the hard coded default QEMU version? We have the context now so it is better to fix it now than during the min version bump when this will suddently start failing.","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d00f9f01186e735e634416a5888e9370430d74c","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # restart the compute service to trigger reshape"},{"line_number":318,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":319,"context_line":"                        return_value\u003dTrue):"},{"line_number":320,"context_line":"            self.compute \u003d self.restart_compute_service(self.hostname)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # verify that the inventory, usages and allocation are correct after"}],"source_content_type":"text/x-python","patch_set":1,"id":"022bf580_d35f3ba3","line":319,"in_reply_to":"408654d9_3f1fff97","updated":"2026-06-24 16:05:11.000000000","message":"I\u0027ve updated the mock to simulate host with only AMD-SEV.","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c6afd98e1ab1ef79518adf43940f78cec75c346f","unresolved":true,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        # restart the compute service to trigger reshape"},{"line_number":318,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":319,"context_line":"                        return_value\u003dTrue):"},{"line_number":320,"context_line":"            self.compute \u003d self.restart_compute_service(self.hostname)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        # verify that the inventory, usages and allocation are correct after"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e3d33e0_df401b3d","line":319,"in_reply_to":"e5cdec30_4c49695d","updated":"2026-06-24 15:23:09.000000000","message":"We should not mock supports_amd_sev here because it is the trigger to detect max_sev_guests and max_sev_es_guests. That\u0027s why I needed to change how we mock Host class.\n\nThis is currently a handy way to simulate host with SEV enabled but SEV-ES disabled (thanks to default QEMU version lower than MIN_QEMU_SEV_ES_VERSION). Once qemu version is bumped we have to update this mock probably using side_effect so that it returns True for sev but False for the other mechanisms.","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dde869ad770860406138ae95441da5a784ffcff8","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        self.assertIn(os_traits.HW_CPU_X86_AMD_SEV, sev_traits)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # create a new server after reshape"},{"line_number":340,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":341,"context_line":"                        return_value\u003dTrue):"},{"line_number":342,"context_line":"            post_server \u003d self._create_server("},{"line_number":343,"context_line":"                image_uuid\u003duuidsentinel.mem_enc_image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"18a23bfc_71216ddc","line":340,"updated":"2026-06-24 14:07:08.000000000","message":"ditto","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8d00f9f01186e735e634416a5888e9370430d74c","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        self.assertIn(os_traits.HW_CPU_X86_AMD_SEV, sev_traits)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        # create a new server after reshape"},{"line_number":340,"context_line":"        with mock.patch(\u0027nova.virt.libvirt.host.Host._kernel_supports_amd_sev\u0027,"},{"line_number":341,"context_line":"                        return_value\u003dTrue):"},{"line_number":342,"context_line":"            post_server \u003d self._create_server("},{"line_number":343,"context_line":"                image_uuid\u003duuidsentinel.mem_enc_image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7ecd3a4_c280ff89","line":340,"in_reply_to":"18a23bfc_71216ddc","updated":"2026-06-24 16:05:11.000000000","message":"Done","commit_id":"3071348b6ddaf293e727b752c4963180f8bd2189"}]}