)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"096e60ed9a608b63992afdbe7e55c3007395adde","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Omit optional fields for SEV/SEV-ES"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt 6.9.0 introduced the internal logic[1] to set these options"},{"line_number":10,"context_line":"according to the values in domain capabilities, and these options"},{"line_number":11,"context_line":"have been optional since then."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1e1f6087_b1d1d994","line":9,"updated":"2026-06-26 09:20:15.000000000","message":"OK we require min 8.0.0 already","commit_id":"825ced40b118965f511d605da004684a17869987"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc2c12fde458c165dba99ef0b44b5b5ddc62528e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Libvirt 6.9.0 introduced the internal logic[1] to set these options"},{"line_number":10,"context_line":"according to the values in domain capabilities, and these options"},{"line_number":11,"context_line":"have been optional since then."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Remove these options so that we consistently omit these options for"},{"line_number":14,"context_line":"SEV/SEV-ES and SEV-SNP."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"6c34c3ba_1a04dc0b","line":11,"updated":"2026-07-16 10:43:02.000000000","message":"ok cool i remember thise being require but ya ou rmin libvirt is above that so we cna stop doing this ourselves","commit_id":"52c0473adb060b02fb219a62686f5076686dbcb1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"096e60ed9a608b63992afdbe7e55c3007395adde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"14afd522_36b9c17d","updated":"2026-06-26 09:20:15.000000000","message":"This looks like a good cleanup.","commit_id":"825ced40b118965f511d605da004684a17869987"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d2e158bbe34576219bc81d0da9fc6b40e3a5f265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"20d9faac_3f9bdc22","updated":"2026-07-02 23:20:57.000000000","message":"recheck","commit_id":"4fcb45410a091d6f754037754b6f9ac37385411b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"53b718c2ed107f1cbaf0617007b57310839908cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"56e08346_4aab0dbc","updated":"2026-07-16 13:44:55.000000000","message":"recheck","commit_id":"52c0473adb060b02fb219a62686f5076686dbcb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"04887f42bbc1c504fdb1f9ed0faf3525fe92bdef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7e8273b9_689fa3f2","updated":"2026-07-17 18:04:48.000000000","message":"recheck","commit_id":"52c0473adb060b02fb219a62686f5076686dbcb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aa95717cbfc92b5cc063da7f29f7556c0404c3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a8300ee6_8599f5f4","updated":"2026-07-17 15:37:33.000000000","message":"recheck","commit_id":"52c0473adb060b02fb219a62686f5076686dbcb1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3dd60f8074e5d6eaf89c55058dc7cd8f85e0313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b6c28da4_be20ba87","updated":"2026-07-17 13:19:26.000000000","message":"recheck","commit_id":"52c0473adb060b02fb219a62686f5076686dbcb1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"78c2028a8b7792926cbb04fa33d39bd733dad431","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4ac82d50_c013c5f9","updated":"2026-07-16 11:11:35.000000000","message":"recheck bug 2160901","commit_id":"52c0473adb060b02fb219a62686f5076686dbcb1"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3f3d319525a0b73ecfd06223846eaed2555b909b","unresolved":false,"context_lines":[{"line_number":2755,"context_line":""},{"line_number":2756,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":2757,"context_line":"        launch_security_expected \u003d \"\"\""},{"line_number":2758,"context_line":"            \u003claunchSecurity type\u003d\"sev-snp\" authorKey\u003d\"no\" vcek\u003d\"yes\" kernelHashes\u003d\"no\"\u003e"},{"line_number":2759,"context_line":"              \u003cpolicy\u003e0x00030000\u003c/policy\u003e"},{"line_number":2760,"context_line":"            \u003c/launchSecurity\u003e\"\"\""},{"line_number":2761,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"300e0fe2_3a38e379","line":2758,"updated":"2026-06-25 18:26:30.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"d9d9cbe73f462965f96cfe4fc562207bae263f80"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3f3d319525a0b73ecfd06223846eaed2555b909b","unresolved":false,"context_lines":[{"line_number":2765,"context_line":"        obj.kernelHashes \u003d True"},{"line_number":2766,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":2767,"context_line":"        launch_security_expected \u003d \"\"\""},{"line_number":2768,"context_line":"            \u003claunchSecurity type\u003d\"sev-snp\" authorKey\u003d\"no\" vcek\u003d\"yes\" kernelHashes\u003d\"yes\"\u003e"},{"line_number":2769,"context_line":"              \u003cpolicy\u003e0x00030000\u003c/policy\u003e"},{"line_number":2770,"context_line":"            \u003c/launchSecurity\u003e\"\"\""},{"line_number":2771,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9bb20828_a2e48f87","line":2768,"updated":"2026-06-25 18:26:30.000000000","message":"pep8: E501 line too long (88 \u003e 79 characters)","commit_id":"d9d9cbe73f462965f96cfe4fc562207bae263f80"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc2c12fde458c165dba99ef0b44b5b5ddc62528e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        super(LibvirtConfigDomainCapsFeatureSev, self).__init__("},{"line_number":361,"context_line":"            root_name\u003d\u0027sev\u0027, **kwargs)"},{"line_number":362,"context_line":"        self.supported \u003d False"},{"line_number":363,"context_line":"        self.cbitpos \u003d None"},{"line_number":364,"context_line":"        self.reduced_phys_bits \u003d None"},{"line_number":365,"context_line":"        self.max_guests \u003d None"},{"line_number":366,"context_line":"        self.max_es_guests \u003d None"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"a77eafe6_889aec09","side":"PARENT","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":37},"updated":"2026-07-16 10:43:02.000000000","message":"i proably would have kept this by the way in the case we need to configure this again in the fureu but since it now used any more i agree we can just clean up the now dead code its now hard to readded if we need too.","commit_id":"dcff75e9312d0c5335d986bdcd185f4743442890"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"096e60ed9a608b63992afdbe7e55c3007395adde","unresolved":false,"context_lines":[{"line_number":7830,"context_line":""},{"line_number":7831,"context_line":"    def _guest_configure_sev_mem_encryption("},{"line_number":7832,"context_line":"        self, guest, arch, mach_type, model):"},{"line_number":7833,"context_line":"        sev \u003d self._find_sev_feature(arch, mach_type)"},{"line_number":7834,"context_line":"        if sev is None:"},{"line_number":7835,"context_line":"            # In theory this should never happen because it should"},{"line_number":7836,"context_line":"            # only get called if SEV was requested, in which case the"}],"source_content_type":"text/x-python","patch_set":5,"id":"68b3a51f_465caf7d","line":7833,"updated":"2026-06-26 09:20:15.000000000","message":"it seem this `sev` variable is logically unused now for the XML generation. I guess the error handling still make sense here so let keep it as is.","commit_id":"825ced40b118965f511d605da004684a17869987"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bda099fc201954150a8637351fe4d38a116c7b11","unresolved":false,"context_lines":[{"line_number":7830,"context_line":""},{"line_number":7831,"context_line":"    def _guest_configure_sev_mem_encryption("},{"line_number":7832,"context_line":"        self, guest, arch, mach_type, model):"},{"line_number":7833,"context_line":"        sev \u003d self._find_sev_feature(arch, mach_type)"},{"line_number":7834,"context_line":"        if sev is None:"},{"line_number":7835,"context_line":"            # In theory this should never happen because it should"},{"line_number":7836,"context_line":"            # only get called if SEV was requested, in which case the"}],"source_content_type":"text/x-python","patch_set":5,"id":"8ba5c0e7_bd78635a","line":7833,"in_reply_to":"68b3a51f_465caf7d","updated":"2026-06-26 09:21:09.000000000","message":"Ohh it going away in the next patch. OK\u003e","commit_id":"825ced40b118965f511d605da004684a17869987"}]}
