)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bb17614934a7aa80b08daba36cfda64b2914f8dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16a74125_e577f8ae","updated":"2026-06-26 09:26:53.000000000","message":"OK. The compute startup check will cover cases when existing VMs requests non-existing features. In the other hand if this somehow happen during new VM creation then libvirt tell us that we asked for an impossible situation. So I\u0027m OK to land this simplification of error handling as it removes a good chunk of complexity.","commit_id":"9514a25008fe50e4023b1de40e75e8892448d818"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8539200ee09a9da822a087b968178cc03235b4d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e71e687_42ae3fd1","updated":"2026-06-27 17:12:22.000000000","message":"recheck","commit_id":"4c8e7f73977313671a626d834c332ea2308dd0e2"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"28d645dbc7c66d575a90d4e4ca39aaf539996c15","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"                               model\u003d\u0027amd-sev\u0027)"},{"line_number":4084,"context_line":""},{"line_number":4085,"context_line":"    def _setup_fake_domain_caps(self, fake_domain_caps):"},{"line_number":4086,"context_line":"        sev_feature \u003d vconfig.LibvirtConfigDomainCapsFeatureSev()"},{"line_number":4087,"context_line":"        domain_caps \u003d vconfig.LibvirtConfigDomainCaps()"},{"line_number":4088,"context_line":"        domain_caps._features \u003d vconfig.LibvirtConfigDomainCapsFeatures()"},{"line_number":4089,"context_line":"        domain_caps._features.features \u003d [sev_feature]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1def83fa_36bf0c5c","line":4086,"range":{"start_line":4086,"start_character":8,"end_line":4086,"end_character":65},"updated":"2026-06-26 15:22:24.000000000","message":"Noticed that this is no longer needed because it was required for sev capability check.","commit_id":"de3505b5c9ec4911f365f49ef9e1dbc5bdeaa1c3"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3295cac51f9dcb849ccd5afbf071c2cd14e96a44","unresolved":false,"context_lines":[{"line_number":7743,"context_line":"            self._guest_add_mdevs(guest, mdevs)"},{"line_number":7744,"context_line":""},{"line_number":7745,"context_line":"        if me_config:"},{"line_number":7746,"context_line":"            caps \u003d self._host.get_capabilities()"},{"line_number":7747,"context_line":"            self._guest_configure_mem_encryption(guest, me_config.model)"},{"line_number":7748,"context_line":""},{"line_number":7749,"context_line":"        if vpmems:"}],"source_content_type":"text/x-python","patch_set":3,"id":"e0d7ba6e_2aa9669e","line":7746,"updated":"2026-06-25 18:30:35.000000000","message":"pep8: F841 local variable \u0027caps\u0027 is assigned to but never used","commit_id":"f8b58c1eea8cf9af53d47fed90ec7c134f699beb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bb17614934a7aa80b08daba36cfda64b2914f8dc","unresolved":false,"context_lines":[{"line_number":7843,"context_line":"            # helpful error rather than something cryptic like"},{"line_number":7844,"context_line":"            # \"AttributeError: \u0027NoneType\u0027 object has no attribute \u0027cbitpos\u0027"},{"line_number":7845,"context_line":"            raise exception.MissingDomainCapabilityFeatureException("},{"line_number":7846,"context_line":"                feature\u003d\u0027sev\u0027)"},{"line_number":7847,"context_line":""},{"line_number":7848,"context_line":"        designer.set_driver_iommu_for_all_devices(guest)"},{"line_number":7849,"context_line":"        self._guest_add_sev_launch_security(guest, model)"}],"source_content_type":"text/x-python","patch_set":4,"id":"91375530_c3d2c4d6","side":"PARENT","line":7846,"updated":"2026-06-26 09:26:53.000000000","message":"I\u0027m OK to remove this check. If we still mess up and request a sev guest from libvirt in an incorrect config (machine type, etc) then libvirt will tell us that it is not possible and that will be enough.","commit_id":"825ced40b118965f511d605da004684a17869987"}]}