)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e614649961fbd2b78ad92619947c7d24eda22de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2185c62f_76663da6","updated":"2026-07-08 14:39:29.000000000","message":"recheck https://review.opendev.org/c/opendev/zuul-providers/+/996449","commit_id":"327b6fc329cc7eabd22690b7215904cecb313df7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0fa6c99b479200c291c9715f433bd14ab567c3dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2ad0a8fc_ac3c7b17","updated":"2026-07-09 09:48:38.000000000","message":"recheck","commit_id":"7b8945bea31bd7817c9d03065f6025b4a5a6c8cc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fa0e6196221ba619d7770f84d30b369123edc1f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"adac1c67_14d14d9d","updated":"2026-07-09 07:27:15.000000000","message":"recheck timeout","commit_id":"7b8945bea31bd7817c9d03065f6025b4a5a6c8cc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9cde39cbcccfb81cd4310b75ad697ee22fa1f5d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1991c761_ec066837","updated":"2026-07-13 16:01:45.000000000","message":"Looks good in theory. Have you checked this on a real hw? (I don\u0027t have access to such hw at the moment to try)","commit_id":"afd9e350fabad22b0ec5951c53473feba062475c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a0929dd25c530e98b1d742bcdf77d4f7e1b6819","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e1461ab5_0a7e4491","in_reply_to":"1991c761_ec066837","updated":"2026-07-13 17:19:35.000000000","message":"I\u0027ve not yet run this in an actual hw and I\u0027m afraid I lost access to my previous test env. I\u0027ve asked hiroki to try this in his set up if possible.\n\nThe domain capabilities example in test fixtures are based on the output you captured in the test env.","commit_id":"afd9e350fabad22b0ec5951c53473feba062475c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87da5ff2847523e9408b2d54c97d5cf76dba49a1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"73fdd866_3880dc49","in_reply_to":"e1461ab5_0a7e4491","updated":"2026-07-19 07:53:39.000000000","message":"@gibizer@gmail.com I was able to reinstall my local env. I tested this change and confirmed that capability detection works as expected. So I think we can merge this change.","commit_id":"afd9e350fabad22b0ec5951c53473feba062475c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9afe2cedbbe3bb46549da790ee90fbfa6b0ea901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7e1a282f_7bc34202","updated":"2026-07-20 14:06:18.000000000","message":"Thanks for the verification. Lets land this.","commit_id":"a3b0451b89f32543b8e5619afa0d611e642475e6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45334472096ef2c73a067b6312b5fb60a517564b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1476813f_04bcd773","updated":"2026-07-16 11:09:32.000000000","message":"i think gibi is hoppign to be able to test this again on real hardware before this merges i think this should work but we do not need to rush to mege this if we want to do more testing","commit_id":"a3b0451b89f32543b8e5619afa0d611e642475e6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2d1ced2d5aef6faf0301396492e16c46e490b4ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"eb1846b7_9ee6de4e","updated":"2026-07-20 14:17:51.000000000","message":"overlooked the whole series, thanks for the hard work","commit_id":"a3b0451b89f32543b8e5619afa0d611e642475e6"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45334472096ef2c73a067b6312b5fb60a517564b","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        if xmldoc.get(\u0027supported\u0027) \u003d\u003d \u0027yes\u0027:"},{"line_number":391,"context_line":"            self.supported \u003d True"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        for c in xmldoc:"},{"line_number":394,"context_line":"            if c.tag \u003d\u003d \u0027enum\u0027:"},{"line_number":395,"context_line":"                if c.get(\u0027name\u0027) \u003d\u003d \u0027sectype\u0027:"},{"line_number":396,"context_line":"                    self.sectypes \u003d ["},{"line_number":397,"context_line":"                        child.text for child in c if child.tag \u003d\u003d \u0027value\u0027]"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"class LibvirtConfigDomainCapsOS(LibvirtConfigObject):"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"10a0d6b2_ddc42bd4","line":398,"range":{"start_line":393,"start_character":1,"end_line":398,"end_character":1},"updated":"2026-07-16 11:09:32.000000000","message":"in thoery this should also work for intel tmx or whatever that is too i think so this will be useful for that work","commit_id":"a3b0451b89f32543b8e5619afa0d611e642475e6"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9cde39cbcccfb81cd4310b75ad697ee22fa1f5d7","unresolved":false,"context_lines":[{"line_number":2141,"context_line":"                LOG.debug(\"Checking SEV-SNP support for arch %s \""},{"line_number":2142,"context_line":"                          \"and machine type %s\", arch, machine_type)"},{"line_number":2143,"context_line":"                for feature in domain_caps[arch][machine_type].features:"},{"line_number":2144,"context_line":"                    feature_is_launch_security \u003d isinstance("},{"line_number":2145,"context_line":"                        feature,"},{"line_number":2146,"context_line":"                        vconfig.LibvirtConfigDomainCapsFeatureLaunchSecurity)"},{"line_number":2147,"context_line":"                    if feature_is_launch_security:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ba18db7_08010be4","line":2144,"updated":"2026-07-13 16:01:45.000000000","message":"Based on the commit message with \u003c 10.5 we don\u0027t have the lanuchSecurity tag expose. And that is correctly handled here as not having the sev-snp features available either.","commit_id":"afd9e350fabad22b0ec5951c53473feba062475c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a0929dd25c530e98b1d742bcdf77d4f7e1b6819","unresolved":false,"context_lines":[{"line_number":2141,"context_line":"                LOG.debug(\"Checking SEV-SNP support for arch %s \""},{"line_number":2142,"context_line":"                          \"and machine type %s\", arch, machine_type)"},{"line_number":2143,"context_line":"                for feature in domain_caps[arch][machine_type].features:"},{"line_number":2144,"context_line":"                    feature_is_launch_security \u003d isinstance("},{"line_number":2145,"context_line":"                        feature,"},{"line_number":2146,"context_line":"                        vconfig.LibvirtConfigDomainCapsFeatureLaunchSecurity)"},{"line_number":2147,"context_line":"                    if feature_is_launch_security:"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa575f7b_05bf39f5","line":2144,"in_reply_to":"1ba18db7_08010be4","updated":"2026-07-13 17:19:35.000000000","message":"Yes. https://review.opendev.org/c/openstack/nova/+/996316/12/nova/tests/unit/virt/libvirt/test_host.py#1019 is the corresponding test case, just fyi.","commit_id":"afd9e350fabad22b0ec5951c53473feba062475c"}]}
