)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a488fc335511227d95a446e786f173134322cd0f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"or an empty attachment list while the volume is being attached this"},{"line_number":41,"context_line":"patch is considered a backward compatible API change and therefore now"},{"line_number":42,"context_line":"new microversion is introduced."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: #2160224"},{"line_number":45,"context_line":"Change-Id: I372518bdaf83e89445f9b3174af8a3852fcd330b"},{"line_number":46,"context_line":"Signed-off-by: Balazs Gibizer \u003cgibi@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"44c5691b_4ad0d8b3","line":43,"updated":"2026-07-14 14:04:20.000000000","message":"the commit message i think captrues the reasoning well and the intended mechanics","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37b71bed053a37d47a41708f58ce668e7041c328","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4602366d_bf298220","updated":"2026-07-13 22:48:36.000000000","message":"I am ok with the change but -1 for the tests, we can add unit test to verify the 404 behavior if you do not want to handle that in regression test.\n\nFrom microvesion perspective, as discussed in the bug, i agree that this does not need microversion bump and can be fixed with bug fix - https://bugs.launchpad.net/nova/+bug/2160224","commit_id":"902bba61a508f443b00cb86df60f3f6449e6109b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c81676a19967b8edb5ba307bfe842e75d1b10f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d93a3f7_d63e80d6","updated":"2026-07-10 13:19:56.000000000","message":"recheck cover timeout","commit_id":"902bba61a508f443b00cb86df60f3f6449e6109b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d477aec91bd960540e152aa268ef7c9a61d597da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f942c652_6c9cbc88","updated":"2026-07-13 07:46:20.000000000","message":"recheck grenade neutron timeout","commit_id":"902bba61a508f443b00cb86df60f3f6449e6109b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a488fc335511227d95a446e786f173134322cd0f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96096f3d_65e01398","updated":"2026-07-14 14:04:20.000000000","message":"ill let gmaan comment on if they are happy with the increase leavel of testing\nbut i think this change looks correct to me over all.","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"df25ec8a4e0d10ed5e5c68fe6bfa84486c181e5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4ad6dfd_7740bd64","updated":"2026-07-16 07:01:21.000000000","message":"recheck \n```\n+ echo \u0027Timed out waiting for compute service on npde5d9b2495964 to be inactive (current: active)\u0027\n```","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"662ea5dcf761f1bd5a867b0cdfd91de8683c8bae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc544252_ac49f6be","updated":"2026-07-14 16:14:21.000000000","message":"recheck deployment failure:\n```2026-07-14 14:02:19.183629 | compute1 |   \"msg\": \"Warning: Permanently added \u002750.56.159.58\u0027 (ED25519) to the list of known hosts.\\r\\nrsync: [sender] link_stat \\\"/var/lib/zuul/builds/0b1a8397676f4029843146b89a6b5357/work/ca-bundle.pem\\\" failed: No such file or directory (2)\\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1347) [sender\u003d3.2.7]\\n\",\n```","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8705e61c74105ee80329239efab5e837867c6d62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0dc3a717_273cb38f","updated":"2026-07-15 14:48:26.000000000","message":"recheck nova-alt-configuration is fixed now","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"73e3d6fb5809212c70d1269929722db39af8d99f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72dec64c_2370d101","updated":"2026-07-16 09:32:29.000000000","message":"recheck tox cover test_schemas timeot","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72faee343f77730dc95234616794b8f16828b196","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fa859da_c8bc7d26","updated":"2026-07-14 18:13:55.000000000","message":"thanks. lgtm","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"}],"nova/api/openstack/compute/volume_attachments.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a488fc335511227d95a446e786f173134322cd0f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        show_attachment_id_bdm_uuid \u003d api_version_request.is_supported("},{"line_number":130,"context_line":"            req, \u00272.89\u0027)"},{"line_number":131,"context_line":"        for bdm in limited_list:"},{"line_number":132,"context_line":"            if not bdm.volume_id:"},{"line_number":133,"context_line":"                continue"},{"line_number":134,"context_line":"            if show_attachment_id_bdm_uuid and bdm.attachment_id is None:"},{"line_number":135,"context_line":"                continue"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            va \u003d _translate_attachment_detail_view("},{"line_number":138,"context_line":"                bdm,"}],"source_content_type":"text/x-python","patch_set":2,"id":"06b29da0_c4169777","line":135,"range":{"start_line":132,"start_character":1,"end_line":135,"end_character":24},"updated":"2026-07-14 14:04:20.000000000","message":"ack that works and is easy to follow","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a488fc335511227d95a446e786f173134322cd0f","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                \"Instance %(instance)s is not attached \""},{"line_number":184,"context_line":"                \"to volume %(volume)s\""},{"line_number":185,"context_line":"            ) % {\u0027instance\u0027: server_id, \u0027volume\u0027: volume_id}"},{"line_number":186,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        return {"},{"line_number":189,"context_line":"            \u0027volumeAttachment\u0027: _translate_attachment_detail_view("}],"source_content_type":"text/x-python","patch_set":2,"id":"d3ddf6d9_f3abfb3a","line":186,"updated":"2026-07-14 14:04:20.000000000","message":"ok an this makes it clear why we are returning the 404 even if the volume exsits","commit_id":"efc62cf9076866ffaa47b254b6a36ef7f790bf03"}],"nova/tests/functional/regressions/test_bug_2160224.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37b71bed053a37d47a41708f58ce668e7041c328","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        # Attach a volume and monitor the volume attachments. As above we"},{"line_number":53,"context_line":"        # injected a wait() into the attachment create in the cinder fixture"},{"line_number":54,"context_line":"        # the BDM will be created but the attachment_id will not be populated."},{"line_number":55,"context_line":"        # The API correctly filters the BDMs that has no attachment_id so the"},{"line_number":56,"context_line":"        # response schema is kept."},{"line_number":57,"context_line":"        self._attach_volume(server, volume_id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_attach_and_list_race(self):"},{"line_number":60,"context_line":"        volume_id \u003d self.cinder.IMAGE_BACKED_VOL"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f5b50ce_50f5ba23","line":57,"range":{"start_line":55,"start_character":2,"end_line":57,"end_character":46},"updated":"2026-07-13 22:48:36.000000000","message":"this is not actually testing if we are returning the 404 or not as it wait until attachment_id is not None https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L212\n\nI think we should test the both case here:\n- 404 case: we can call self.api.get_server_volume(server_id, volume_id) directly and see if we get 404 due to delay in attachment_create\n- 200 case: we can extend this test to assert that attachment_id is None (by setting  event.set()), so 200 is returned with a proper response.","commit_id":"902bba61a508f443b00cb86df60f3f6449e6109b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3a7d6b36d16045a4fb6c67ffd1716c0a85e7bf99","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        # Attach a volume and monitor the volume attachments. As above we"},{"line_number":53,"context_line":"        # injected a wait() into the attachment create in the cinder fixture"},{"line_number":54,"context_line":"        # the BDM will be created but the attachment_id will not be populated."},{"line_number":55,"context_line":"        # The API correctly filters the BDMs that has no attachment_id so the"},{"line_number":56,"context_line":"        # response schema is kept."},{"line_number":57,"context_line":"        self._attach_volume(server, volume_id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_attach_and_list_race(self):"},{"line_number":60,"context_line":"        volume_id \u003d self.cinder.IMAGE_BACKED_VOL"}],"source_content_type":"text/x-python","patch_set":1,"id":"a04db39b_e65eabd3","line":57,"range":{"start_line":55,"start_character":2,"end_line":57,"end_character":46},"in_reply_to":"0f5b50ce_50f5ba23","updated":"2026-07-14 12:39:55.000000000","message":"good point I will add unit test coverage...","commit_id":"902bba61a508f443b00cb86df60f3f6449e6109b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f1cf4f17beccfb22fd6ff58488a2c873b05af3f9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Attach a volume and monitor the volume attachments. As above we"},{"line_number":53,"context_line":"        # injected a wait() into the attachment create in the cinder fixture"},{"line_number":54,"context_line":"        # the BDM will be created but the attachment_id will not be populated."},{"line_number":55,"context_line":"        # The API correctly filters the BDMs that has no attachment_id so the"},{"line_number":56,"context_line":"        # response schema is kept."},{"line_number":57,"context_line":"        self._attach_volume(server, volume_id)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_attach_and_list_race(self):"},{"line_number":60,"context_line":"        volume_id \u003d self.cinder.IMAGE_BACKED_VOL"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ae08482_e9b3abb7","line":57,"range":{"start_line":55,"start_character":2,"end_line":57,"end_character":46},"in_reply_to":"a04db39b_e65eabd3","updated":"2026-07-14 13:52:21.000000000","message":"Added unit test coverage. \n\nThis functional test shows that we might or might not get a bunch of 404\u0027s and then we eventually get 200 (after 2 seconds) otherwise _attach_volume would not pass but raise AssertError.","commit_id":"902bba61a508f443b00cb86df60f3f6449e6109b"}]}