)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add --verbose to nova-manage commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add --verbose flag for the resto of nova-manage commands."},{"line_number":10,"context_line":"The flag is false by default and provides more information about"},{"line_number":11,"context_line":"the commands progress and elements it works with (example: migrations)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2d0f0d57_c59b04f8","line":9,"updated":"2026-08-10 11:44:39.000000000","message":"nit: rest of","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Add --verbose flag for the resto of nova-manage commands."},{"line_number":10,"context_line":"The flag is false by default and provides more information about"},{"line_number":11,"context_line":"the commands progress and elements it works with (example: migrations)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifbcdcd26822a6f579be8e8bf20fd533a015536cd"},{"line_number":14,"context_line":"Signed-off-by: Matěj Mudra \u003cmmudra@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"01b0ee05_f91b477f","line":12,"updated":"2026-08-10 11:44:39.000000000","message":"Could you elaborate why we need this? Reading the diff it seems like at least some part of the change is just there to add --verbose flag without providing any extra value. If this is just for completeness to have --verbose flag for every command then I don\u0027t think that is a worthy goal alone.","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a620ebf_a21543f5","updated":"2026-08-10 11:44:39.000000000","message":"I stopped reviewing before reaching the second half of the patch. Sorry but I need clear reasoning why we need this much of code? What is the goal we want to achieve here? Also secondarily it has 0 test changes so there might be broken format strings in the change.","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"}],"nova/cmd/manage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    def sync(self, version\u003dNone, local_cell\u003dFalse, verbose\u003dFalse):"},{"line_number":237,"context_line":"        \"\"\"Sync the database up to the most recent version.\"\"\""},{"line_number":238,"context_line":"        if verbose:"},{"line_number":239,"context_line":"            current_version \u003d migration.db_version()"},{"line_number":240,"context_line":"            target_version \u003d version if version else _(\u0027latest\u0027)"},{"line_number":241,"context_line":"            print(_(\u0027Migrating database from version: %(current)s to \u0027"},{"line_number":242,"context_line":"                    \u0027version: %(target)s\u0027) %"},{"line_number":243,"context_line":"                  {\u0027current\u0027: current_version, \u0027target\u0027: target_version})"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if not local_cell:"},{"line_number":246,"context_line":"            ctxt \u003d context.RequestContext()"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb5f493f_b847e739","line":243,"range":{"start_line":239,"start_character":0,"end_line":243,"end_character":73},"updated":"2026-08-10 11:44:39.000000000","message":"It feels like this will not consider the version of the actual DB the command syncs later. At L255 we target the context to cell0 so that will sync the cell0 DB and we should print the cell0 DB version.","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            print(_(\u0027Syncing main database...\u0027))"},{"line_number":280,"context_line":"        return migration.db_sync(version)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":283,"context_line":"          help\u003d\u0027Provide verbose output during execution.\u0027)"},{"line_number":284,"context_line":"    def version(self, verbose\u003dFalse):"},{"line_number":285,"context_line":"        \"\"\"Print the current database version.\"\"\""},{"line_number":286,"context_line":"        version \u003d migration.db_version()"},{"line_number":287,"context_line":"        if verbose:"},{"line_number":288,"context_line":"            print(_(\u0027Current database version: %s\u0027) % version)"},{"line_number":289,"context_line":"        else:"},{"line_number":290,"context_line":"            print(version)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @args(\u0027--max_rows\u0027, type\u003dint, metavar\u003d\u0027\u003cnumber\u003e\u0027, dest\u003d\u0027max_rows\u0027,"},{"line_number":293,"context_line":"          help\u003d\u0027Maximum number of deleted rows to archive per table. Defaults \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"73a2baf6_82da3bc3","line":290,"range":{"start_line":282,"start_character":0,"end_line":290,"end_character":26},"updated":"2026-08-10 11:44:39.000000000","message":"honestly this is very much just noise and code churn. I would not do that just for the sake of doing something.","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":595,"context_line":"            name \u003d migration_meth.__name__"},{"line_number":596,"context_line":"            try:"},{"line_number":597,"context_line":"                if verbose:"},{"line_number":598,"context_line":"                    print(_(\u0027Running migration: %s\u0027) % name)"},{"line_number":599,"context_line":"                found, done \u003d migration_meth(ctxt, count)"},{"line_number":600,"context_line":"            except Exception:"},{"line_number":601,"context_line":"                msg \u003d (_(\"Error attempting to run %(method)s\") % dict("}],"source_content_type":"text/x-python","patch_set":2,"id":"409db9e4_626eac93","line":598,"updated":"2026-08-10 11:44:39.000000000","message":"having a --verbose flag just for this is low ROI","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":733,"context_line":"                \"the instance uuid recorded on the Ironic node.\")"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        if verbose:"},{"line_number":736,"context_line":"            print(_(\u0027Updating compute node service mapping...\u0027))"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        target_compute_node.service_id \u003d destination_service.id"},{"line_number":739,"context_line":"        target_compute_node.host \u003d destination_service.host"}],"source_content_type":"text/x-python","patch_set":2,"id":"db3828e2_ea728766","line":736,"updated":"2026-08-10 11:44:39.000000000","message":"I think this single printout can contain all the information gathered above instead of having 3 lines of messages with fragments of data.","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e17e4f574f23bae91b0a3cb9786bf0348e8bbda4","unresolved":true,"context_lines":[{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        return migration.db_sync(version, database\u003d\u0027api\u0027)"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027verbose\u0027, default\u003dFalse,"},{"line_number":774,"context_line":"          help\u003d\u0027Provide verbose output during execution.\u0027)"},{"line_number":775,"context_line":"    def version(self, verbose\u003dFalse):"},{"line_number":776,"context_line":"        \"\"\"Print the current database version.\"\"\""},{"line_number":777,"context_line":"        version \u003d migration.db_version(database\u003d\u0027api\u0027)"},{"line_number":778,"context_line":"        if verbose:"},{"line_number":779,"context_line":"            print(_(\u0027Current API database version: %s\u0027) % version)"},{"line_number":780,"context_line":"        else:"},{"line_number":781,"context_line":"            print(version)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"class CellV2Commands(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"67526526_9fbe3523","line":781,"range":{"start_line":773,"start_character":0,"end_line":781,"end_character":26},"updated":"2026-08-10 11:44:39.000000000","message":"This is a very low value change","commit_id":"412ad078d6ddbf6ffc058b25ecd3a1467443968d"}]}