)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"cb20a38d3879ff49b33f0f3f74bbea9116ff40df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aca271de_1767aea1","updated":"2026-10-06 11:47:20.000000000","message":"GPT found an issue, I don\u0027t have enough JS knowledge to prove it correct or otherwise so I\u0027m not voting","commit_id":"f972a7a7605de7ed859aed15eba92561e06a79b1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9efca4c507413cc6bd651e1e0874157d7c9e9ae1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8bdb5934_d433236d","updated":"2026-10-07 08:20:23.000000000","message":"LGTM, but same as the previous commit, can you add a release note?","commit_id":"b3608290b7a0d5a3911083192db2dfdedbc67034"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"06b59009ebc83c38212d73b4e3c503ba450bc3d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a71c757_93f8af87","updated":"2026-10-06 13:58:03.000000000","message":"Looks good, thanks for fixing that issue!","commit_id":"b3608290b7a0d5a3911083192db2dfdedbc67034"},{"author":{"_account_id":38797,"name":"Eduardo Henrique Lima de Morais","display_name":"Eduardo Morais","email":"eduardo.henrique.lima.morais@gmail.com","username":"Eduardo-Morais"},"change_message_id":"0355eef58806b296d7d21a8b0658b5f5a9a70aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bff61e23_8b7ff7ab","in_reply_to":"8bdb5934_d433236d","updated":"2026-10-07 13:12:54.000000000","message":"Done","commit_id":"b3608290b7a0d5a3911083192db2dfdedbc67034"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"456a2508a88589834d4dd5064cf276f2fc4de613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25f8cdab_64b20a39","updated":"2026-10-07 13:53:46.000000000","message":"LGTM","commit_id":"31c07462ca6f5de1c1588590a7365cd8d81eb78b"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"a4851b7325d3478ada361044e89adcb03e536c25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3026f8f7_1cd94894","updated":"2026-10-08 07:59:18.000000000","message":"LGTM, thanks for making the fixes","commit_id":"31c07462ca6f5de1c1588590a7365cd8d81eb78b"}],"octavia_dashboard/static/dashboard/project/lbaasv2/workflow/model.service.js":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"cb20a38d3879ff49b33f0f3f74bbea9116ff40df","unresolved":true,"context_lines":[{"line_number":1032,"context_line":"      // This function is called if the key-manager service is not available. In that case we"},{"line_number":1033,"context_line":"      // cannot support the TERMINATED_HTTPS listener protocol so we hide the option if creating"},{"line_number":1034,"context_line":"      // a new load balancer or listener. However for editing we still need it."},{"line_number":1035,"context_line":"      var termHttpsIdx \u003d model.listenerProtocols.indexOf(\u0027TERMINATED_HTTPS\u0027);"},{"line_number":1036,"context_line":"      if (termHttpsIdx !\u003d\u003d -1) {"},{"line_number":1037,"context_line":"        model.listenerProtocols.splice(termHttpsIdx, 1);"},{"line_number":1038,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":1,"id":"ac2621c2_49bd3902","line":1035,"updated":"2026-10-06 11:47:20.000000000","message":"I\u0027ll admit I\u0027m no javascript expert but GPT found an issue here. Apparently TERMINATED_HTTPS will disappear as an option when editing a listener and it shouldn\u0027t\n\nIt suggested the fix below, I tested it in my env but I\u0027d recommend verifying it\n\n```suggestion\nvar termHttpsIdx \u003d model.listenerProtocols.indexOf(\u0027TERMINATED_HTTPS\u0027);\nif (!model.context.id \u0026\u0026 termHttpsIdx !\u003d\u003d -1) {\n  model.listenerProtocols.splice(termHttpsIdx, 1);\n}\n```","commit_id":"f972a7a7605de7ed859aed15eba92561e06a79b1"},{"author":{"_account_id":38797,"name":"Eduardo Henrique Lima de Morais","display_name":"Eduardo Morais","email":"eduardo.henrique.lima.morais@gmail.com","username":"Eduardo-Morais"},"change_message_id":"6960780d92b96abf69675488b2b35f1dd50310b4","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"      // This function is called if the key-manager service is not available. In that case we"},{"line_number":1033,"context_line":"      // cannot support the TERMINATED_HTTPS listener protocol so we hide the option if creating"},{"line_number":1034,"context_line":"      // a new load balancer or listener. However for editing we still need it."},{"line_number":1035,"context_line":"      var termHttpsIdx \u003d model.listenerProtocols.indexOf(\u0027TERMINATED_HTTPS\u0027);"},{"line_number":1036,"context_line":"      if (termHttpsIdx !\u003d\u003d -1) {"},{"line_number":1037,"context_line":"        model.listenerProtocols.splice(termHttpsIdx, 1);"},{"line_number":1038,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":1,"id":"14eadb7c_72ea634b","line":1035,"in_reply_to":"ac2621c2_49bd3902","updated":"2026-10-06 12:38:50.000000000","message":"Thanks for the review! You\u0027re totally right—we shouldn\u0027t just delete it, since the comment above the code states it still needs to be there. I\u0027ve updated the code accordingly.","commit_id":"f972a7a7605de7ed859aed15eba92561e06a79b1"}]}
