)]}'
{"octavia_dashboard/static/dashboard/project/lbaasv2/workflow/model.service.spec.js":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a8e82ad16839f876d06716de697faf3ed8215e36","unresolved":false,"context_lines":[{"line_number":350,"context_line":"              secret_ref: \u0027privatekey2\u0027"},{"line_number":351,"context_line":"            }, {"},{"line_number":352,"context_line":"              secret_ref: \u0027pkcs12\u0027,"},{"line_number":353,"context_line":"              secret_type: \u0027opaque\u0027"},{"line_number":354,"context_line":"            }"},{"line_number":355,"context_line":"          ];"},{"line_number":356,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3fa7e38b_84a1f0f9","line":353,"updated":"2019-10-11 23:15:02.000000000","message":"I think we were looking into making this a certificate type (I forget if it\u0027s \"certificate\" or \"x509\" or what in Barbican, but there is definitely a way to make this more specific than listing every single Barbican secret, and we should probably do that filtering.","commit_id":"acbaafbbce7c1f6e0323fd51c1476ab944d308cd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"eb81c5fa1ffca7b0a26d381e98d31c0b42a4ee59","unresolved":false,"context_lines":[{"line_number":350,"context_line":"              secret_ref: \u0027privatekey2\u0027"},{"line_number":351,"context_line":"            }, {"},{"line_number":352,"context_line":"              secret_ref: \u0027pkcs12\u0027,"},{"line_number":353,"context_line":"              secret_type: \u0027opaque\u0027"},{"line_number":354,"context_line":"            }"},{"line_number":355,"context_line":"          ];"},{"line_number":356,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"3fa7e38b_a856fa28","line":353,"in_reply_to":"3fa7e38b_84a1f0f9","updated":"2019-10-17 09:58:30.000000000","message":"Our user cookbooks do not mention/make use of secret types and the default type (opaque) while not encouraged it works. We should support until \"opaque\" until we decide to deprecate it and eventually drop support.\n\n\"Used for backwards compatibility with previous versions of the API without typed secrets. New applications are encouraged to specify one of the other secret types.\"\n\nhttps://docs.openstack.org/barbican/latest/api/reference/secret_types.html","commit_id":"acbaafbbce7c1f6e0323fd51c1476ab944d308cd"}]}