)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"feb1fa8689fea32f9e43fb054232028fcb5c1a00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b7fdfb0e_b8dbe9fd","updated":"2023-06-13 11:12:06.000000000","message":"this revision seems to resolve the bug.","commit_id":"deded30dd9eb3e5966bdbe986329915a3bd9429f"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"192954ce1edbe429a12f3fe03289ae66c1e057ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"25479514_b5db6c53","updated":"2023-06-22 13:23:39.000000000","message":"Could you add a release note too? I think it\u0027s important for the backports","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0b6281b979e7fadf03cfb981d7bc1677c5132a91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"77c3fd1d_49557803","updated":"2023-06-22 13:17:59.000000000","message":"tested locally, it works fine.\n-1 because I think we can remove a try/except block in the import section","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"04ca030d2f83be50e82e3ba1e8e54e7cb53326a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9b8c817e_1140737b","updated":"2023-06-28 16:32:31.000000000","message":"LGTM\nGreat to remove the barbicanclient dependency!","commit_id":"6fb6871ee0fe22b4e661edf8edc5a93129affa98"}],"octavia_dashboard/api/rest/barbican.py":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"4774277b900a3d24e43993639c788dcbb6a0fda5","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        The listing result is an object with property \"items\"."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        conn \u003d get_sdk_connection(request)"},{"line_number":57,"context_line":"        secrets \u003d list(conn.key_manager.secrets())"},{"line_number":58,"context_line":"        return {\u0027items\u0027: secrets}"}],"source_content_type":"text/x-python","patch_set":14,"id":"89d4e734_9a00b7c7","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":50},"updated":"2023-06-20 11:47:53.000000000","message":"OpenstackSDK seems to use pagination per default, but the list conversion will probably make it fetch all pages, which might slow down the request and increase memory consumption. Hence it might make sense to use list(c.key_manager.secrets(limit\u003d100, paginated\u003dFalse)) instead. Also, according to [1] the maximum limit value is 100. Opinions?\n\n[1]: https://docs.openstack.org/barbican/latest/api/reference/secrets.html","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0b6281b979e7fadf03cfb981d7bc1677c5132a91","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        The listing result is an object with property \"items\"."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        conn \u003d get_sdk_connection(request)"},{"line_number":57,"context_line":"        secrets \u003d list(conn.key_manager.secrets())"},{"line_number":58,"context_line":"        return {\u0027items\u0027: secrets}"}],"source_content_type":"text/x-python","patch_set":14,"id":"ec5ea779_29c99631","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":50},"in_reply_to":"89d4e734_9a00b7c7","updated":"2023-06-22 13:17:59.000000000","message":"we pull all the objects in our API calls in the dashboard (like the list of load balancers), so it is fine for me","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"04ca030d2f83be50e82e3ba1e8e54e7cb53326a3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        The listing result is an object with property \"items\"."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        conn \u003d get_sdk_connection(request)"},{"line_number":57,"context_line":"        secrets \u003d list(conn.key_manager.secrets())"},{"line_number":58,"context_line":"        return {\u0027items\u0027: secrets}"}],"source_content_type":"text/x-python","patch_set":14,"id":"ad8a8e48_43c705b2","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":50},"in_reply_to":"acfe22b9_f00287ca","updated":"2023-06-28 16:32:31.000000000","message":"Eventually barbican is supposed to add a content type for pkcs12 that would let us filter that better, but until then we should pull everything back or people won\u0027t be able to find their secrets.","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"2fae0fd66c10da0defb2e0a201f663915403f096","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        The listing result is an object with property \"items\"."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        conn \u003d get_sdk_connection(request)"},{"line_number":57,"context_line":"        secrets \u003d list(conn.key_manager.secrets())"},{"line_number":58,"context_line":"        return {\u0027items\u0027: secrets}"}],"source_content_type":"text/x-python","patch_set":14,"id":"acfe22b9_f00287ca","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":50},"in_reply_to":"ec5ea779_29c99631","updated":"2023-06-28 14:29:11.000000000","message":"Ack","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"}],"octavia_dashboard/sdk_connection.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0b6281b979e7fadf03cfb981d7bc1677c5132a91","unresolved":true,"context_lines":[{"line_number":18,"context_line":"try:"},{"line_number":19,"context_line":"    from openstack import config as occ"},{"line_number":20,"context_line":"except ImportError:"},{"line_number":21,"context_line":"    from os_client_config import config as occ"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def get_sdk_connection(request):"}],"source_content_type":"text/x-python","patch_set":14,"id":"56bbf4f0_852a0579","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":39},"updated":"2023-06-22 13:17:59.000000000","message":"it seems that it was a project that is deprecated and was replaced with openstacksdk\n(https://docs.openstack.org/os-client-config/latest/)\nI think we can safely remove the try/except block here","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"0021c240548f68658c481a04734ee051d5051e56","unresolved":false,"context_lines":[{"line_number":18,"context_line":"try:"},{"line_number":19,"context_line":"    from openstack import config as occ"},{"line_number":20,"context_line":"except ImportError:"},{"line_number":21,"context_line":"    from os_client_config import config as occ"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def get_sdk_connection(request):"}],"source_content_type":"text/x-python","patch_set":14,"id":"2b4789ca_d4e74bfa","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":39},"in_reply_to":"56bbf4f0_852a0579","updated":"2023-06-27 10:26:22.000000000","message":"Done","commit_id":"35c7b7f827d9bf6aa8c87dfabef53bd72580fd11"}]}