)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"c78a0923d70aa0684785d02e3d863601c76ad896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"42badc89_79a30557","updated":"2024-12-30 14:18:04.000000000","message":"Hi, could you add release notes as well please?","commit_id":"ebfea2065a4b40529c13f864e772323b0ae3ace3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"09c9f82e8dad8689b2809b9181c6ed6680336824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b38d282_91b647d7","in_reply_to":"42badc89_79a30557","updated":"2024-12-30 15:14:35.000000000","message":"Done","commit_id":"ebfea2065a4b40529c13f864e772323b0ae3ace3"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"41bd141001b13bac4faccf6ee0758e999787c290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4ccd10b_0eefa45b","updated":"2025-01-10 10:47:43.000000000","message":"I just tested the patch, when creating an Amphora LB with SOURCE_IP_PORT, it fails to create the pool but doesn\u0027t display an error (because the creation of the pool is triggered in a separate thread)\nit just leaves the LB with a listener and no pool\nso maybe we can leave it like this","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"26211b26e2dcfc24acfebcdb1cf4ae6141220844","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8eab9ef4_f558047b","updated":"2024-12-30 15:20:24.000000000","message":"LGTM in general. SOURCE_IP_PORT is supported by OVN, but not by Amphora, so this setting will cause an error with Amphora. I don\u0027t think that is a problem though.","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"09c9f82e8dad8689b2809b9181c6ed6680336824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be718b59_e2f533f1","updated":"2024-12-30 15:14:35.000000000","message":"thanks for review uploaded a new version","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4e245b7b558a6f43cefe3de4d885806084194935","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"38c7156c_c8921c2f","in_reply_to":"21271a13_fb85c513","updated":"2025-01-10 10:21:17.000000000","message":"sounds like it will be good improvement, thanks for review.","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ec5d6962d4391cf2fbe461e927def07a2beec548","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b11d7b05_58085bdc","in_reply_to":"8eab9ef4_f558047b","updated":"2024-12-30 20:36:06.000000000","message":"yes you are right. But we do not know what LB algorithm is supported unless we call octavia API as even with OVN amphora based LBs are still possible.","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"391dd9cfb6fca6f0f18fa7f032ae6fba9839961e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da254e2f_f8c516c0","in_reply_to":"b11d7b05_58085bdc","updated":"2024-12-30 20:38:33.000000000","message":"Done","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f710869b77cb8dc9b2dcf7998929ea05a0320ced","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21271a13_fb85c513","in_reply_to":"da254e2f_f8c516c0","updated":"2025-01-10 09:39:53.000000000","message":"I think there\u0027s a problem with it, the dashboard doesn\u0027t display the error of the API, so the user only gets a \"Error: Unable to create listener\" message, IMHO this is bad UX.\n\nwe need to fix https://bugs.launchpad.net/octavia/+bug/2013722 to make it usable","commit_id":"32a0c96dda5082e046ade3126a62554c35710d18"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ab3d0be790c7f8496658a56dd6d58844cc98df7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8049a27a_b72e9dfe","updated":"2025-04-15 09:00:43.000000000","message":"is this project dead?","commit_id":"c18b85cb73786f7bb9f41535aa77691063212e6c"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"af4edfec7cf0ed463df298d064f6a112bb5f05d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c14981a0_16299346","in_reply_to":"8049a27a_b72e9dfe","updated":"2025-04-15 09:05:39.000000000","message":"no it\u0027s not dead, there were some discussions on the IRC channel about this patch earlier this month.\n\nIMHO it should not be merged as is, because it works only with a specific (non-default) configuration of Octavia (default provider \u003d\u003d ovn)\nmost users will get an error when selecting this algo","commit_id":"c18b85cb73786f7bb9f41535aa77691063212e6c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ce37c544e7514fe34679eb3a6fac343353562ebb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"069facf9_6e4b0190","in_reply_to":"c14981a0_16299346","updated":"2025-04-15 12:28:02.000000000","message":"please feel free to pick up this work.","commit_id":"c18b85cb73786f7bb9f41535aa77691063212e6c"}]}