)]}'
{"id":"openstack%2Foctavia-lib~664510","triplet_id":"openstack%2Foctavia-lib~master~I29db66a282886ced2bd1bc1176f279728e5137e5","project":"openstack/octavia-lib","branch":"master","hashtags":[],"change_id":"I29db66a282886ced2bd1bc1176f279728e5137e5","subject":"Additional VIPs is also relevant in provider_base","status":"MERGED","created":"2019-06-11 07:33:26.000000000","updated":"2019-06-20 22:04:27.000000000","submitted":"2019-06-20 22:04:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"664510-1561068267254-d1910bce","meta_rev_id":"a71cc85430c089d1cff10d324f9b7227ce257942","_number":664510,"virtual_id_number":664510,"owner":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":2,"date":"2019-06-20 22:04:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":2,"date":"2019-06-20 21:50:08.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":2,"date":"2019-06-20 21:31:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":1,"date":"2019-06-20 21:50:08.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"rejected":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":-2,"date":"2019-06-20 21:50:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-11 13:02:51.000000000","updated_by":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"reviewer":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"state":"REVIEWER"},{"updated":"2019-06-20 21:31:24.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-06-20 21:50:08.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2019-06-20 22:04:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"377b995e939731df4a2df526a40b3c9f07e3bcff","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-06-11 07:33:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5936b98b2868b3fa8ef7b35f2dfd99a9f3b64593","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 08:15:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/10/664510/1/check/openstack-tox-cover/8dc2b21/ : FAILURE in 4m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/664510/1/check/openstack-tox-lower-constraints/4efae4b/ : FAILURE in 4m 52s\n- openstack-tox-pep8 http://logs.openstack.org/10/664510/1/check/openstack-tox-pep8/ca1064a/ : SUCCESS in 4m 39s\n- openstack-tox-py27 http://logs.openstack.org/10/664510/1/check/openstack-tox-py27/44b2c37/ : FAILURE in 4m 06s\n- openstack-tox-py36 http://logs.openstack.org/10/664510/1/check/openstack-tox-py36/8ec1e27/ : FAILURE in 4m 48s\n- openstack-tox-py37 http://logs.openstack.org/10/664510/1/check/openstack-tox-py37/508dfd7/ : FAILURE in 4m 24s\n- openstack-tox-docs http://logs.openstack.org/10/664510/1/check/openstack-tox-docs/8b400a3/html/ : SUCCESS in 3m 50s","accounts_in_message":[],"_revision_number":1},{"id":"08ff439e8c0b798b699b98662fc476653efbd98d","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-06-11 08:43:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b205aec90b0e1aa36ffaab7a940c773664579fc1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-11 09:20:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/10/664510/2/check/openstack-tox-cover/d223d0d/cover/ : SUCCESS in 4m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/664510/2/check/openstack-tox-lower-constraints/a501b92/ : SUCCESS in 5m 54s\n- openstack-tox-pep8 http://logs.openstack.org/10/664510/2/check/openstack-tox-pep8/2e89bef/ : SUCCESS in 3m 56s\n- openstack-tox-py27 http://logs.openstack.org/10/664510/2/check/openstack-tox-py27/a98860f/ : SUCCESS in 3m 53s\n- openstack-tox-py36 http://logs.openstack.org/10/664510/2/check/openstack-tox-py36/58c7ed6/ : SUCCESS in 4m 37s\n- openstack-tox-py37 http://logs.openstack.org/10/664510/2/check/openstack-tox-py37/618e100/ : SUCCESS in 4m 49s\n- openstack-tox-docs http://logs.openstack.org/10/664510/2/check/openstack-tox-docs/ff18ffb/html/ : SUCCESS in 4m 50s","accounts_in_message":[],"_revision_number":2},{"id":"707d144eaf939e29e439e76f9d5c399b481d2dd2","author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"date":"2019-06-11 13:02:51.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b49212b765696c45d5c090cd95c995dac9827540","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-06-15 00:28:20.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d2c5968cea1b5f71b19f962e1489e2f26dccaf67","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-06-18 09:31:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ca5fededa3912132ad498a92c6a4c25eec049bf4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 09:55:13.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/10/664510/3/check/openstack-tox-cover/16d1c98/cover/ : SUCCESS in 4m 41s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/664510/3/check/openstack-tox-lower-constraints/2789e1c/ : SUCCESS in 4m 29s\n- openstack-tox-pep8 http://logs.openstack.org/10/664510/3/check/openstack-tox-pep8/8319bd5/ : SUCCESS in 4m 11s\n- openstack-tox-py27 http://logs.openstack.org/10/664510/3/check/openstack-tox-py27/9220fc7/ : SUCCESS in 4m 29s\n- openstack-tox-py36 http://logs.openstack.org/10/664510/3/check/openstack-tox-py36/8c79c27/ : SUCCESS in 4m 19s\n- openstack-tox-py37 http://logs.openstack.org/10/664510/3/check/openstack-tox-py37/2c78c00/ : SUCCESS in 5m 25s\n- openstack-tox-docs http://logs.openstack.org/10/664510/3/check/openstack-tox-docs/498b059/html/ : SUCCESS in 4m 08s","accounts_in_message":[],"_revision_number":3},{"id":"f380666c8c810f331573ec890e798705d1d20d36","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-06-20 21:31:24.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":3},{"id":"72d496d644744ef8b60466a1dbe9971d7098c650","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-06-20 21:50:08.000000000","message":"Patch Set 3: Backport-Candidate-2 Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"f83ff4617b07b6a517e7a434a0d15adc565485cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 21:50:19.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"48802e78ed7343f5a5901bdefe64b5cd5011a459","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 22:04:27.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/10/664510/3/gate/openstack-tox-lower-constraints/5b00a16/ : SUCCESS in 4m 14s\n- openstack-tox-pep8 http://logs.openstack.org/10/664510/3/gate/openstack-tox-pep8/171447e/ : SUCCESS in 3m 57s\n- openstack-tox-py27 http://logs.openstack.org/10/664510/3/gate/openstack-tox-py27/b858916/ : SUCCESS in 4m 58s\n- openstack-tox-py36 http://logs.openstack.org/10/664510/3/gate/openstack-tox-py36/bd741be/ : SUCCESS in 4m 03s\n- openstack-tox-py37 http://logs.openstack.org/10/664510/3/gate/openstack-tox-py37/5c543c7/ : SUCCESS in 4m 26s\n- openstack-tox-docs http://logs.openstack.org/10/664510/3/gate/openstack-tox-docs/e6a3390/html/ : SUCCESS in 3m 50s","accounts_in_message":[],"_revision_number":3},{"id":"a71cc85430c089d1cff10d324f9b7227ce257942","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 22:04:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"79848fe84aa4363916f7028b1bfe0355e8117bb7","revisions":{"4c5be4f67b7cd7023cf955e5bc2ec465c26f8d31":{"kind":"REWORK","_number":1,"created":"2019-06-11 07:33:26.000000000","uploader":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"ref":"refs/changes/10/664510/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia-lib","ref":"refs/changes/10/664510/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/1"}}},"commit":{"parents":[{"commit":"307b15e2a3755c70a0e6062bad3bdb79e687c3d7","subject":"Merge \"Add \u0027additional_vips\u0027 field to driver datamodel\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/307b15e2a3755c70a0e6062bad3bdb79e687c3d7"}]}],"author":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-06-11 07:31:44.000000000","tz":-420},"committer":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-06-11 07:33:12.000000000","tz":-420},"subject":"Additional VIPs is also relevant in provider_base","message":"Additional VIPs is also relevant in provider_base\n\nThough this is just an abstract class so it doesn\u0027t break functionality,\nit should be kept up to date for the sake of implementers.\n\nStory: 2005608\nTask: 33612\nChange-Id: I29db66a282886ced2bd1bc1176f279728e5137e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/4c5be4f67b7cd7023cf955e5bc2ec465c26f8d31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/4c5be4f67b7cd7023cf955e5bc2ec465c26f8d31"}]},"branch":"refs/heads/master"},"fc609eeb2cbc41cc8985db551f66129563aa3c21":{"kind":"REWORK","_number":2,"created":"2019-06-11 08:43:57.000000000","uploader":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"ref":"refs/changes/10/664510/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia-lib","ref":"refs/changes/10/664510/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/2"}}},"commit":{"parents":[{"commit":"307b15e2a3755c70a0e6062bad3bdb79e687c3d7","subject":"Merge \"Add \u0027additional_vips\u0027 field to driver datamodel\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/307b15e2a3755c70a0e6062bad3bdb79e687c3d7"}]}],"author":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-06-11 07:31:44.000000000","tz":-420},"committer":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-06-11 08:43:48.000000000","tz":-420},"subject":"Additional VIPs is also relevant in provider_base","message":"Additional VIPs is also relevant in provider_base\n\nThough this is just an abstract class so it doesn\u0027t break functionality,\nit should be kept up to date for the sake of implementers.\n\nStory: 2005608\nTask: 33612\nChange-Id: I29db66a282886ced2bd1bc1176f279728e5137e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/fc609eeb2cbc41cc8985db551f66129563aa3c21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/fc609eeb2cbc41cc8985db551f66129563aa3c21"}]},"branch":"refs/heads/master"},"79848fe84aa4363916f7028b1bfe0355e8117bb7":{"kind":"REWORK","_number":3,"created":"2019-06-18 09:31:24.000000000","uploader":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"ref":"refs/changes/10/664510/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia-lib","ref":"refs/changes/10/664510/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia-lib refs/changes/10/664510/3"}}},"commit":{"parents":[{"commit":"307b15e2a3755c70a0e6062bad3bdb79e687c3d7","subject":"Merge \"Add \u0027additional_vips\u0027 field to driver datamodel\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/307b15e2a3755c70a0e6062bad3bdb79e687c3d7"}]}],"author":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-06-11 07:31:44.000000000","tz":-420},"committer":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-06-18 09:31:15.000000000","tz":-420},"subject":"Additional VIPs is also relevant in provider_base","message":"Additional VIPs is also relevant in provider_base\n\nThough this is just an abstract class so it doesn\u0027t break functionality,\nit should be kept up to date for the sake of implementers.\n\nStory: 2005608\nTask: 33612\nChange-Id: I29db66a282886ced2bd1bc1176f279728e5137e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/79848fe84aa4363916f7028b1bfe0355e8117bb7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia-lib/commit/79848fe84aa4363916f7028b1bfe0355e8117bb7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
