)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dfdbd3b3773fc6d52a8b648850893a83614aa294","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding cipher list Support for provider drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"updated the data models for pools and listners to"},{"line_number":10,"context_line":"add support for cipher lists and added the needed"},{"line_number":11,"context_line":"constants"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"df33271e_440ddc35","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":46},"updated":"2020-03-27 01:05:48.000000000","message":"nit: listeners","commit_id":"6a08eef86bef1a2b4ead2fea1f58b777525f8bee"}],"octavia_lib/api/drivers/data_models.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8489a931b00303e99a6e25f70dc45b91d6888e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"df33271e_2c107101","side":"PARENT","updated":"2020-03-27 17:23:37.000000000","message":"Yeah I see what you were talking about, Michael -- why did this change? O_o\nThese files shouldn\u0027t really be executable.","commit_id":"c565e7b2897514f3a7ab76018d8772c8e9ffe1c4"}],"octavia_lib/common/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce9278012fdc21582cfbb8711307fd2c3989f4b1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"CRL_CONTAINER_REF \u003d \u0027crl_container_ref\u0027"},{"line_number":197,"context_line":"DEFAULT_POOL \u003d \u0027default_pool\u0027"},{"line_number":198,"context_line":"DEFAULT_POOL_ID \u003d \u0027default_pool_id\u0027"},{"line_number":199,"context_line":"TLS_CIPHERS \u003d \u0027tls_ciphers\u0027"},{"line_number":200,"context_line":"DEFAULT_TLS_CONTAINER_DATA \u003d \u0027default_tls_container_data\u0027"},{"line_number":201,"context_line":"DEFAULT_TLS_CONTAINER_REF \u003d \u0027default_tls_container_ref\u0027"},{"line_number":202,"context_line":"DELAY \u003d \u0027delay\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_f565c446","line":199,"updated":"2020-03-26 20:02:45.000000000","message":"nit: this file is in alphabetical order so this should be on L251","commit_id":"a0f929cb62118d570e1e8f38dc7be5226c760e91"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"79876cf7fb6f630fd9c309f3e5c0e1df102f8d85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"df33271e_ac03e1b7","side":"PARENT","updated":"2020-03-27 17:24:01.000000000","message":"Here too","commit_id":"c565e7b2897514f3a7ab76018d8772c8e9ffe1c4"}],"octavia_lib/tests/unit/api/drivers/test_data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bfadf2a85c323df49dee02d24beb32b98460ac64","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                            \u0027vip_qos_policy_id\u0027: self.vip_qos_policy_id,"},{"line_number":209,"context_line":"                            \u0027availability_zone\u0027: self.availability_zone}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.ref_listener_dict \u003d {"},{"line_number":212,"context_line":"            \u0027admin_state_up\u0027: True,"},{"line_number":213,"context_line":"            \u0027connection_limit\u0027: 5000,"},{"line_number":214,"context_line":"            \u0027default_pool\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_9acc66bd","line":211,"updated":"2020-03-26 17:36:31.000000000","message":"tls_ciphers is missing here.","commit_id":"48fe5b626449aaf3ffd94af9b3216c1737ca5a84"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce9278012fdc21582cfbb8711307fd2c3989f4b1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            \u0027connection_limit\u0027: 5000,"},{"line_number":214,"context_line":"            \u0027default_pool\u0027: None,"},{"line_number":215,"context_line":"            \u0027default_pool_id\u0027: None,"},{"line_number":216,"context_line":"            \u0027tls_ciphers\u0027: None,"},{"line_number":217,"context_line":"            \u0027default_tls_container_data\u0027: \u0027default_cert_data\u0027,"},{"line_number":218,"context_line":"            \u0027default_tls_container_ref\u0027: self.default_tls_container_ref,"},{"line_number":219,"context_line":"            \u0027description\u0027: None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_f5cae417","line":216,"updated":"2020-03-26 20:02:45.000000000","message":"nit: should probable be last item as it\u0027s newest added","commit_id":"a0f929cb62118d570e1e8f38dc7be5226c760e91"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce9278012fdc21582cfbb8711307fd2c3989f4b1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027domain_name\u0027: \u0027testdomainname.com\u0027}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        self.ref_pool_dict \u003d {"},{"line_number":296,"context_line":"            \u0027tls_ciphers\u0027: None,"},{"line_number":297,"context_line":"            \u0027admin_state_up\u0027: True,"},{"line_number":298,"context_line":"            \u0027description\u0027: \u0027A pool\u0027,"},{"line_number":299,"context_line":"            \u0027healthmonitor\u0027: self.ref_healthmonitor_dict,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_95db98eb","line":296,"updated":"2020-03-26 20:02:45.000000000","message":"Same","commit_id":"a0f929cb62118d570e1e8f38dc7be5226c760e91"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"79876cf7fb6f630fd9c309f3e5c0e1df102f8d85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"df33271e_8cfeddab","side":"PARENT","updated":"2020-03-27 17:24:01.000000000","message":"And here","commit_id":"c565e7b2897514f3a7ab76018d8772c8e9ffe1c4"}],"releasenotes/notes/adding-cipher-list-support-for-provider-drivers-6a4dbec2d0254aae.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dfdbd3b3773fc6d52a8b648850893a83614aa294","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a parameter called tls_ciphers for"},{"line_number":5,"context_line":"    passing openSSL cipher strings in pools"},{"line_number":6,"context_line":"    and listeners."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df33271e_44267cb9","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":40},"updated":"2020-03-27 01:05:48.000000000","message":"nit: if you respin you can make this ``tls_ciphers`` which will make it bold in the release notes.","commit_id":"6a08eef86bef1a2b4ead2fea1f58b777525f8bee"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dfdbd3b3773fc6d52a8b648850893a83614aa294","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a parameter called tls_ciphers for"},{"line_number":5,"context_line":"    passing openSSL cipher strings in pools"},{"line_number":6,"context_line":"    and listeners."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df33271e_a43ca8c8","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":19},"updated":"2020-03-27 01:05:48.000000000","message":"OpenSSL","commit_id":"6a08eef86bef1a2b4ead2fea1f58b777525f8bee"}],"releasenotes/notes/cipher-list-support-for-provider-drivers-ebca21b62dd4c63a.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"88fb19c353d14884f20c85672d387ca141b7d9d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a prameter called tls_ciphers for"},{"line_number":5,"context_line":"    passing openSSL cipher stirings in pools"},{"line_number":6,"context_line":"    and listners."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_f892d94a","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":20},"updated":"2020-03-26 20:45:46.000000000","message":"parameter","commit_id":"e05d17b5bf7d2889d098431cba87bafa363a8732"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"88fb19c353d14884f20c85672d387ca141b7d9d2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a prameter called tls_ciphers for"},{"line_number":5,"context_line":"    passing openSSL cipher stirings in pools"},{"line_number":6,"context_line":"    and listners."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_589ae562","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":35},"updated":"2020-03-26 20:45:46.000000000","message":"strings","commit_id":"e05d17b5bf7d2889d098431cba87bafa363a8732"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"88fb19c353d14884f20c85672d387ca141b7d9d2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a prameter called tls_ciphers for"},{"line_number":5,"context_line":"    passing openSSL cipher stirings in pools"},{"line_number":6,"context_line":"    and listners."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_789ec954","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":16},"updated":"2020-03-26 20:45:46.000000000","message":"listeners","commit_id":"e05d17b5bf7d2889d098431cba87bafa363a8732"}],"zuul.d/projects.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce9278012fdc21582cfbb8711307fd2c3989f4b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-tips"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_35ee0c88","side":"PARENT","line":9,"updated":"2020-03-26 20:02:45.000000000","message":"??","commit_id":"c565e7b2897514f3a7ab76018d8772c8e9ffe1c4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"88fb19c353d14884f20c85672d387ca141b7d9d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-tips"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_987e2d17","side":"PARENT","line":9,"in_reply_to":"df33271e_35ee0c88","updated":"2020-03-26 20:45:46.000000000","message":"I did this, we have a bit of a test loop here with the functional tests this pulls in. The unit tests passed on an earlier run, so I think it\u0027s ok to remove this here for now.","commit_id":"c565e7b2897514f3a7ab76018d8772c8e9ffe1c4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fd0d1c282ad19727ad9466ae983720ddc83ea70e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"df33271e_7bf403d0","updated":"2020-03-26 21:33:53.000000000","message":"You cannot delete this file, it is required to run the tests.","commit_id":"4ef7757e28ad243ac48983ed8b58b1a28393a7c0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8489a931b00303e99a6e25f70dc45b91d6888e27","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-tips"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df33271e_8c69bd8c","side":"PARENT","line":9,"updated":"2020-03-27 17:23:37.000000000","message":"Could we have a follow-up patch ready to go that depends on the other change, to add this back? (I assume this was removed to resolve a circular dependency issue)","commit_id":"c565e7b2897514f3a7ab76018d8772c8e9ffe1c4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71c33771694e0c0c74cff9b4f1563d3a10bd7fc4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - check-requirements"},{"line_number":4,"context_line":"      - openstack-cover-jobs"},{"line_number":5,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-tips:"},{"line_number":10,"context_line":"          voting: false"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df33271e_97226aff","line":10,"range":{"start_line":1,"start_character":2,"end_line":10,"end_character":0},"updated":"2020-03-27 18:21:25.000000000","message":"expected str @ data[\u0027templates\u0027][6]","commit_id":"3aa316b1b9fd4cdb28448bbd7fd349694954e356"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3b355f05f0185ae6e089ab079b09ae60d92e000b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - check-requirements"},{"line_number":4,"context_line":"      - openstack-cover-jobs"},{"line_number":5,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-py37-tips"},{"line_number":10,"context_line":"    jobs:"},{"line_number":11,"context_line":"      - octavia-tox-functional-py37-tips:"},{"line_number":12,"context_line":"          voting: false"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"df33271e_72e25431","line":12,"range":{"start_line":1,"start_character":2,"end_line":12,"end_character":0},"updated":"2020-03-27 18:49:17.000000000","message":"expected a dictionary for dictionary value @ data[\u0027jobs\u0027]","commit_id":"82721848475417177d32f9025bf4e95ceb725e6f"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"855f9dea23b16eeecfc18c3090842d1b9ac69381","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-py37-tips"},{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - octavia-tox-functional-py37-tips:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df33271e_32cbac72","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":29},"updated":"2020-03-27 19:00:28.000000000","message":"This is `octavia-tox-tips`","commit_id":"3dbdfbfb84532a24760be2a35735c3b0f93ef257"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b6d575169b033107cd449f43be71b738dfc033e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - check-requirements"},{"line_number":4,"context_line":"      - openstack-cover-jobs"},{"line_number":5,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":6,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"},{"line_number":8,"context_line":"      - release-notes-jobs-python3"},{"line_number":9,"context_line":"      - octavia-tox-py37-tips"},{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - octavia-tox-functional-py37-tips:"},{"line_number":13,"context_line":"            voting: false"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df33271e_d2bc00de","line":13,"range":{"start_line":1,"start_character":2,"end_line":13,"end_character":0},"updated":"2020-03-27 18:58:31.000000000","message":"The project template \"octavia-tox-py37-tips\" was not found.","commit_id":"3dbdfbfb84532a24760be2a35735c3b0f93ef257"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dd4496da760fbcd2a704a6a4ab0fa0777f60d01f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - octavia-tox-functional-py37-tips:"},{"line_number":13,"context_line":"            voting: false"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df33271e_62db867b","line":13,"updated":"2020-03-30 13:24:24.000000000","message":"I know Michael +2\u0027d it, but this seems like an odd addition to this patch to me, unless it showed the ciphers being used I guess.","commit_id":"3e1278391fcfb7d14b651e2fdb380dae35cd28cd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2edae910c3556ef3dd354c0fc03faa253a0afd7e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    check:"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - octavia-tox-functional-py37-tips:"},{"line_number":13,"context_line":"            voting: false"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df33271e_e831355c","line":13,"in_reply_to":"df33271e_62db867b","updated":"2020-03-30 14:40:42.000000000","message":"Yeah there was some discussion on IRC and in the patch history around this -- basically we suffer from a circular dependency issue any time a change adds fields in certain places... This can be a ... problem. We\u0027re thinking on ways to address it permanently, but for now the compromise was to leave the job but make it non-voting.","commit_id":"3e1278391fcfb7d14b651e2fdb380dae35cd28cd"}]}