)]}'
{"octavia_lib/common/constants.py":[{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"271898f02bfede5ca1ba0f5015354dee27c9f702","unresolved":false,"context_lines":[{"line_number":237,"context_line":"# PROTOCOL_MAXIMUM gets the most recent version"},{"line_number":238,"context_line":"# PROTOCOL_LIST_RECOMMENDED are non-deprecated versions of TLS and SSL,"},{"line_number":239,"context_line":"# all other versions are deprecated (but still available for use)"},{"line_number":240,"context_line":"PROTOCOL_SSL_3_1 \u003d \u0027SSLv3.1\u0027"},{"line_number":241,"context_line":"PROTOCOL_TLS_1 \u003d \u0027TLSv1\u0027"},{"line_number":242,"context_line":"PROTOCOL_TLS_1_1 \u003d \u0027TLSv1.1\u0027"},{"line_number":243,"context_line":"PROTOCOL_TLS_1_2 \u003d \u0027TLSv1.2\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_17de5a3e","line":240,"updated":"2020-03-27 20:05:29.000000000","message":"Should be SSLv3","commit_id":"bd183dccb4d77f60af2afb1326796cb25a789b8e"},{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"271898f02bfede5ca1ba0f5015354dee27c9f702","unresolved":false,"context_lines":[{"line_number":238,"context_line":"# PROTOCOL_LIST_RECOMMENDED are non-deprecated versions of TLS and SSL,"},{"line_number":239,"context_line":"# all other versions are deprecated (but still available for use)"},{"line_number":240,"context_line":"PROTOCOL_SSL_3_1 \u003d \u0027SSLv3.1\u0027"},{"line_number":241,"context_line":"PROTOCOL_TLS_1 \u003d \u0027TLSv1\u0027"},{"line_number":242,"context_line":"PROTOCOL_TLS_1_1 \u003d \u0027TLSv1.1\u0027"},{"line_number":243,"context_line":"PROTOCOL_TLS_1_2 \u003d \u0027TLSv1.2\u0027"},{"line_number":244,"context_line":"PROTOCOL_TLS_1_3 \u003d \u0027TLSv1.3\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3d3a5d33","line":241,"updated":"2020-03-27 20:05:29.000000000","message":"nit: I wonder if these would be better named something like TLS_VERSION_*.  The only reason I say this is PROTOCOL_* in most other usages refers to protocols that are used to connect to the listener (like UDP, TCP, HTTP etc.). (Although I\u0027m not experienced enough to say whether that\u0027s an actual convention or not)","commit_id":"bd183dccb4d77f60af2afb1326796cb25a789b8e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"17a845db5d5538273b0fdff8e4216433a5726453","unresolved":false,"context_lines":[{"line_number":242,"context_line":"TLS_VERSION_1_1 \u003d \u0027TLSv1.1\u0027"},{"line_number":243,"context_line":"TLS_VERSION_1_2 \u003d \u0027TLSv1.2\u0027"},{"line_number":244,"context_line":"TLS_VERSION_1_3 \u003d \u0027TLSv1.3\u0027"},{"line_number":245,"context_line":"TLS_VERSION_MAXIMUM \u003d TLS_VERSION_1_3"},{"line_number":246,"context_line":"TLS_VERSIONS_ALL \u003d [TLS_VERSION_1_3, TLS_VERSION_1_2,"},{"line_number":247,"context_line":"                    TLS_VERSION_1_1, TLS_VERSION_1, SSL_VERSION_3]"},{"line_number":248,"context_line":"TLS_VERSIONS_RECOMMENDED \u003d [TLS_VERSION_1_3, TLS_VERSION_1_2]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_1acaec9f","line":245,"updated":"2020-03-30 04:52:47.000000000","message":"This file is for multiple drivers, I don\u0027t think we should define a maximum here. If we need one for the amphora driver, we should do that in the main common/constants.py","commit_id":"f47446611ff6dc652a0d2a8ddf0a3009db03728f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"17a845db5d5538273b0fdff8e4216433a5726453","unresolved":false,"context_lines":[{"line_number":245,"context_line":"TLS_VERSION_MAXIMUM \u003d TLS_VERSION_1_3"},{"line_number":246,"context_line":"TLS_VERSIONS_ALL \u003d [TLS_VERSION_1_3, TLS_VERSION_1_2,"},{"line_number":247,"context_line":"                    TLS_VERSION_1_1, TLS_VERSION_1, SSL_VERSION_3]"},{"line_number":248,"context_line":"TLS_VERSIONS_RECOMMENDED \u003d [TLS_VERSION_1_3, TLS_VERSION_1_2]"},{"line_number":249,"context_line":"REDIRECT_HTTP_CODE \u003d \u0027redirect_http_code\u0027"},{"line_number":250,"context_line":"REDIRECT_POOL_ID \u003d \u0027redirect_pool_id\u0027"},{"line_number":251,"context_line":"REDIRECT_PREFIX \u003d \u0027redirect_prefix\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_3ac41091","line":248,"updated":"2020-03-30 04:52:47.000000000","message":"Same here, this seems driver specific and probably should move to the octavia common/constants.py","commit_id":"f47446611ff6dc652a0d2a8ddf0a3009db03728f"}],"octavia_lib/tests/unit/api/drivers/test_data_models.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"bd7b2266e9f2050603636e5cc42b89962ae85b7e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            client_crl_container_data\u003dNone,"},{"line_number":102,"context_line":"            client_crl_container_ref\u003dNone,"},{"line_number":103,"context_line":"            allowed_cidrs\u003dNone,"},{"line_number":104,"context_line":"            tls_versions\u003d[\u0027SSLv3\u0027, \u0027TLSv1\u0027, \u0027TLSv1.1\u0027,"},{"line_number":105,"context_line":"                          \u0027TLSv1.2\u0027, \u0027TLSv1.3\u0027],"},{"line_number":106,"context_line":"            tls_ciphers\u003dNone)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_aff553ef","line":104,"updated":"2020-03-31 17:44:58.000000000","message":"Maybe use the constants you\u0027ve created instead?","commit_id":"f54768b3110b693d44538ba48f61db12061b3ba5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fcf2078e942d86aacd5408b4c90ca5d89ab05a4e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            client_crl_container_data\u003dNone,"},{"line_number":102,"context_line":"            client_crl_container_ref\u003dNone,"},{"line_number":103,"context_line":"            allowed_cidrs\u003dNone,"},{"line_number":104,"context_line":"            tls_versions\u003d[\u0027SSLv3\u0027, \u0027TLSv1\u0027, \u0027TLSv1.1\u0027,"},{"line_number":105,"context_line":"                          \u0027TLSv1.2\u0027, \u0027TLSv1.3\u0027],"},{"line_number":106,"context_line":"            tls_ciphers\u003dNone)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_17171fa6","line":104,"in_reply_to":"df33271e_aff553ef","updated":"2020-04-01 16:31:29.000000000","message":"+1, it would be best to use the constants.","commit_id":"f54768b3110b693d44538ba48f61db12061b3ba5"}]}