)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"e36343e64ed64f22d8fdc88d302b9feaf3885b79","unresolved":false,"context_lines":[{"line_number":10,"context_line":"configurations are actually enforced at the traffic level by the"},{"line_number":11,"context_line":"amphora, not just stored by the API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Tests added to TLSWithBarbicanTest in test_tls_barbican.py:"},{"line_number":14,"context_line":"- test_tls_version_enforcement: TLS 1.2-only listener rejects TLS 1.3"},{"line_number":15,"context_line":"- test_tls_cipher_enforcement: single-cipher listener rejects other"},{"line_number":16,"context_line":"  ciphers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"106d8d6a_d9d41259","line":13,"updated":"2026-08-14 07:49:39.000000000","message":"For completeness, it might be worth adding the new tests here","commit_id":"bb5fc3e11cddaff0f79bbc455474571637eb5779"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8abb5cd9364d276ef51429414a9fb5b20d43fa4f","unresolved":true,"context_lines":[{"line_number":22,"context_line":"specific version/cipher constraints and verify the amphora accepts"},{"line_number":23,"context_line":"allowed configurations and rejects disallowed ones via SSLError."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: I8188836b660775a20d1f741ca2c8fe8df5740bfb"},{"line_number":26,"context_line":"Change-Id: I8cf09445d8c24c84d726f554eb8cbb6c64569da9"},{"line_number":27,"context_line":"Signed-off-by: lavraham \u003clavraham@redhat.com\u003e"},{"line_number":28,"context_line":"Co-Authored-By: Claude Opus 4.6 \u003cnoreply@anthropic.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6741824e_bf9142cf","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":53},"updated":"2026-08-14 09:00:04.000000000","message":"Depends-On is not needed as it\u0027s the parent commit, it\u0027s already included in the branch","commit_id":"bb5fc3e11cddaff0f79bbc455474571637eb5779"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"d1521dadb90e55922f0152d84a95de23749aa7bc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"specific version/cipher constraints and verify the amphora accepts"},{"line_number":23,"context_line":"allowed configurations and rejects disallowed ones via SSLError."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Depends-On: I8188836b660775a20d1f741ca2c8fe8df5740bfb"},{"line_number":26,"context_line":"Change-Id: I8cf09445d8c24c84d726f554eb8cbb6c64569da9"},{"line_number":27,"context_line":"Signed-off-by: lavraham \u003clavraham@redhat.com\u003e"},{"line_number":28,"context_line":"Co-Authored-By: Claude Opus 4.6 \u003cnoreply@anthropic.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"091c57d6_af46ac4e","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":53},"in_reply_to":"6741824e_bf9142cf","updated":"2026-08-16 09:20:42.000000000","message":"Done","commit_id":"bb5fc3e11cddaff0f79bbc455474571637eb5779"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b3d7b17cb0fc1022a54cab70db1017922a7a015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14923e8b_a6269546","updated":"2026-08-11 09:14:19.000000000","message":"Great stuff! I think we only need to polish a few things and add more coverage for some missed cases","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"8a1c99b0e7daef6e92234ca9c3f1b3d1abaf9a23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07560d77_6e11b690","updated":"2026-08-11 10:50:28.000000000","message":"I think Greg covered all the points that I was going to make so I won\u0027t repeat them. I think once the issue addressed then it should be good to go\n\nReviewed with help from Claude Sonnet 4.6","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":38562,"name":"Richard Cruise","email":"rcruise@redhat.com","username":"rcruise"},"change_message_id":"e36343e64ed64f22d8fdc88d302b9feaf3885b79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af42e900_926eed4d","updated":"2026-08-14 07:49:39.000000000","message":"LGTM, one minor issus is the commit message is out of date. Reviewed with help from Claude Sonnet 5","commit_id":"bb5fc3e11cddaff0f79bbc455474571637eb5779"}],"octavia_tempest_plugin/tests/barbican_scenario/v2/test_tls_barbican.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b3d7b17cb0fc1022a54cab70db1017922a7a015","unresolved":true,"context_lines":[{"line_number":1799,"context_line":"        # Test HTTP listener load balancing."},{"line_number":1800,"context_line":"        self.check_members_balanced(self.lb_vip_address)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000001\u0027)"},{"line_number":1803,"context_line":"    def test_tls_version_enforcement(self):"},{"line_number":1804,"context_line":"        \"\"\"Test that the listener enforces configured tls_versions."},{"line_number":1805,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"44d33a69_87fe77a6","line":1802,"range":{"start_line":1802,"start_character":31,"end_line":1802,"end_character":67},"updated":"2026-08-11 09:14:19.000000000","message":"these UUIDs don\u0027t look really random, please replace them with a real generated UUIDs (\"uuidgen\")","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"1dae4cc1ef5953b1c202e036a0d2ddcb092c0d03","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        # Test HTTP listener load balancing."},{"line_number":1800,"context_line":"        self.check_members_balanced(self.lb_vip_address)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000001\u0027)"},{"line_number":1803,"context_line":"    def test_tls_version_enforcement(self):"},{"line_number":1804,"context_line":"        \"\"\"Test that the listener enforces configured tls_versions."},{"line_number":1805,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6ba8d283_17339b42","line":1802,"range":{"start_line":1802,"start_character":31,"end_line":1802,"end_character":67},"in_reply_to":"44d33a69_87fe77a6","updated":"2026-08-12 12:46:34.000000000","message":"Done","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b3d7b17cb0fc1022a54cab70db1017922a7a015","unresolved":true,"context_lines":[{"line_number":1800,"context_line":"        self.check_members_balanced(self.lb_vip_address)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000001\u0027)"},{"line_number":1803,"context_line":"    def test_tls_version_enforcement(self):"},{"line_number":1804,"context_line":"        \"\"\"Test that the listener enforces configured tls_versions."},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"        Create a listener restricted to TLS 1.2 only, verify TLS 1.2"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c6654f7_6691bdd6","line":1803,"range":{"start_line":1803,"start_character":8,"end_line":1803,"end_character":36},"updated":"2026-08-11 09:14:19.000000000","message":"we have\n`test_tls_version_enforcement`\n`test_tls13_only_enforcement`\nthat are basically the same tests, one with TLSv1.2, the second with TLSv1.3\nI think we need to be more constant with the names of the functions\n\nwhat about \n`test_tls12_only_enforcement` for the first one?","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"1dae4cc1ef5953b1c202e036a0d2ddcb092c0d03","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"        self.check_members_balanced(self.lb_vip_address)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000001\u0027)"},{"line_number":1803,"context_line":"    def test_tls_version_enforcement(self):"},{"line_number":1804,"context_line":"        \"\"\"Test that the listener enforces configured tls_versions."},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"        Create a listener restricted to TLS 1.2 only, verify TLS 1.2"}],"source_content_type":"text/x-python","patch_set":1,"id":"a91cf2c6_2743ef3d","line":1803,"range":{"start_line":1803,"start_character":8,"end_line":1803,"end_character":36},"in_reply_to":"9c6654f7_6691bdd6","updated":"2026-08-12 12:46:34.000000000","message":"Done","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b3d7b17cb0fc1022a54cab70db1017922a7a015","unresolved":true,"context_lines":[{"line_number":1857,"context_line":"                          (self.lb_vip_address, 10443))"},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000002\u0027)"},{"line_number":1860,"context_line":"    def test_tls_cipher_enforcement(self):"},{"line_number":1861,"context_line":"        \"\"\"Test that the listener enforces configured tls_ciphers."},{"line_number":1862,"context_line":""},{"line_number":1863,"context_line":"        Create a listener restricted to a single TLS 1.2 cipher, verify"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4545e4e_52a2fcdc","line":1860,"range":{"start_line":1860,"start_character":8,"end_line":1860,"end_character":35},"updated":"2026-08-11 09:14:19.000000000","message":"this test looks great but covers only TLSv1.2\ncan you add the same test with TLSv1.3?","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"1dae4cc1ef5953b1c202e036a0d2ddcb092c0d03","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"                          (self.lb_vip_address, 10443))"},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000002\u0027)"},{"line_number":1860,"context_line":"    def test_tls_cipher_enforcement(self):"},{"line_number":1861,"context_line":"        \"\"\"Test that the listener enforces configured tls_ciphers."},{"line_number":1862,"context_line":""},{"line_number":1863,"context_line":"        Create a listener restricted to a single TLS 1.2 cipher, verify"}],"source_content_type":"text/x-python","patch_set":1,"id":"27804291_0ac84329","line":1860,"range":{"start_line":1860,"start_character":8,"end_line":1860,"end_character":35},"in_reply_to":"c4545e4e_52a2fcdc","updated":"2026-08-12 12:46:34.000000000","message":"Done","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b3d7b17cb0fc1022a54cab70db1017922a7a015","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"                self.api_version, \u00272.15\u0027):"},{"line_number":1868,"context_line":"            raise self.skipException(\u0027tls_ciphers requires API v2.15+\u0027)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"        allowed_cipher \u003d \u0027ECDHE-RSA-AES256-GCM-SHA384\u0027"},{"line_number":1871,"context_line":"        rejected_cipher \u003d \u0027ECDHE-RSA-AES128-GCM-SHA256\u0027"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"        listener_name \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"0fe5baef_77b996c2","line":1870,"range":{"start_line":1870,"start_character":8,"end_line":1870,"end_character":54},"updated":"2026-08-11 09:14:19.000000000","message":"TLS_CIPHERS is a list of ciphers separated with a \u0027:\u0027\nI would suggest that we put 2 ciphers in the allowed_ciphers (and add a -s)\nand test that both are working.\nthat would give us better coverage","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"1dae4cc1ef5953b1c202e036a0d2ddcb092c0d03","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"                self.api_version, \u00272.15\u0027):"},{"line_number":1868,"context_line":"            raise self.skipException(\u0027tls_ciphers requires API v2.15+\u0027)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"        allowed_cipher \u003d \u0027ECDHE-RSA-AES256-GCM-SHA384\u0027"},{"line_number":1871,"context_line":"        rejected_cipher \u003d \u0027ECDHE-RSA-AES128-GCM-SHA256\u0027"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"        listener_name \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"560b4c95_a93c7aea","line":1870,"range":{"start_line":1870,"start_character":8,"end_line":1870,"end_character":54},"in_reply_to":"0fe5baef_77b996c2","updated":"2026-08-12 12:46:34.000000000","message":"Done","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b3d7b17cb0fc1022a54cab70db1017922a7a015","unresolved":true,"context_lines":[{"line_number":1978,"context_line":"                          (self.lb_vip_address, 10445))"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000004\u0027)"},{"line_number":1981,"context_line":"    def test_tls_version_update_enforcement(self):"},{"line_number":1982,"context_line":"        \"\"\"Test updating tls_versions changes enforcement at traffic level."},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":"        Create a listener allowing TLS 1.2 + 1.3, verify both work,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3731c23a_b2650801","line":1981,"range":{"start_line":1981,"start_character":8,"end_line":1981,"end_character":43},"updated":"2026-08-11 09:14:19.000000000","message":"perhaps we can also add a test_tls_cipher_update_enforcement test, what do you think about that?","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"},{"author":{"_account_id":34067,"name":"Lilach Avraham","email":"lavraham@redhat.com","username":"lavraham"},"change_message_id":"1dae4cc1ef5953b1c202e036a0d2ddcb092c0d03","unresolved":false,"context_lines":[{"line_number":1978,"context_line":"                          (self.lb_vip_address, 10445))"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"    @decorators.idempotent_id(\u0027c1d2e3f4-5001-4aaa-bbbb-500000000004\u0027)"},{"line_number":1981,"context_line":"    def test_tls_version_update_enforcement(self):"},{"line_number":1982,"context_line":"        \"\"\"Test updating tls_versions changes enforcement at traffic level."},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":"        Create a listener allowing TLS 1.2 + 1.3, verify both work,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a092e57e_0a94f692","line":1981,"range":{"start_line":1981,"start_character":8,"end_line":1981,"end_character":43},"in_reply_to":"3731c23a_b2650801","updated":"2026-08-12 12:46:34.000000000","message":"Done","commit_id":"6c74688bb4ec645183e4c1dee31017a41b0d0392"}]}