)]}'
{"octavia_tempest_plugin/tests/v2/scenario/test_qos.py":[{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"a7c5c57ee7d3d592323245f2db0b1959dadc5c7b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                             self.test_port2]}}"},{"line_number":160,"context_line":"        self.create_backend(extra_opts\u003dextra_opts)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _create_lb_single_env(self, create_with_qos\u003dFalse):"},{"line_number":163,"context_line":"        # Create loadbalancer"},{"line_number":164,"context_line":"        params \u003d {}"},{"line_number":165,"context_line":"        if self.vip_network_id:"},{"line_number":166,"context_line":"            params[\u0027vip_network_id\u0027] \u003d self.vip_network_id"},{"line_number":167,"context_line":"        if self.vip_subnet_id:"},{"line_number":168,"context_line":"            params[\u0027vip_subnet_id\u0027] \u003d self.vip_subnet_id"},{"line_number":169,"context_line":"        if create_with_qos:"},{"line_number":170,"context_line":"            params[\u0027vip_qos_policy_id\u0027] \u003d self.vip_qos_policy_id"},{"line_number":171,"context_line":"        self.create_loadbalancer(**params)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        for port in [self.test_port1, self.test_port2]:"},{"line_number":174,"context_line":"            # Create pool"},{"line_number":175,"context_line":"            pool1 \u003d self.create_pool(self.lb_id, protocol\u003d\u0027TCP\u0027)"},{"line_number":176,"context_line":"            self.pool_id1 \u003d pool1[\u0027id\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # Create listener"},{"line_number":179,"context_line":"            params \u003d {\u0027default_pool_id\u0027: self.pool_id1,"},{"line_number":180,"context_line":"                      \u0027protocol\u0027: \u0027TCP\u0027,"},{"line_number":181,"context_line":"                      \u0027protocol_port\u0027: port"},{"line_number":182,"context_line":"                      }"},{"line_number":183,"context_line":"            listener1 \u003d self.create_listener(self.lb_id, **params)"},{"line_number":184,"context_line":"            self.listener_id1 \u003d listener1[\u0027id\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"            # Add members to the pool"},{"line_number":187,"context_line":"            params \u003d {"},{"line_number":188,"context_line":"                \u0027address\u0027: self.vm_ip,"},{"line_number":189,"context_line":"                \u0027protocol_port\u0027: port"},{"line_number":190,"context_line":"            }"},{"line_number":191,"context_line":"            if self.member_subnet_id:"},{"line_number":192,"context_line":"                params[\u0027subnet_id\u0027] \u003d self.member_subnet_id"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"                self.create_member(self.pool_id1, self.lb_id, **params)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _get_current_bw(self, port):"},{"line_number":197,"context_line":"        start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_28d64b51","line":194,"range":{"start_line":162,"start_character":0,"end_line":194,"end_character":71},"updated":"2018-01-21 09:35:23.000000000","message":"May be  we should have the creation function defined not in the test it self but base.py or in API created functions and avoid duplicating code.","commit_id":"2a0fb62292ea0d255869687c96cd5abfafb6d1ab"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"5e7acba7e03632b73fd7bc9c6a8dbeeec5d5ae36","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                             self.test_port2]}}"},{"line_number":160,"context_line":"        self.create_backend(extra_opts\u003dextra_opts)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _create_lb_single_env(self, create_with_qos\u003dFalse):"},{"line_number":163,"context_line":"        # Create loadbalancer"},{"line_number":164,"context_line":"        params \u003d {}"},{"line_number":165,"context_line":"        if self.vip_network_id:"},{"line_number":166,"context_line":"            params[\u0027vip_network_id\u0027] \u003d self.vip_network_id"},{"line_number":167,"context_line":"        if self.vip_subnet_id:"},{"line_number":168,"context_line":"            params[\u0027vip_subnet_id\u0027] \u003d self.vip_subnet_id"},{"line_number":169,"context_line":"        if create_with_qos:"},{"line_number":170,"context_line":"            params[\u0027vip_qos_policy_id\u0027] \u003d self.vip_qos_policy_id"},{"line_number":171,"context_line":"        self.create_loadbalancer(**params)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        for port in [self.test_port1, self.test_port2]:"},{"line_number":174,"context_line":"            # Create pool"},{"line_number":175,"context_line":"            pool1 \u003d self.create_pool(self.lb_id, protocol\u003d\u0027TCP\u0027)"},{"line_number":176,"context_line":"            self.pool_id1 \u003d pool1[\u0027id\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # Create listener"},{"line_number":179,"context_line":"            params \u003d {\u0027default_pool_id\u0027: self.pool_id1,"},{"line_number":180,"context_line":"                      \u0027protocol\u0027: \u0027TCP\u0027,"},{"line_number":181,"context_line":"                      \u0027protocol_port\u0027: port"},{"line_number":182,"context_line":"                      }"},{"line_number":183,"context_line":"            listener1 \u003d self.create_listener(self.lb_id, **params)"},{"line_number":184,"context_line":"            self.listener_id1 \u003d listener1[\u0027id\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"            # Add members to the pool"},{"line_number":187,"context_line":"            params \u003d {"},{"line_number":188,"context_line":"                \u0027address\u0027: self.vm_ip,"},{"line_number":189,"context_line":"                \u0027protocol_port\u0027: port"},{"line_number":190,"context_line":"            }"},{"line_number":191,"context_line":"            if self.member_subnet_id:"},{"line_number":192,"context_line":"                params[\u0027subnet_id\u0027] \u003d self.member_subnet_id"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"                self.create_member(self.pool_id1, self.lb_id, **params)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _get_current_bw(self, port):"},{"line_number":197,"context_line":"        start_time \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_38aa1219","line":194,"range":{"start_line":162,"start_character":0,"end_line":194,"end_character":71},"in_reply_to":"7f96bb07_28d64b51","updated":"2018-01-22 06:40:12.000000000","message":"Hmmm, No. I don\u0027t think so. \"base.py\" providers the basic operation for LB, including client, associated resources creation. That\u0027s OK. But this is scenario test. We need to construct the env we want to test on that. This is not for a communal creat function. And I use the basic function to create the test env from \"base.py\". If we add them into the base.py once we intro a new scenario test. What it will look like？ Thought?","commit_id":"2a0fb62292ea0d255869687c96cd5abfafb6d1ab"}]}